Clumps incompatibility
Desempregago opened this issue · 12 comments
Describe the bug
For some reason, after an item gets repaired, OM skips through the entire hotbar, even if there are other Mending-enchanted items present on it.
Video Proof (around 0:38 to be more exact)
Minecraft version
1.18
Fabric API version
0.44.0
Mod version
2.2.6
Relevant log output
No response
I can't manage to reproduce it. Can you try to reproduce it yourself with this version?
I added logs. It may create quite larger log files so maybe don't use it for too long.
Though if you manage to reproduce it I'd be interested in the logs it gives when the issue happens.
Logs are Selected for mending: ..... & Potential item found for mending: ...
Mod list
PS: I already tested without the XP changing mods, like Linear XP (changes xp level up "costs")
From what I can see Clumps is also doing some logic when an xp orb is picked up (basically it restores the xp of all the orbs it accumulated).
As the orb is processed and then the event is cancelled then there's nothing left for OM to do.
I guess there's nothing doable here, mods are simply incompatible.
From my point of view Clumps shouldn't really have to override the "playerTouch" method as it already redefines the value of the orb, but there must be a reason behind it (maybe to have a proper behavior of the normal mending, as if you merged t50 orbs then mending is applied 50 times individually instead of 1 time with the merged value).
As I don't really see any solutions for now I'll just mention in the description that these mods are incompatible.
Not sure if somethings changed as this issue was made years ago, but I'm using both clumps and this mod and they work together with no issue. Items in my inventory and hotbar that aren't equipped can be repaired with xp.