oωo (owo-lib)

oωo (owo-lib)

Mods
17M Downloads

Crash only reproducible if Minecraft freezes and you remove a parent component

Zailer43 opened this issue · 1 comments

commented

Description

I was with a friend on a server and he crashed using my mod, I asked him for the crash report, and from what I could notice, I can't reproduce it. Then he told me that Minecraft froze before the crash, which makes sense if we look at where it crashed. When calling the queue parent, it wasn't null, but inside the queue it was because while it froze, he clicked and closed an overlay that was the parent.

owo-lib/src/main/java/io/wispforest/owo/ui/core/Component.java

Lines 314 to 319 in a06c477

default void remove() {
if (!this.hasParent()) return;
this.parent().queue(() -> {
this.parent().removeChild(this);
});
}

Crash log

https://gist.github.com/Zailer43/dcac94e1897b86ab30a5eba98a0d54e3

Versions

owo-lib = 0.12.6+1.20.3
fabric-api = 0.96.1+1.20.4

commented

I can certainly see how this would happen, I'll probably just capture the parent at queue time and pass that into the actual task. Given how this is a rather non-critical problem though it might be a little while before I actually get around to implementing and publishing that

Either way, thanks for reporting!
Cheers

  • 👍1