Network error spam with particle systems on 1.21.1 Neoforge
Rearth opened this issue · 2 comments
Hi, I'm using the owo lib ParticleSystemController / ParticleSystem feature a lot in Oritech (both on fabric and neoforge). I recently was made aware that the neoforge version of owo lib logs an error every time a particle is spawned on the server side. The particles still spawn just fine, but with multiple machines potentially creating particles every tick, it quickly adds up to the logs being unusable.
I hope it's okay for me to create issues about the Neoforge version of owo lib here, I wasn't able to create issues in the NF branch.
Original issue with logs: Rearth/Oritech#358
Particle code (in case I'm just doing something wrong): https://github.com/Rearth/Oritech/blob/1.21/common/src/main/java/rearth/oritech/client/init/ParticleContent.java
Hopefully such has been fixed by using native-ish neoforge networking for 1.21.1 but still odd how the code never really indicate the root cause for such.
From my cursory glance (and super limited knowledge of NF networking) it looks like the particle controller's channel is not being registered correctly - this could be super wrong so feel free to ignore.
The code is Oritech looks correct to me