oωo (owo-lib)

Minecraft's DrawContext#enableScissor(int, int, int, int) transformes the Scissor according to the MatrixStack:
(Snipper)

public void enableScissor(int x1, int y1, int x2, int y2) {
  ScreenRect screenRect = (new ScreenRect(x1, y1, x2 - x1, y2 - y1)).transform(this.matrices);
  this.scissorStack.push(screenRect);
}

However, owo's intersectsScissor does not respect that transformation:

owo-lib/src/main/java/io/wispforest/owo/ui/core/OwoUIDrawContext.java

Lines 64 to 75 in 94e0c37

    
           public boolean intersectsScissor(PositionedRectangle other) { 
        
               var rect = this.scissorStack.peekLast(); 
        
               if (rect == null) return true; 
        
               var pos = rect.position(); 
        
               return other.x() < pos.x() + rect.width() 
        
                   && other.x() + other.width() >= pos.x() 
        
                   && other.y() < pos.y() + rect.height() 
        
                   && other.y() + other.height() >= pos.y(); 
        
           }

This is fine as long as the translation is 0,0.
When rendering a toast for example, then it is not possible to use OwoUIAdapter, because it scissors the entire screen (which isn't an issue):

owo-lib/src/main/java/io/wispforest/owo/ui/core/OwoUIAdapter.java

Lines 180 to 182 in 94e0c37

    
           context.enableScissor(0, 0, window.getFramebufferWidth(), window.getFramebufferHeight()); 
        
           this.rootComponent.draw(owoContext, mouseX, mouseY, partialTicks, delta); 
        
           context.disableScissor();

But then BaseParentComponent checks for the scissor intersection before drawing:

owo-lib/src/main/java/io/wispforest/owo/ui/base/BaseParentComponent.java

Line 349 in 94e0c37

if (!context.intersectsScissor(child)) continue;

The scissor intersection returns false, even though it should return true. And the toast won't render.

Should be fixed in 93380d5

	public boolean intersectsScissor(PositionedRectangle other) {
	var rect = this.scissorStack.peekLast();

	if (rect == null) return true;

	var pos = rect.position();

	return other.x() < pos.x() + rect.width()
	&& other.x() + other.width() >= pos.x()
	&& other.y() < pos.y() + rect.height()
	&& other.y() + other.height() >= pos.y();
	}

	context.enableScissor(0, 0, window.getFramebufferWidth(), window.getFramebufferHeight());
	this.rootComponent.draw(owoContext, mouseX, mouseY, partialTicks, delta);
	context.disableScissor();

Share to