Packed Up (Backpacks)

Packed Up (Backpacks)

3M Downloads

packed up vs other curios mod (pmmo) compatibility

Chipmonk2 opened this issue ยท 7 comments

commented

Version Info
Minecraft: 1.21.1
Loader: Neoforge 21.1.92
Packed Up: 1.0.30+c
PMMO: 2.6.18

Description of the Bug
Normally I can expand the curios slots (i.e. for backpacks) with a small grey button in the player inventory.
After installing "packed up" and "Project-MMO", this is no longer possible.
Pressing the button then removes the PMMO button, but no longer shows (epxands) the curios slots.
(Removing the PMMO button is expected as per discussion with the PMMO author).

Together with the PMMO author I tested this with another backpack mod (sophisticated backpacks) which behaves as expected. Therefore I suspect that there is some kind of incompatibility either directly with PMMO or in the way "packed up" treats curios slots in general.

Steps to Reproduce

  • Install neoforge and a curios API. I'm using "Curios API Continuation"
  • Install "Packed Up" in its latest version available for my minecraft version.
  • Check that the backpack slot is available as expected
  • install pmmo
  • find that the backpack slot is no longer available

Screenshots
pmmo-issue-pic1
This is the button I'm talking about.

Misc
Yes I could change to antoher backpack mod but I don't want to ;) I like packed up especially becaus of it's simplicity which is a perfect fit for my modpack.

This is the issue I raised with the PMMO author:
Caltinor/Project-MMO-2.0#633

regards,
Chipmonk

commented

I don't control anything about the Curios slots. All Packed Up does is add the backpacks to the tag for the back slot https://github.com/SuperMartijn642/PackedUp/blob/neoforge-1.21/src/generated/resources/data/curios/tags/item/back.json
and tell Curios that there should be at least 1 back slot

InterModComms.sendTo("curios", SlotTypeMessage.REGISTER_TYPE, () -> new SlotTypeMessage.Builder("back").size(1).build());

This is the button I'm talking about.

I am confused about what the actual issue is. Is the issue that 'back' slot is missing from the Curios menu when ProjectMMO is installed? Is the issue that the button to open the Curios menu disappears when ProjectMMO is installed? Or is there some specific backpack slot that disappears when ProjectMMO is installed?

commented

I did some as testing and, both with and without ProjectMMO installed, there seem to be no Curios slots. So it seems this has nothing to do with ProjectMMO.

commented

Hi

Thanks for looking into this.
My issue is that the button I marked in my screenshot is not showing the curios slots.
Don't know how to explain it better.

https://github.com/user-attachments/assets/2282f86c-2988-4467-a718-b3d1545174cd
Maybe this helps. Should be a short Video illustrating my issue. If its not loading, I'll find another way to make it available.

I'm not sure where this comes from but as pmmo and packed up are the only mods I'm using which do have curios support, I'm trying to find the cause here (and with the pmmo author). I understand now that seemingly packed up has no "specialities" in this regard but still would like to try to find out where this comes from.

Edit: I accidently closed it, this was not intended :-(

with kind regards,
Chipmonk

commented

It seems to just be an issue with Packed Up I think.
I believe what happened is the following: Packed Up uses an API from Curios to request 1 back slot. That API was marked as deprecated in 1.20.1/1.20.4/1.20.6, but still worked fine. Then Curios stopped updating, so there was no version for 1.21. With the Packed Up update for 1.21, I simply kept the Curios compatibility as with 1.20.6 as there was no Curios version.
Then when Curios API Continuation updated Curios to 1.21, they removed the deprecated API. This means the request for 1 back slot is now ignored.

commented

Ah, that makes sense.
Is this a small fix / will it be fixed at some point?
And can I help somehow?

regards,
Chipmonk

commented

I have fixed the Curios integration now in Packed Up 1.1.0.
Thank you for reporting the issue!

commented

And thank you in turn for fixing.
Tested and working.

regards,
Chipmonk