Conflict between "When Dungeons Arise" and Packet Fixer
Sleatz opened this issue · 9 comments
Whenever Packet Fixer is installed within the mod "When Dungeons Arise" big structures like Keep Kayra doesn't appear. But whenever you use the /locate command, it gives you the location of where the structure should be but when you go to the coordinates, the structure is nowhere to be found. Works properly when Packet Fixer mod is removed.
Edit: Push to mclogs: https://mclo.gs/L5zGBQD
I am also having this issue, specifically with the Keep Kayra and Infested Temple structures from WDA with the newest version of Packet Fixer.
1.21.1
…________________________________
From: TonimatasDEV ***@***.***>
Sent: Friday, February 7, 2025 8:27 AM
To: TonimatasDEV/PacketFixer ***@***.***>
Cc: itsdinkd ***@***.***>; Mention ***@***.***>
Subject: Re: [TonimatasDEV/PacketFixer] Conflict between "When Dungeons Arise" and Packet Fixer (Issue #57)
@Sleatz<https://github.com/Sleatz> @Shahubk<https://github.com/Shahubk> @itsdinkd<https://github.com/itsdinkd>
What versions of Minecraft and Packet Fixer are you using?
—
Reply to this email directly, view it on GitHub<#57 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AIL5CKAYND6ZF6AWRPJBXZL2OTNHDAVCNFSM6AAAAABWK2O5RKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMNBTGQYDGMJXGE>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
Just sussed out the same conflict, first in Craftoria since it updated to latest PacketFixer, then with a bare-bones test case of NF 1.21.1 with only Dungeon's Arise and PacketFixer in it.
PacketFixer v1.4.2: no problem
PacketFixer v.1.4.3: no bueno on Keep Kayra.
I did not test more Dungeon's Arise structures, past the Coliseum and Aviary, which work fine with either PF version.
Log error for PF 1.4.3 and using /place to get a Dungeon's Arise's Keep Kayra follows. Note, the trailing reports of success are false; no structure at all is placed.
[18:02:01] [Server thread/ERROR] [minecraft/StructureTemplateManager]: Couldn't load structure dungeons_arise:keep_kayra/keep_kayra_main_0
net.minecraft.nbt.NbtAccounterException: Tried to read NBT tag that was too big; tried to allocate: 209715189 + 12 bytes where max allowed: 209715200
at TRANSFORMER/[email protected]/net.minecraft.nbt.NbtAccounter.accountBytes(NbtAccounter.java:31) ~[client-1.21.1-20240808.144430-srg.jar%23182!/:?] {re:mixin,re:classloading,pl:mixin:A}
at TRANSFORMER/[email protected]/net.minecraft.nbt.IntTag$1.readAccounted(IntTag.java:39) ~[client-1.21.1-20240808.144430-srg.jar%23182!/:?] {re:classloading}
at TRANSFORMER/[email protected]/net.minecraft.nbt.IntTag$1.load(IntTag.java:30) ~[client-1.21.1-20240808.144430-srg.jar%23182!/:?] {re:classloading}
at TRANSFORMER/[email protected]/net.minecraft.nbt.IntTag$1.load(IntTag.java:27) ~[client-1.21.1-20240808.144430-srg.jar%23182!/:?] {re:classloading}
at TRANSFORMER/[email protected]/net.minecraft.nbt.ListTag$1.loadList(ListTag.java:48) ~[client-1.21.1-20240808.144430-srg.jar%23182!/:?] {re:classloading}
at TRANSFORMER/[email protected]/net.minecraft.nbt.ListTag$1.load(ListTag.java:31) ~[client-1.21.1-20240808.144430-srg.jar%23182!/:?] {re:classloading}
at TRANSFORMER/[email protected]/net.minecraft.nbt.ListTag$1.load(ListTag.java:26) ~[client-1.21.1-20240808.144430-srg.jar%23182!/:?] {re:classloading}
at TRANSFORMER/[email protected]/net.minecraft.nbt.CompoundTag.readNamedTagData(CompoundTag.java:513) ~[client-1.21.1-20240808.144430-srg.jar%23182!/:?] {re:classloading}
at TRANSFORMER/[email protected]/net.minecraft.nbt.CompoundTag$1.loadCompound(CompoundTag.java:62) ~[client-1.21.1-20240808.144430-srg.jar%23182!/:?] {re:classloading}
at TRANSFORMER/[email protected]/net.minecraft.nbt.CompoundTag$1.load(CompoundTag.java:41) ~[client-1.21.1-20240808.144430-srg.jar%23182!/:?] {re:classloading}
at TRANSFORMER/[email protected]/net.minecraft.nbt.CompoundTag$1.load(CompoundTag.java:35) ~[client-1.21.1-20240808.144430-srg.jar%23182!/:?] {re:classloading}
at TRANSFORMER/[email protected]/net.minecraft.nbt.ListTag$1.loadList(ListTag.java:48) ~[client-1.21.1-20240808.144430-srg.jar%23182!/:?] {re:classloading}
at TRANSFORMER/[email protected]/net.minecraft.nbt.ListTag$1.load(ListTag.java:31) ~[client-1.21.1-20240808.144430-srg.jar%23182!/:?] {re:classloading}
at TRANSFORMER/[email protected]/net.minecraft.nbt.ListTag$1.load(ListTag.java:26) ~[client-1.21.1-20240808.144430-srg.jar%23182!/:?] {re:classloading}
at TRANSFORMER/[email protected]/net.minecraft.nbt.CompoundTag.readNamedTagData(CompoundTag.java:513) ~[client-1.21.1-20240808.144430-srg.jar%23182!/:?] {re:classloading}
at TRANSFORMER/[email protected]/net.minecraft.nbt.CompoundTag$1.loadCompound(CompoundTag.java:62) ~[client-1.21.1-20240808.144430-srg.jar%23182!/:?] {re:classloading}
at TRANSFORMER/[email protected]/net.minecraft.nbt.CompoundTag$1.load(CompoundTag.java:41) ~[client-1.21.1-20240808.144430-srg.jar%23182!/:?] {re:classloading}
at TRANSFORMER/[email protected]/net.minecraft.nbt.CompoundTag$1.load(CompoundTag.java:35) ~[client-1.21.1-20240808.144430-srg.jar%23182!/:?] {re:classloading}
at TRANSFORMER/[email protected]/net.minecraft.nbt.NbtIo.readTagSafe(NbtIo.java:193) ~[client-1.21.1-20240808.144430-srg.jar%23182!/:?] {re:classloading}
at TRANSFORMER/[email protected]/net.minecraft.nbt.NbtIo.readUnnamedTag(NbtIo.java:187) ~[client-1.21.1-20240808.144430-srg.jar%23182!/:?] {re:classloading}
at TRANSFORMER/[email protected]/net.minecraft.nbt.NbtIo.read(NbtIo.java:121) ~[client-1.21.1-20240808.144430-srg.jar%23182!/:?] {re:classloading}
at TRANSFORMER/[email protected]/net.minecraft.nbt.NbtIo.readCompressed(NbtIo.java:53) ~[client-1.21.1-20240808.144430-srg.jar%23182!/:?] {re:classloading}
at TRANSFORMER/[email protected]/net.minecraft.world.level.levelgen.structure.templatesystem.StructureTemplateManager.readStructure(StructureTemplateManager.java:242) ~[client-1.21.1-20240808.144430-srg.jar%23182!/:?] {re:classloading}
at TRANSFORMER/[email protected]/net.minecraft.world.level.levelgen.structure.templatesystem.StructureTemplateManager.load(StructureTemplateManager.java:232) ~[client-1.21.1-20240808.144430-srg.jar%23182!/:?] {re:classloading}
at TRANSFORMER/[email protected]/net.minecraft.world.level.levelgen.structure.templatesystem.StructureTemplateManager.loadFromResource(StructureTemplateManager.java:136) ~[client-1.21.1-20240808.144430-srg.jar%23182!/:?] {re:classloading}
at TRANSFORMER/[email protected]/net.minecraft.world.level.levelgen.structure.templatesystem.StructureTemplateManager.tryLoad(StructureTemplateManager.java:114) ~[client-1.21.1-20240808.144430-srg.jar%23182!/:?] {re:classloading}
at java.base/java.util.concurrent.ConcurrentHashMap.computeIfAbsent(ConcurrentHashMap.java:1740) ~[?:?] {}
at TRANSFORMER/[email protected]/net.minecraft.world.level.levelgen.structure.templatesystem.StructureTemplateManager.get(StructureTemplateManager.java:104) ~[client-1.21.1-20240808.144430-srg.jar%23182!/:?] {re:classloading}
at TRANSFORMER/[email protected]/net.minecraft.world.level.levelgen.structure.templatesystem.StructureTemplateManager.getOrCreate(StructureTemplateManager.java:92) ~[client-1.21.1-20240808.144430-srg.jar%23182!/:?] {re:classloading}
at MC-BOOTSTRAP/[email protected]/com.mojang.datafixers.util.Either$Left.map(Either.java:38) ~[datafixerupper-8.0.16.jar%23122!/:?] {}
at TRANSFORMER/[email protected]/net.minecraft.world.level.levelgen.structure.pools.SinglePoolElement.getTemplate(SinglePoolElement.java:94) ~[client-1.21.1-20240808.144430-srg.jar%23182!/:?] {re:classloading}
at TRANSFORMER/[email protected]/net.minecraft.world.level.levelgen.structure.pools.SinglePoolElement.getBoundingBox(SinglePoolElement.java:134) ~[client-1.21.1-20240808.144430-srg.jar%23182!/:?] {re:classloading}
at TRANSFORMER/[email protected]/net.aurelj.dungeons_arise.structures.ModifiedJigsawPlacement.addPieces(ModifiedJigsawPlacement.java:87) ~[DungeonsArise-1.21.x-2.1.64-release.jar%23184!/:?] {re:classloading}
at TRANSFORMER/[email protected]/net.aurelj.dungeons_arise.structures.WDAGenericStructures.findGenerationPoint(WDAGenericStructures.java:129) ~[DungeonsArise-1.21.x-2.1.64-release.jar%23184!/:?] {re:classloading}
at TRANSFORMER/[email protected]/net.minecraft.world.level.levelgen.structure.Structure.findValidGenerationPoint(Structure.java:197) ~[client-1.21.1-20240808.144430-srg.jar%23182!/:?] {re:classloading,xf:fml:default}
at TRANSFORMER/[email protected]/net.minecraft.world.level.levelgen.structure.Structure.generate(Structure.java:96) ~[client-1.21.1-20240808.144430-srg.jar%23182!/:?] {re:classloading,xf:fml:default}
at TRANSFORMER/[email protected]/net.minecraft.server.commands.PlaceCommand.placeStructure(PlaceCommand.java:177) ~[client-1.21.1-20240808.144430-srg.jar%23182!/:?] {re:classloading}
at TRANSFORMER/[email protected]/net.minecraft.server.commands.PlaceCommand.lambda$register$7(PlaceCommand.java:107) ~[client-1.21.1-20240808.144430-srg.jar%23182!/:?] {re:classloading}
at MC-BOOTSTRAP/[email protected]/com.mojang.brigadier.context.ContextChain.runExecutable(ContextChain.java:73) ~[brigadier-1.3.10.jar%23121!/:?] {}
at TRANSFORMER/[email protected]/net.minecraft.commands.execution.tasks.ExecuteCommand.execute(ExecuteCommand.java:29) ~[client-1.21.1-20240808.144430-srg.jar%23182!/:?] {re:classloading}
at TRANSFORMER/[email protected]/net.minecraft.commands.execution.tasks.ExecuteCommand.execute(ExecuteCommand.java:13) ~[client-1.21.1-20240808.144430-srg.jar%23182!/:?] {re:classloading}
at TRANSFORMER/[email protected]/net.minecraft.commands.execution.UnboundEntryAction.lambda$bind$0(UnboundEntryAction.java:8) ~[client-1.21.1-20240808.144430-srg.jar%23182!/:?] {re:classloading}
at TRANSFORMER/[email protected]/net.minecraft.commands.execution.CommandQueueEntry.execute(CommandQueueEntry.java:8) ~[client-1.21.1-20240808.144430-srg.jar%23182!/:?] {re:classloading}
at TRANSFORMER/[email protected]/net.minecraft.commands.execution.ExecutionContext.runCommandQueue(ExecutionContext.java:107) ~[client-1.21.1-20240808.144430-srg.jar%23182!/:?] {re:classloading}
at TRANSFORMER/[email protected]/net.minecraft.commands.Commands.executeCommandInContext(Commands.java:363) ~[client-1.21.1-20240808.144430-srg.jar%23182!/:?] {re:classloading}
at TRANSFORMER/[email protected]/net.minecraft.commands.Commands.performCommand(Commands.java:284) ~[client-1.21.1-20240808.144430-srg.jar%23182!/:?] {re:classloading}
at TRANSFORMER/[email protected]/net.minecraft.server.network.ServerGamePacketListenerImpl.performUnsignedChatCommand(ServerGamePacketListenerImpl.java:1282) ~[client-1.21.1-20240808.144430-srg.jar%23182!/:?] {re:classloading}
at TRANSFORMER/[email protected]/net.minecraft.server.network.ServerGamePacketListenerImpl.lambda$handleChatCommand$7(ServerGamePacketListenerImpl.java:1269) ~[client-1.21.1-20240808.144430-srg.jar%23182!/:?] {re:classloading}
at TRANSFORMER/[email protected]/net.minecraft.server.TickTask.run(TickTask.java:18) ~[client-1.21.1-20240808.144430-srg.jar%23182!/:?] {re:classloading}
at TRANSFORMER/[email protected]/net.minecraft.util.thread.BlockableEventLoop.doRunTask(BlockableEventLoop.java:148) ~[client-1.21.1-20240808.144430-srg.jar%23182!/:?] {re:classloading,pl:accesstransformer:B}
at TRANSFORMER/[email protected]/net.minecraft.util.thread.ReentrantBlockableEventLoop.doRunTask(ReentrantBlockableEventLoop.java:23) ~[client-1.21.1-20240808.144430-srg.jar%23182!/:?] {re:classloading}
at TRANSFORMER/[email protected]/net.minecraft.server.MinecraftServer.doRunTask(MinecraftServer.java:872) ~[client-1.21.1-20240808.144430-srg.jar%23182!/:?] {re:classloading,pl:accesstransformer:B}
at TRANSFORMER/[email protected]/net.minecraft.server.MinecraftServer.doRunTask(MinecraftServer.java:170) ~[client-1.21.1-20240808.144430-srg.jar%23182!/:?] {re:classloading,pl:accesstransformer:B}
at TRANSFORMER/[email protected]/net.minecraft.util.thread.BlockableEventLoop.pollTask(BlockableEventLoop.java:122) ~[client-1.21.1-20240808.144430-srg.jar%23182!/:?] {re:classloading,pl:accesstransformer:B}
at TRANSFORMER/[email protected]/net.minecraft.server.MinecraftServer.pollTaskInternal(MinecraftServer.java:855) ~[client-1.21.1-20240808.144430-srg.jar%23182!/:?] {re:classloading,pl:accesstransformer:B}
at TRANSFORMER/[email protected]/net.minecraft.server.MinecraftServer.pollTask(MinecraftServer.java:849) ~[client-1.21.1-20240808.144430-srg.jar%23182!/:?] {re:classloading,pl:accesstransformer:B}
at TRANSFORMER/[email protected]/net.minecraft.util.thread.BlockableEventLoop.managedBlock(BlockableEventLoop.java:132) ~[client-1.21.1-20240808.144430-srg.jar%23182!/:?] {re:classloading,pl:accesstransformer:B}
at TRANSFORMER/[email protected]/net.minecraft.server.MinecraftServer.managedBlock(MinecraftServer.java:821) ~[client-1.21.1-20240808.144430-srg.jar%23182!/:?] {re:classloading,pl:accesstransformer:B}
at TRANSFORMER/[email protected]/net.minecraft.server.MinecraftServer.waitUntilNextTick(MinecraftServer.java:826) ~[client-1.21.1-20240808.144430-srg.jar%23182!/:?] {re:classloading,pl:accesstransformer:B}
at TRANSFORMER/[email protected]/net.minecraft.server.MinecraftServer.runServer(MinecraftServer.java:712) ~[client-1.21.1-20240808.144430-srg.jar%23182!/:?] {re:classloading,pl:accesstransformer:B}
at TRANSFORMER/[email protected]/net.minecraft.server.MinecraftServer.lambda$spin$2(MinecraftServer.java:267) ~[client-1.21.1-20240808.144430-srg.jar%23182!/:?] {re:classloading,pl:accesstransformer:B}
at java.base/java.lang.Thread.run(Thread.java:1583) [?:?] {}
[18:02:01] [Server thread/INFO] [minecraft/MinecraftServer]: [SubordinalBlue: Generated structure "dungeons_arise:keep_kayra" at 0, 92, -4]
[18:02:01] [Render thread/INFO] [minecraft/ChatComponent]: [System] [CHAT] Generated structure "dungeons_arise:keep_kayra" at 0, 92, -4
That 1.4.4 NF version fixes the issue with Keep Kayras, on both my minimal test case world and in latest Craftoria.
Thank you!
@SubordinalBlue @Shahubk @itsdinkd @Sleatz Please try this version. If it works I will upload it to CurseForge and Modrinth.
In this zip folder you have Packet Fixer development fabric and forge version:
packetfixer-neoforge-1.4.4-1.21-to-1.21.3.zip