Packet Fixer

Packet Fixer

35M Downloads

1.12.2, VM PacketSize limit

samuelask opened this issue ยท 3 comments

commented

Image

Getting this error after the new PacketFixer update for 1.12.2

Caused by getPacketSize() in config.java

It tries to set the max packet value, and then ends up crashing.

A workaround would be to set allSizesUnlimited=false in the config. But then people would probably still get the occasional crash when needing more than the default value 1048576 in packet size. (yes they could just manually increase it in the config but they would most likely not know what is causing the crash)

Im recommending to set a check for a max packet size value inside getPacketSize(). Like 8Mb.

Iv made a pull request to implement this, will link it in the comment.

commented

Commit

#73

commented

If you put manually 8388608 it works?

commented

I tried to manually put a large packet value but it still did not work.

Only when i changed allSizesUnlimited from true to false did it work.

I think when it is set to true it tries to set the value too large for Java. Thus making it crash.