Paladins & Priests (RPG Series)

Paladins & Priests (RPG Series)

9M Downloads

[1.20.1] Shields do not lose durability when used.

FindingTheLost opened this issue ยท 9 comments

commented

Hi,
Could you possibly update 1.20.1 version so that shields can lose durability? Currently they do not. I have seen the ".json" files in the "config" folder and each shield has its' own stats already.

To reproduce this, simply install "Paladins and Priests" and all of its dependencies in a fresh instance of Minecraft. Then grab a golden kite shield or any kite shield and get hit by something. I have tested with 1.21.1 too and there it works fine.

I am only asking because most of the mods i have installed are still not 1.21.1 compatible to be able to make the jump and having indestructible shields is very distracting and anti-vanilla. I simply cannot remove this mod due to how good it is so i have made this account just for this request.

commented

Hello,
There is no such config option, nor do we plan to expand the featureset of 1.20.1.
I recommend setting the durability values to a very high number.

commented

So durability was yet not a feature in 1.20.1 when it was released?
What did you mean by setting durability values to a very high number? The shields are already invincible and changing these values to higher numbers in the "config/paladins/shields.json" does nothing (ex: i changed durability of the golden kite shield from 168 to 10000 and nothing changed).

commented

This is true, durability is stated in config files, but still the shield has infinite durability
@ZsoltMolnarrr

commented

Apologies I misunderstood the issue.
Thank you for the clarificaiton.

commented

This seems like a potential issue of the Shield API used, as the durability value is passed to the constructor.

var shield = new CustomShieldItem(equipSound, entry.repair, shieldAttributes, new FabricItemSettings().maxDamage(config.durability));

commented

No problem. Is it fixable for 1.20.1?

commented

I'll try to change CustomShielditem and use shielditem instead

commented

@ZsoltMolnarrr add this mod as a requirement
https://modrinth.com/mod/shield-api
It fixes the shield problem

commented

Ohh yeah okay, seems like Paladins includes an old version of this API.

So anyone having this issue just make sure to download the latest version of the Shield API available.

Shield API is actually listed on CurseForge and Modrinth as a required dependency.