Pale Garden generation ignores the `worldgen/biome/has_pale_oak` tag
sm644me opened this issue ยท 5 comments
In the data folder of the mod, there's a tag called worldgen/biome/has_pale_oak, by default containing "minecraft:dark_forest". I thought that this would let me control where the Pale Garden spawns, but it seems like that's incorrect. When I add a new biome to the tag, nothing changes, and when I override this tag to be empty, the Pale Garden still generates. Either this tag is unused or I'm very much misunderstanding what it's supposed to do.
If it's relevant, the reason I'm experimenting with this is because I'm trying to make the Pale Garden generate in the Twilight Forest instead of the Overworld via datapack. I can easily make that first part happen, but disabling the biome's Overworld generation is being surprisingly stubborn. This also raises the concern of Creaking Hearts not functioning outside of the Overworld, but that's a vanilla quirk, not a mod bug, so I'll probably just figure that one out on my own.
Hello! Yeah, that tag was being used to spawn the Pale Oak tree in the Dark forest biome on the first versions of the mod when I didn't had the biome done yet. I'll add the has_pale_oak biome tag back since it can be useful to add compatibility between mods.
About the Creaking Hearts, it currently checks if the world it is in has natural light, I tweaked it a bit to try the compatibility with other dimension types. Oh, and I also included a config to enable/disable the Pale Garden biome Overworld generation.
I'll be releasing a new version this weekend addressing a lot of bug fixes, this version will also include back the has_pale_oak biome tag implementation and the changes in the Creaking Heart so you can do your experiments.
I'll let you know here when its posted!
@sm644me the tag was reimplemented in v1.2.0 of the mod, as well the configs. I hope you can test and use it! I'll close this issue for now!
Thank you so much! These fixes and config options will make this very easy to work with. I really appreciate you taking the time to add them.
Interestingly, Eyeblossoms function as expected in the Twilight Forest (always open regardless of time in the Overworld), but the Creaking still doesn't spawn there. From experimenting with JSON files, it looks like the Creaking checks if a dimension has fixed_time unset, so even if fixed_time is late enough in the day for them to spawn, they refuse to. Should I make another bug report for this?
@sm644me You are welcome! Yes it the heart checks for the fixed_time in the dimension to spawn/despawn the Creakings. I can add another config option to setup this. Please open another issue here explaining more about how you want it to work!