[1.18.2] The glow berries tag is broken

Question

[1.18.2] The glow berries tag is broken

FreeFull opened this issue 3 years ago · 5 comments

FreeFull commented 3 years ago

In the 1.18.2 version of Food Core, under data/forge/tags/items/fruits/glowberries.json, "minecraft:glowberries" gets used as the value for the tag. But, the actual item name in-game is "minecraft:glow_berries". Due to this, the forge:fruits/glowberries and forge:fruits tags don't work, and fruit salad isn't craftable.

itsdinkd · Answer 1 · 2022-05-29T06:15:45.000Z

[28May2022 22:57:07.842] [Worker-Main-3/ERROR] [net.minecraft.tags.TagLoader/]: Couldn't load tag forge:berries/huckleberry as it is missing following references: pamhc2crops:huckleberryitem (from pamhc2foodextended-1.18.2-1.0.0.jar)
[28May2022 22:57:07.842] [Worker-Main-3/ERROR] [net.minecraft.tags.TagLoader/]: Couldn't load tag forge:berries/gooseberry as it is missing following references: pamhc2trees:gooseberryitem (from pamhc2foodextended-1.18.2-1.0.0.jar)
[28May2022 22:57:07.842] [Worker-Main-3/ERROR] [net.minecraft.tags.TagLoader/]: Couldn't load tag forge:berries/strawberry as it is missing following references: pamhc2crops:strawberryitem (from pamhc2foodextended-1.18.2-1.0.0.jar)
[28May2022 22:57:07.842] [Worker-Main-3/ERROR] [net.minecraft.tags.TagLoader/]: Couldn't load tag forge:berries/cranberry as it is missing following references: pamhc2crops:cranberryitem (from pamhc2foodextended-1.18.2-1.0.0.jar)
[28May2022 22:57:07.842] [Worker-Main-3/ERROR] [net.minecraft.tags.TagLoader/]: Couldn't load tag forge:berries/juniperberry as it is missing following references: pamhc2crops:juniperberryitem (from pamhc2foodextended-1.18.2-1.0.0.jar)
[28May2022 22:57:07.842] [Worker-Main-3/ERROR] [net.minecraft.tags.TagLoader/]: Couldn't load tag forge:berries/mulberry as it is missing following references: pamhc2crops:mulberryitem (from pamhc2foodextended-1.18.2-1.0.0.jar)
[28May2022 22:57:07.842] [Worker-Main-3/ERROR] [net.minecraft.tags.TagLoader/]: Couldn't load tag forge:berries/blackberry as it is missing following references: pamhc2crops:blackberryitem (from pamhc2foodextended-1.18.2-1.0.0.jar)
[28May2022 22:57:07.842] [Worker-Main-3/ERROR] [net.minecraft.tags.TagLoader/]: Couldn't load tag forge:berries/elderberry as it is missing following references: pamhc2crops:elderberryitem (from pamhc2foodextended-1.18.2-1.0.0.jar)
[28May2022 22:57:07.842] [Worker-Main-3/ERROR] [net.minecraft.tags.TagLoader/]: Couldn't load tag forge:berries/blueberry as it is missing following references: pamhc2crops:blueberryitem (from pamhc2foodextended-1.18.2-1.0.0.jar)
[28May2022 22:57:07.842] [Worker-Main-3/ERROR] [net.minecraft.tags.TagLoader/]: Couldn't load tag forge:berries/raspberry as it is missing following references: pamhc2crops:raspberryitem (from pamhc2foodextended-1.18.2-1.0.0.jar)
[28May2022 22:57:07.842] [Worker-Main-3/ERROR] [net.minecraft.tags.TagLoader/]: Couldn't load tag forge:berries/candleberry as it is missing following references: pamhc2crops:candleberryitem (from pamhc2foodextended-1.18.2-1.0.0.jar)
[28May2022 22:57:07.842] [Worker-Main-3/ERROR] [net.minecraft.tags.TagLoader/]: Couldn't load tag forge:berries as it is missing following references: #forge:berries/blackberry (from pamhc2foodextended-1.18.2-1.0.0.jar), 
	#forge:berries/blueberry (from pamhc2foodextended-1.18.2-1.0.0.jar), 
	#forge:berries/candleberry (from pamhc2foodextended-1.18.2-1.0.0.jar), 
	#forge:berries/cranberry (from pamhc2foodextended-1.18.2-1.0.0.jar), 
	#forge:berries/elderberry (from pamhc2foodextended-1.18.2-1.0.0.jar), 
	#forge:berries/gooseberry (from pamhc2foodextended-1.18.2-1.0.0.jar), 
	#forge:berries/huckleberry (from pamhc2foodextended-1.18.2-1.0.0.jar), 
	#forge:berries/juniperberry (from pamhc2foodextended-1.18.2-1.0.0.jar), 
	#forge:berries/mulberry (from pamhc2foodextended-1.18.2-1.0.0.jar), 
	#forge:berries/raspberry (from pamhc2foodextended-1.18.2-1.0.0.jar), 
	#forge:berries/strawberry (from pamhc2foodextended-1.18.2-1.0.0.jar)
[28May2022 22:57:07.844] [Worker-Main-3/ERROR] [net.minecraft.tags.TagLoader/]: Couldn't load tag forge:voidsteel_gear as it is missing following references: nourished_end:metal_detector_off (from Enlightened End BB V1.3.jar), 
	nourished_end:metal_detector_on (from Enlightened End BB V1.3.jar)
[28May2022 22:57:07.854] [Worker-Main-3/ERROR] [net.minecraft.tags.TagLoader/]: Couldn't load tag forge:citrusfruits/grapefruit as it is missing following references: pamhc2trees:grapefruititem (from pamhc2foodextended-1.18.2-1.0.0.jar)
[28May2022 22:57:07.862] [Worker-Main-3/ERROR] [net.minecraft.tags.TagLoader/]: Couldn't load tag forge:citrusfruits/lime as it is missing following references: pamhc2trees:limeitem (from pamhc2foodextended-1.18.2-1.0.0.jar)
[28May2022 22:57:07.863] [Worker-Main-3/ERROR] [net.minecraft.tags.TagLoader/]: Couldn't load tag forge:citrusfruits/lemon as it is missing following references: pamhc2trees:lemonitem (from pamhc2foodextended-1.18.2-1.0.0.jar)
[28May2022 22:57:07.863] [Worker-Main-3/ERROR] [net.minecraft.tags.TagLoader/]: Couldn't load tag forge:citrusfruits as it is missing following references: #forge:citrusfruits/grapefruit (from pamhc2foodextended-1.18.2-1.0.0.jar), 
	#forge:citrusfruits/lemon (from pamhc2foodextended-1.18.2-1.0.0.jar), 
	#forge:citrusfruits/lime (from pamhc2foodextended-1.18.2-1.0.0.jar)
[28May2022 22:57:07.876] [Worker-Main-3/ERROR] [net.minecraft.tags.TagLoader/]: Couldn't load tag minecraft:piglin_repellents as it is missing following references: nourished_nether:flint_and_quartz (from NourishedNetherV12.jar)
[28May2022 22:57:07.878] [Worker-Main-3/ERROR] [net.minecraft.tags.TagLoader/]: Couldn't load tag forge:fruits/glowberries as it is missing following references: minecraft:glowberries (from pamhc2foodcore-1.18.2-1.0.1.jar), 
	minecraft:glowberries (from pamhc2foodextended-1.18.2-1.0.0.jar)
[28May2022 22:57:07.879] [Worker-Main-3/ERROR] [net.minecraft.tags.TagLoader/]: Couldn't load tag forge:fruits as it is missing following references: #forge:fruits/glowberries (from pamhc2foodcore-1.18.2-1.0.1.jar), 
	#forge:fruits/glowberries (from pamhc2foodextended-1.18.2-1.0.0.jar)
	```

itsdinkd · Answer 2 · 2022-05-29T07:30:50.000Z

and because it breaks the tag, tons of items that are using these berry tags from pam's recipes are broken.

Weedoof · Answer 3 · 2022-06-16T02:58:31.000Z

@itsdinkd 's tag problems aren't actually related to the glow berries issue. Similar effects, different cause.

Glow berries cause the forge:fruits and forge:fruits/glowberries tag specifically to be broken. The others are unaffected.

The other tags are broken because they're looking for other fruits and berries. Those other fruits and berries aren't present in 1.18 yet because crops and trees hasn't been ported. You can't reasonably expect huckleberries to have a functional tag when you're missing the mod that adds huckleberries.

I did upload a datapack that fixes these issues on pam's discord server, though. It just adds vanilla fruits to each of the empty tags so the recipes can still work. The one problem is that the forge:fruits tag only accepts vanilla fruits, even with other mods installed, because of the initial issue that glow berries have a typo in their tag.

onenok · Answer 4 · 2022-09-20T12:36:41.000Z

u can fix it yourself if not use it in a file uneditable server
change it from "pamhc2foodcore-1.18.x-x.x.x.jar" to "pamhc2foodcore-1.18.x-x.x.x.zip"
then unzip it and open it
after that open data\forge\tags\items\fruits\glowberries.json
and change it from

{
  "replace": false,
  "values": [
    "minecraft:glowberries"
  ]
}

to

{
  "replace": false,
  "values": [
    "minecraft:glow_berries"
  ]
}

and zipped it
and .jar it
and done

Weedoof · Answer 5 · 2022-09-21T00:52:33.000Z

Editing the jar file directly is never a good idea. Like, anything you can edit by doing that would be better left to a data pack or resource pack.
In any case though, this bug's been fixed in the latest version of harvestcraft. Just update and you won't need to worry about it.

Share to