Pam's HarvestCraft

Pam's HarvestCraft

87M Downloads

[1.12.2] Infinite Queen Bees

AjaxVM opened this issue ยท 4 comments

commented

I am not sure which mod is causing this, but in my modpack the apiary is causing the bee to take one damage on insertion, but it then is taking two damage before trying to produce anything, causing it to go to negative durability, instead of 0 - which just keeps going down and producing forever.

If I can find what is causing this I can try to fix it myself - but in case there might be other things that can cause - I think a simple code change (which I can submit a PR for if that is helpful) would be to "TileEntityApiary.java:147" to make a gte comparison instead of simple equality.

If you want to look at what I have setup right now - I will be referencing this issue on my github.

commented

If you think you can do a PR to fix the issue, please do so. That would help.

commented

My server has this issue as well, running Forge 1.12.2-14.23.2.2611 with Harvestcraft 1.12.2t. We have a sizeable collection of other mods, and this may be the result of an obscure conflict; I have not throughly tested this because I have been playing exclusively on a server, but I can do so over the weekend if one thinks it would help.

I will note, however, that this issue seemingly affects traps as well; when bait is inserted into the trap, the first piece disappears immediately without any return.

commented

So I was in a hurry to see if I had my pipes hooked up right to automate the apiary for honey. I used a acceleration wand from not enough wands to speed up the apiary and got a queen bee with -3/38 durability, I left this bee in running for a while and it's now at -336/38, with no sign of death. Perhap checking the bees durability as <=0 would be a good idea. Now i'm going to leave the bee in there running as see what happen when it hit max size of a integer (guessing a nasty server crash xD). This was done in the Direwolf20 1.12 modpack, pam's harvestcraft version 1.12a (1.12.2p)

Bee: http://prntscr.com/j2li34
Piping: http://prntscr.com/j2li7y

commented

My pull does check if bee damage goes over max - I imagine a similar fix might work for the traps (anything else with similar mechanic? I can go through next weekend and try to get a pull for all of the related things at once).

Let me know how I can help.