Pam's HarvestCraft

Pam's HarvestCraft

87M Downloads

market spawn eggs are bugged

MavDarkness opened this issue · 17 comments

commented

were on a multiplayer server, market eggs are bugged in that they give either blank eggs or eggs that when we try to use them they dont give any animal, eggs still remains in hand.

commented

I also have that problem on FTB Revelation v1.8.0 Pam's ver 1.12a

commented
commented

What config file must you accept? I've been seeing this bug for months now. It's in all the major packs. so the if there is a fix that a pack maker must make, word of it is not getting out.

commented
  1. In FTB config file you must accept harvestcraft. If you have FTB.

  2. Than you need to use complete quest to get spawn egg. you can't simply buy from market.

  3. Though those eggs do work on occasion (probably a bug)... they were not meant for you to bypass the
    quest itself. Rather than remove the market entirely the spawn eggs were disabled by the pack author.

commented

I'm not playing FTB Revelation v1.8.0. I'm fairly certain that the OP of this bug report was not either.

I have been seeing this spawn egg bug in different packs for months. It's been in major FTB packs and small custom packs and everything in between.

I still have no idea what FTB config file you're talking about.


Now for the proper update to the bug report for this;

I'm seeing this bug in Harvestcraft 1.12.2t

I'm playing a custom pack called "Magic Time Sink"

I'm able to buy working spawn eggs in single player but not in multiplayer.

This is reproducible.

commented
commented

@LightsDawn
Need to use complete quest to get spawn egg. you can't simply buy from market.
Though those eggs do work on occasion (probably a bug)... they were not meant for you to bypass the
quest itself. Rather than remove the market entirely the spawn eggs were disabled by the pack author.

commented

@The-Mad-Cat this is an official pack. Please wait I'll looking for.

commented

This Github is not for whatever pack you have. this one is for reporting issues with the Harvestcraft mod itself.

Thus the confusion when you say to complete a quest because the mod itself has no quests and in fact does have a bug with multiplayer.

commented

@Chaogomu post the latest log.

commented

@The-Mad-Cat
start the launcher and uploade the log to pastebin.com

commented

Post was made because ive had this issue on every multiplayer pack ive played this year. Issue still exists.

commented

@LightsDawn
than post the crash report or latest log, too. Please pastbin.com and link here.

commented

If there was something noticable on my end client side I would have posted it. This issue is server side so I dont have access to it.

commented

@LightsDawn
Ok. than ask the Admin of the Server. I see the problem is, but I can not see what is the fakt.
Data are missing to see the problem.

commented

A problem should be there. As far as I know the method is from older MC versions and ItemMonsterPlacer.applyEntityIdToItemStack should only be for client-side as marked.

final ItemStack pigEgg = new ItemStack(Items.SPAWN_EGG, 1, 90);
final ItemStack sheepEgg = new ItemStack(Items.SPAWN_EGG, 1, 91);
final ItemStack cowEgg = new ItemStack(Items.SPAWN_EGG, 1, 92);
final ItemStack chickenEgg = new ItemStack(Items.SPAWN_EGG, 1, 93);
final ItemStack horseEgg = new ItemStack(Items.SPAWN_EGG, 1, 100);
final ItemStack llamaEgg = new ItemStack(Items.SPAWN_EGG, 1, 103);
final ItemStack ocelotEgg = new ItemStack(Items.SPAWN_EGG, 1, 98);
final ItemStack wolfEgg = new ItemStack(Items.SPAWN_EGG, 1, 95);
final ItemStack rabbitEgg = new ItemStack(Items.SPAWN_EGG, 1, 101);
if(FMLCommonHandler.instance().getEffectiveSide().isClient()) {
ItemMonsterPlacer.applyEntityIdToItemStack(pigEgg, new ResourceLocation("minecraft", "pig"));
ItemMonsterPlacer.applyEntityIdToItemStack(sheepEgg, new ResourceLocation("minecraft", "sheep"));
ItemMonsterPlacer.applyEntityIdToItemStack(cowEgg, new ResourceLocation("minecraft", "cow"));
ItemMonsterPlacer.applyEntityIdToItemStack(chickenEgg, new ResourceLocation("minecraft", "chicken"));
ItemMonsterPlacer.applyEntityIdToItemStack(horseEgg, new ResourceLocation("minecraft", "horse"));
ItemMonsterPlacer.applyEntityIdToItemStack(llamaEgg, new ResourceLocation("minecraft", "llama"));
ItemMonsterPlacer.applyEntityIdToItemStack(ocelotEgg, new ResourceLocation("minecraft", "ocelot"));
ItemMonsterPlacer.applyEntityIdToItemStack(wolfEgg, new ResourceLocation("minecraft", "wolf"));
ItemMonsterPlacer.applyEntityIdToItemStack(rabbitEgg, new ResourceLocation("minecraft", "rabbit"));
}

instead, do something like

    private static void registerNBT(ItemStack stack, ResourceLocation entityId) {
        NBTTagCompound nbt = new NBTTagCompound();
        NBTTagCompound nbt1 = new NBTTagCompound();
        nbt1.setString("id", entityId.toString());
        nbt.setTag("EntityTag", nbt1);
        stack.setTagCompound(nbt);
    }

then

    private static void registerAnimalEggs() {
        ItemStack pigEgg = new ItemStack(Items.SPAWN_EGG);
        registerNBT(pigEgg, EntityList.getKey(EntityPig.class));
        .......
    }

will do registering eggs properly on server-side.

commented

Bumping, I see this on 1.12.2u (buying a cow spawn egg yields a blank spawn egg that has no effects). Added manually to Minecraft (.jar -> mods/) rather than through a mod pack.

I am running this server on my own metal, so I can provide logs if needed. Otherwise consider this my +1