Pam's HarvestCraft

Latest forge, latest BoP and latest harvestcraft

This is still an issue

Versions

Pam's HarvestCraft 1.12.2zb
Forge1.12-2.14.23.5.2781
BiomesOPlenty-1.12.2-7.0.1.2424-universal

All recommend to implement a check for oredict entries such as "dirt" and "grass".

This appears to be the method that needs fixing:

harvestcraft/src/main/java/com/pam/harvestcraft/blocks/growables/BlockPamSapling.java

Lines 110 to 112 in 2913b28

    
           private boolean isSuitableSoilBlock(Block soilBlock) { 
        
               return soilBlock == Blocks.GRASS || soilBlock == Blocks.DIRT || soilBlock == Blocks.FARMLAND; 
        
           }

And this location should probably be fixed simultaneously, if it is similarly broken (not sure if BoP grass/dirt is a subclass of BlockGrass/BlockDirt or not -- this is ground traps checking for whether they are surrounded by dirt or grass)

harvestcraft/src/main/java/com/pam/harvestcraft/tileentities/TileEntityGroundTrap.java

Lines 130 to 132 in 2913b28

    
           if(blockAtCoords instanceof BlockDirt || blockAtCoords instanceof BlockGrass) { 
        
           	count++; 
        
           }

EDIT: I tested, the ground trap does detect BoP grass as valid grass. So this second thing is not an issue.

The second check for the GroundTrap is way better because BOP extends the grass and dirt block of minecraft

Do not use "latest". Post the version you used. If someone will read this later, the version cannot be reconstructed.

	private boolean isSuitableSoilBlock(Block soilBlock) {
	return soilBlock == Blocks.GRASS \|\| soilBlock == Blocks.DIRT \|\| soilBlock == Blocks.FARMLAND;
	}

	if(blockAtCoords instanceof BlockDirt \|\| blockAtCoords instanceof BlockGrass) {
	count++;
	}

Share to

Versions