Pam's HarvestCraft

Pam's HarvestCraft

Mods
87M Downloads

Doesn't this cause the unnecessary processing every single time onInteraction is called?

coderepo8593 opened this issue ยท 0 comments

commented

harvestcraft/src/main/java/com/pam/harvestcraft/events/AnimalBreedingEvent.java

Line 24 in 8f0a903

Set<Item> breedItems = OreDictionary.getOres("listAllgrain").stream().map(ItemStack::getItem).collect(Collectors.toSet());

If I understand how subscribing this event works, isn't this going to cause the OreDictionary to be loaded and this list created every single time onInteraction is called? Wouldn't you want to put something like this in handleBreedItem or one of the conditional statements so that it doesn't happen every single time?