Pam's HarvestCraft

Pam's HarvestCraft

Mods
87M Downloads

[1.12.1c] BlockPamFruit, and probably others too, should implement the new getDrops method

faceofcat opened this issue ยท 1 comments

commented

Currently BlockPamFruit only implements:

    /**
     * @deprecated use {@link #getDrops(NonNullList, IBlockAccess, BlockPos, IBlockState, int)}
     */
    @Deprecated
    public List<ItemStack> getDrops(IBlockAccess world, BlockPos pos, IBlockState state, int fortune)

it should also implement the new:

    /**
     * This gets a complete list of items dropped from this block.
     *
     * @param drops add all items this block drops to this drops list
     * @param world The current world
     * @param pos Block position in world
     * @param state Current state
     * @param fortune Breakers fortune level
     */
    public void getDrops(NonNullList<ItemStack> drops, IBlockAccess world, BlockPos pos, IBlockState state, int fortune)

I was using the new method in a harvester machine and was getting some weird items with missing textures... while using the deprecated method I get the correct fruits.

commented

This would be very helpful. I'll look into fixing this at some point.