Panda's Falling Tree's

Panda's Falling Tree's

2M Downloads

[BUG] Compatability with HT's TreeChop

Camawama opened this issue · 22 comments

commented

HT's TreeChop makes it so the player can slowly chop a tree until it breaks. Your mod makes the tree fall after breaking.

Having the two work together would be one step closer to a realistic tree chopping mechanic and I would love to see it work!

I want to slowly chop the bottom of a tree and then (at a certain point) have the tree fall over. 😄

Currently, with both installed, it only has your mechanics and ignores HT's TreeChop.

commented

Support for HT's TreeChop has officially been added, the released can only be downloaded on CurseForge and Github, Modrinth will be released at a later time.

commented

WooHoo!!!

commented

Now we just need compatibility with MultiMine mod

commented

I will work on it at some point.

commented

Heya!
When chopping down a tree with HT's Tree Chop, the tree doesn't fall at the point the cut was made, instead it destroys the block above.
this isn't mechanically problematic, it's just visually unappealing - still, is there any way this could be fixed?

2024-03-21.14-34-09.mp4

I'm using the latest versions of both mods on Neoforge 1.20.1

commented

If interested @PandaDap2006, I think compatibility should be pretty simple by adding a listener to TreeChop's AFTER_CHOP event, checking for felled == true. Then check chopData for the tree's blocks. See https://github.com/hammertater/treechop/blob/main/fabric/src/main/java/ht/treechop/api/TreeChopEvents.java

It's possible TreeChop's chopped_log blocks would have some rendering issues. I'm happy to help, either by extending the API as needed or by sending a pull request.

commented

Thanks @hammertater for letting me know and for offering your assistance with this, i will reach out if there seems to be any issues.

commented

Accidentally closed the issue, sorry.

commented

Hey @hammertater im currently trying to make compatibility with the mod but chopData doesn't have a method or variable for getting the blocks of the tree, it would be great if you could extend the API so it would be possible, you can contact me on discord if you find it necessary, my tag is @ThePandaOliver.

commented

Ahh sorry, I made some extensions to the API but forgot that I haven't released them yet. I'll let ya know when it's ready

commented

Sounds great, thanks.

commented

This is very exciting, can't wait!

commented

anything new? :D i found the mod few minues ago and im allready using treechop^^ i would be really cool, to use both together

commented

@GulliUlli Sadly treechop have not been updated yet.

commented

uuh sounds like progress in that case? :P

commented

It looks like something happened 5 days ago hammertater/treechop#233

commented

Hey folks, sorry for how long it’s taking. I have made the changes but haven’t posted an updated version yet. I’ll try to get it up tomorrow-ish

commented

Sorry for the wait! As of 0.18.5 (only for Minecraft 1.19.2 right now) there's a new a getTree method in the ChopData class. That'll return a TreeData object that has all of the positions for logs. If you need the leaves as well, TreeData's forEachLeaves is faster than streamLeaves, but make sure you read all of the logs first or it might not find all of the leaves. Sorry for the jankiness.

commented

Thanks so much i might take a look at later today.

commented

I see progress 👀

commented

Yep working on it.

commented

Seems like this broke in TreeChop 0.19.2