Paradise Lost

Paradise Lost

7M Downloads

Every fluid collected by skyroot bucket becomes water

Jack-Papel opened this issue ยท 5 comments

commented

Related to #187.
Code snippet containing the error:

In aether/items/tools/SkyrootBucket.java
if (fluid != Fluids.EMPTY) { playerIn.incrementStat(Stats.USED.getOrCreateStat(this)); playerIn.playSound(SoundEvents.ITEM_BUCKET_FILL, 1.0F, 1.0F); ItemStack fillStack = this.fillBucket(currentStack, playerIn, AetherItems.SKYROOT_WATER_BUCKET);

commented

On my end, Github didn't format the code correctly. Basically, this code treats every fluid as if it's water.

commented

I would fix it myself, but I'm not sure what the proper interaction is with lava, dense_aercloud, etc.

commented

It should only be able to pick up water. There is no skyroot lava bucket (because wood), and the dense aercloud is supposed to be picked up by whatever vial thing azzy made, but don't worry about that for now

commented

Thanks. I'll write up a fix then

commented

Fixed in #201