Paradise Lost

Paradise Lost

7M Downloads

Various mechanics should be delegated to external api

SollyW opened this issue · 8 comments

commented

Various mechanics are implemented in ways that are either a maintainance burden, duplicate effort, or cause imcompatibilities with other mods. These should be changed to use external apis; however, many of these apis currently do not exist.
Feel free to add additional items to the list. Items marked with (*) already have an api in fapi or elsewhere

  • *Enchantment tables with skyroot bookshelves (particle effect, enchantment level increase) (in third-party mod)
  • Skyroot buckets (fluids, milking)
  • Aether farmland (moisture, rabbits, villagers, plantable, etc.)
  • *Block colours
  • *Item colours
  • Glass pane and torch registering
  • Entity model layers
  • Falling leaf particles
  • *Quicksand gamerule network packets (maybe change gamerule to config value?)
  • Item rarity
  • *Fuel times for aether items
  • *Strippable blocks
  • *Shovels flattening aether grass
  • Aether blocks added to isSoil and isStone checks in feature generation
  • *Item groups
  • Simplex noise
commented

Damn you didn't need to murder CDA like that
hmmmm

commented

Well some of these are really bad - the enchantment table and rabbit, for example, will cause a crash if another mods adds their blocks

commented

I believe gudenau has an API for the enchantment table and farmland, among other things we'd desire.

commented

Bookshelves and Aether Farmland ✔️

commented

Fuel, Pane, Torch, Particle ✔️

commented

Color Provs, Item Groups ✔️

commented

Only three to go ✔️

commented

Do we think this is sufficiently complete?