Bug: contains other mods inside the jar
SubBastion opened this issue · 9 comments
What happened?
A bug!
To replicate:
- open jar
- notice copyright infringement yay!
Mod Version
1.6.5 - 1.18
Fabric API Version
No response
Relevant log output
No response
Other mods
No response
Additional Information
No response
I suggest checking out the Cardinal Components GitHub page for adding this mod as a dependency.
As you can see, it suggests and approves of the use of jar-in-jar inclusion - the very thing you are referring to. Jar-in-jar means it adds the mod's jar inside our own, hence the term.
We really do appreciate your concerns, however there is nothing to worry about.
Hey mate, I can see where your confusion stems from. This practice isn't disallowed nor looked down upon. If you look in our mod files on GitHub, we don't contain code for other mods. However, in our build.gradle, we include some library mods that help us with compatibility, among other things. For example, Incubus Core is an in-house mod intended to let all of our projects work together. If you look at the GitHubs of the mods that are included, you'll see that some of them even encourage the practice for ease of compatibility.
However, thanks for reporting anyway. We take copyright very seriously and we certainly don't want to put ourselves in a position where we are unfairly using the work of others.
I see that your report comes from a place of good heart. So thank you. And have fun with the mod, if you wish to!
A few MB isn't going to add up to GB without some tomfoolery. This is standard practice and Fabric is designed with this in mind. The latest version of included mods will be used and we are not overriding any classes. Plus the mods are using open source licenses, allowing this use case.
We haven't had any compatibility issues so far 🤷♀️. We appreciate your concerns, but they don't seem to be based in any actual observable issues.
It doesn't slow it down much and most of the file size comes from assets. I will admit that it makes mods a little larger, but the included mods just don't add too much compared to all of the images and audio files.
SubBastion was blocked for trolling. Anyone viewing this issue in the future should be aware that we value suggestions from our community. But being a brand new account created moments before this issue, as well as being dismissive and stubborn with their responses, we can only ascertain that this account is a troll