
Soft incompatibility with Particle Rain mod (fabric)
djmrFunnyMan opened this issue ยท 4 comments
Having Particle Core installed causes some particle effects from Particle Rain mod to not look correctly.
- The ground fog particle will very noticably disappear and reappear as you walk around. This is most likely due to a particle culling optimization.
In my mind the best way to fix this would be to provide an API via which mods can exclude specific particles from culling.
Demonstration:
- No Particle Core (correct result)
correct.1.mp4
- With Particle Core (incorrect result)
buggy.1.mp4
Twin report in the Particle Rain repo: PigCart/particle-rain#127
I agree with Leclowndu93150 that a whitelist would be needed for Particle Core, something I can look into added for the next update.
@PigCart I don't think there's anything you could do at the moment to fix it from your end. I chose to make particle core both slightly more aggressive and more CPU-efficient with culling by simply checking the midpoint of the particle rather than each corner of the box.
Beyond or in place of a whitelist I might include some option for changing this culling behavior to use the full box, maybe by particle type, maybe just a general switch in case problems are noted. A whitelist would impart some performance impact that I'm not particularly fond of.