Particles Die with Integrated Dynamics Interaction when antempting to cull particle
Shibva opened this issue · 14 comments
[20:42:53] [Particle Culling/INFO]: [java.lang.ThreadGroup:uncaughtException:1052]: java.lang.NullPointerException
[20:42:53] [Particle Culling/INFO]: [java.lang.ThreadGroup:uncaughtException:1052]: at org.cyclops.integrateddynamics.block.collidable.CollidableComponentParts.getPartBoundingBox(CollidableComponentParts.java:33)
[20:42:53] [Particle Culling/INFO]: [java.lang.ThreadGroup:uncaughtException:1052]: at org.cyclops.integrateddynamics.block.collidable.CollidableComponentParts.getBounds(CollidableComponentParts.java:54)
[20:42:53] [Particle Culling/INFO]: [java.lang.ThreadGroup:uncaughtException:1052]: at org.cyclops.integrateddynamics.block.collidable.CollidableComponentParts.getBounds(CollidableComponentParts.java:29)
[20:42:53] [Particle Culling/INFO]: [java.lang.ThreadGroup:uncaughtException:1052]: at org.cyclops.integrateddynamics.core.block.CollidableComponent.doRayTraceComponent(CollidableComponent.java:125)
[20:42:53] [Particle Culling/INFO]: [java.lang.ThreadGroup:uncaughtException:1052]: at org.cyclops.integrateddynamics.core.block.CollidableComponent.doRayTrace(CollidableComponent.java:148)
[20:42:53] [Particle Culling/INFO]: [java.lang.ThreadGroup:uncaughtException:1052]: at org.cyclops.integrateddynamics.core.block.CollidableComponent.collisionRayTrace(CollidableComponent.java:70)
[20:42:53] [Particle Culling/INFO]: [java.lang.ThreadGroup:uncaughtException:1052]: at org.cyclops.integrateddynamics.block.BlockCable.func_180636_a(BlockCable.java:126)
[20:42:53] [Particle Culling/INFO]: [java.lang.ThreadGroup:uncaughtException:1052]: at net.minecraft.block.state.BlockStateContainer$StateImplementation.func_185910_a(BlockStateContainer.java:473)
[20:42:53] [Particle Culling/INFO]: [java.lang.ThreadGroup:uncaughtException:1052]: at bl4ckscor3.mod.particleculling.CullThread.shouldCull(CullThread.java:226)
[20:42:53] [Particle Culling/INFO]: [java.lang.ThreadGroup:uncaughtException:1052]: at bl4ckscor3.mod.particleculling.CullThread.shouldCullParticle(CullThread.java:110)
[20:42:53] [Particle Culling/INFO]: [java.lang.ThreadGroup:uncaughtException:1052]: at bl4ckscor3.mod.particleculling.CullThread.iterateParticles(CullThread.java:83)
[20:42:53] [Particle Culling/INFO]: [java.lang.ThreadGroup:uncaughtException:1052]: at bl4ckscor3.mod.particleculling.CullThread.run(CullThread.java:44)
I played a bit around and couldn't quite figure out a case where this occurs. Reproduction steps would be appreciated! Your Particle Culling config would also be helpful, please.
I'll see what I can do; it might be difficult
If there is a way I can extend my log while reproducing it please let me know
I'll get back when I can
Yeah, I was actually thinking that on the back of my head about saying that; I only said that because I wasn't at my computer at the time to pull up the last release for 12.2; sorry about that give me a moment
Thank you! I will look into this.
Note: While it's unlikely that you are not using the actually latest version of Integrated Dynamics due to it having been released quite a few years back, please never say "latest" when asked for the version number of anything. It is vague and ambiguous, and no one but you can verify whether the actual latest version is the version that you think is latest. Using the proper version number makes sure there is no misunderstanding!
-------------alright
its Integrated Dynamics 1.12.2-1.1.11
https://www.curseforge.com/minecraft/mc-mods/integrated-dynamics/files/3159505
would like to note that their block collisions are a bit odd, if the outline (fencing) is an indicator of that lel
EDIT: I also have Integrated Tunnels for this version as well, just to make that known in case its relivent
to add on, this issue stops if I disable the mod via the clientside toggle option
and while I have confirmed this issue occurs with the normal Minecraft particles, I am also using Fancier Block Particles
https://www.curseforge.com/minecraft/mc-mods/fbp/files/4032588
again, I have confirmed this issue without this present but am adding this just in case for whatever reason it does or makes the issue more likey to happen
also it seems that particles die as well if you have a UI open for too long but I cant 100% confirm this confidently
as for a means of reproducing, please let me know if that's needed; same goes if you need a full game log
You can post the log on https://gist.github.com and post the link here if you want.
I think it will have a higher chance of occurring if you do the following, I haven't tested it but this is close to the situation that has caused the fault so If im correct this should work
-
get
Logic Cableand place them in the shape of a 5x5x5 hollow box, with all of their faces covered as well. -
get a crafting table, any block, and a facade.
-
place the table and open it, put the block you chose and the facade in there; this is needed as the facade on its own cannot be applied; it requires a block crafted with it to use its texture before it can be placable on logic cables
-
right click all the logic cable blocks with the output of step 3 to apply them; for best measure, apply them to all.
-
once that's done, go ahead and break a hole in the center of the top face of your cube
-
this one is going to have to be up to you; the objective here is to have particles occur inside this box. Do whatever you can to create a good amount of particles in here; doesn't matter what as long as these particles are using minecrafts particle system and not an independent one (embers, astral sorcery, etc). The likeyhood of this bug happening increases in theory the more particles are in this hallowed cube. if you spawn enough of them and then obstruct you view by flying away from the small hole and stay nearby the box, it will occur. To make things easier, once your done doing whatever you did to spew out a bunch of particles, go ahead and wait by the side of the box where its obstructed and place something that gives off particles. This is not important but it will easy for you to indicate when the particle engine stops working when (for example; a torch) stops emitting vanilla particles.
-
if nothing happens within five minutes, repeat 1-6 except with a smaller box (3x3x3) or layer up
Thanks a lot! I thought of a possible fix for this, and included it in this updated mod file. It'd be very much appreciated if you could test it out and report back whether the issue still happens for you.