Particular ✨ Reforged

Particular ✨ Reforged

154k Downloads

Cascading Waterfall particle system causing memory leak [1.20.1 and maybe others]

Shibva opened this issue · 8 comments

commented

Image
Before I disabled

Image
After I disabled cascading water particles

Noticed this happening a few days ago when my game starts experiencing OutOfmemory error while leaving the game in the Pause menu

This data is mostly from me leaving the game in pause and trying to deduce the issue.

I have a large waterfall area and I believe it was enough to propagate this issue

Image

Link to Heapdump

https://drive.google.com/file/d/17LUrJQq1sLyYKfBJdPuDAMNQZLIe6jAP/view?usp=drive_link

commented

oh what the fuck i'm absolutely cooked

commented

@Leclowndu93150

Image
Im not liking what I see here; though idk if it's still relevant to a leak. Ill keep an eye on it. If it's still a concern, I suggest clearing it every 2.5 seconds or so instead of 5.

Again, this readout is from being in the pause menu, which I find odd. But I'm new to this with reading out memory stuff.

Ill keep you updated and notify you on this report if the issue persists.

commented

hmm this is concerning. what are you doing to create so many cascades ??

commented

i think a spark report would be more useful as it would show where the mem leak is from

commented

Its just my game is all; this is actually normal for me; its not building up as you can see

Image

Ill keep you updated if I encounter any more bugs

commented

@Leclowndu93150 update: it seems the fix broke the cascades appearing entirely. Can you check on your end

commented

They literally appear wdym

commented

might be another mod im using blocking it via culling