
Add configuration option for additional fluids
Closed this issue · 13 comments
Hello, thank you for your forge port!
Would it be possible to add a configuration option for different fluids that would count as "water"? For example, I contribute to a TerraFirmaCraft-based modpack, which also has river water and ocean water as separate fluids.
Particular works fine on the normal water, but there's no splash/cascade effects on the river water or oceans.
Modded boats also don't have any effects following them. Would it be possible to have this be configurable as well?
Thank you!
Hard compat is needed, shouldn't be much trouble, i'm just burnt out rn and i've got a lot to deal with
No rush! Just thought I'd bring it up, otherwise if you have an idea of where to look I could do a quick mixin in the meantime
copy paste this mixin into your own fluid
idk about this one https://github.com/Leclowndu93150/Particular/blob/master/src/main/java/com/leclowndu93150/particular/mixin/InjectFlowableFluid.java
Hm, I'm not having much luck.
I made a copy of your mixin, with this one change:
if (world.getFluidState(pos.below()).is(TFCTags.Fluids.ANY_WATER))
where that tag contains all the tfc waters. Didn't notice any change though.
I also tried adding the fluids to the #minecraft:water
tag directly, which also didn't work.
ServerEvents.tags('fluid', event => {
event.add('minecraft:water', 'tfc:salt_water')
event.add('minecraft:water', 'tfc:river_water')
event.add('minecraft:water', 'tfc:spring_water')
}
Any other ideas for what I could try?
If you weren't able to get any further than river water, that's ok, that's already a big improvement since that's likely the kind of water people will be splashing about in the most!
splashes work for all waters. just the cascades i only got working for rivers