Excessive client lag when advancement occurs

Question

Excessive client lag when advancement occurs

itsdinkd opened this issue 3 years ago · 13 comments

itsdinkd commented 3 years ago

Mod loader

Forge

Minecraft version

1.18.1

Patchouli version

latest

Modloader version

39.0.5

Modpack info

AQM3

The latest.log file

https://spark.lucko.me/LSeTxTHqa5?hl=51

Issue description

When an achievement occurs, the game freezes client side for a good 3-4 seconds. server is fine while this happens.

As you see in the other information section, that occurs when achievements happen.

Steps to reproduce

No response

Other information

[22:41:03] [Render thread/ERROR]: Error compiling book occultism:dictionary_of_spirits, using empty contents
java.lang.RuntimeException: Error building entry occultism:pentacles/summon_wild_afrit
	at vazkii.patchouli.client.book.BookContentsBuilder.lambda$build$2(BookContentsBuilder.java:88) ~[Patchouli-1.18.1-61.jar%23242!:1.18.1-61]
	at java.util.HashMap$Values.forEach(HashMap.java:1065) ~[?:?]
	at vazkii.patchouli.client.book.BookContentsBuilder.build(BookContentsBuilder.java:84) ~[Patchouli-1.18.1-61.jar%23242!:1.18.1-61]
	at vazkii.patchouli.common.book.Book.reloadContents(Book.java:190) ~[Patchouli-1.18.1-61.jar%23242!:1.18.1-61]
	at vazkii.patchouli.common.book.BookRegistry.reloadContents(BookRegistry.java:164) ~[Patchouli-1.18.1-61.jar%23242!:1.18.1-61]
	at vazkii.patchouli.client.book.ClientBookRegistry.reload(ClientBookRegistry.java:63) ~[Patchouli-1.18.1-61.jar%23242!:1.18.1-61]
	at vazkii.patchouli.client.base.ClientAdvancements.onClientPacket(ClientAdvancements.java:34) ~[Patchouli-1.18.1-61.jar%23242!:1.18.1-61]
	at net.minecraft.client.multiplayer.ClientAdvancements.handler$zie000$patchouli_onSync(ClientAdvancements.java:1017) ~[client-1.18.1-20211210.034407-srg.jar%23323!:?]
	at net.minecraft.client.multiplayer.ClientAdvancements.m_104399_(ClientAdvancements.java:57) ~[client-1.18.1-20211210.034407-srg.jar%23323!:?]
	at net.minecraft.client.multiplayer.ClientPacketListener.m_5498_(ClientPacketListener.java:1127) ~[client-1.18.1-20211210.034407-srg.jar%23323!:?]
	at net.minecraft.network.protocol.game.ClientboundUpdateAdvancementsPacket.m_5797_(ClientboundUpdateAdvancementsPacket.java:51) ~[client-1.18.1-20211210.034407-srg.jar%23323!:?]
	at net.minecraft.network.protocol.game.ClientboundUpdateAdvancementsPacket.m_5797_(ClientboundUpdateAdvancementsPacket.java:16) ~[client-1.18.1-20211210.034407-srg.jar%23323!:?]
	at net.minecraft.network.protocol.PacketUtils.m_131356_(PacketUtils.java:21) ~[client-1.18.1-20211210.034407-srg.jar%23323!:?]
	at net.minecraft.util.thread.BlockableEventLoop.m_6367_(BlockableEventLoop.java:151) ~[client-1.18.1-20211210.034407-srg.jar%23323!:?]
	at net.minecraft.util.thread.ReentrantBlockableEventLoop.m_6367_(ReentrantBlockableEventLoop.java:23) ~[client-1.18.1-20211210.034407-srg.jar%23323!:?]
	at net.minecraft.util.thread.BlockableEventLoop.m_7245_(BlockableEventLoop.java:125) ~[client-1.18.1-20211210.034407-srg.jar%23323!:?]
	at net.minecraft.util.thread.BlockableEventLoop.m_18699_(BlockableEventLoop.java:110) ~[client-1.18.1-20211210.034407-srg.jar%23323!:?]
	at net.minecraft.client.Minecraft.m_91383_(Minecraft.java:1009) ~[client-1.18.1-20211210.034407-srg.jar%23323!:?]
	at net.minecraft.client.Minecraft.m_91374_(Minecraft.java:660) ~[client-1.18.1-20211210.034407-srg.jar%23323!:?]
	at net.minecraft.client.main.Main.main(Main.java:205) ~[client-1.18.1-20211210.034407-srg.jar%23323!:?]
	at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ~[?:?]
	at jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77) ~[?:?]
	at jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) ~[?:?]
	at java.lang.reflect.Method.invoke(Method.java:568) ~[?:?]
	at net.minecraftforge.fml.loading.targets.CommonClientLaunchHandler.lambda$launchService$0(CommonClientLaunchHandler.java:45) ~[fmlloader-1.18.1-39.0.5.jar%2323!:?]
	at cpw.mods.modlauncher.LaunchServiceHandlerDecorator.launch(LaunchServiceHandlerDecorator.java:37) [modlauncher-9.0.7.jar%235!:?]
	at cpw.mods.modlauncher.LaunchServiceHandler.launch(LaunchServiceHandler.java:53) [modlauncher-9.0.7.jar%235!:?]
	at cpw.mods.modlauncher.LaunchServiceHandler.launch(LaunchServiceHandler.java:71) [modlauncher-9.0.7.jar%235!:?]
	at cpw.mods.modlauncher.Launcher.run(Launcher.java:106) [modlauncher-9.0.7.jar%235!:?]
	at cpw.mods.modlauncher.Launcher.main(Launcher.java:77) [modlauncher-9.0.7.jar%235!:?]
	at cpw.mods.modlauncher.BootstrapLaunchConsumer.accept(BootstrapLaunchConsumer.java:26) [modlauncher-9.0.7.jar%235!:?]
	at cpw.mods.modlauncher.BootstrapLaunchConsumer.accept(BootstrapLaunchConsumer.java:23) [modlauncher-9.0.7.jar%235!:?]
	at cpw.mods.bootstraplauncher.BootstrapLauncher.main(BootstrapLauncher.java:90) [bootstraplauncher-0.1.17.jar:?]
Caused by: java.lang.RuntimeException: Error while loading entry occultism:pentacles/summon_wild_afrit page 1
	at vazkii.patchouli.client.book.BookEntry.build(BookEntry.java:224) ~[Patchouli-1.18.1-61.jar%23242!:1.18.1-61]
	at vazkii.patchouli.client.book.BookContentsBuilder.lambda$build$2(BookContentsBuilder.java:86) ~[Patchouli-1.18.1-61.jar%23242!:1.18.1-61]
	... 32 more
Caused by: java.lang.IllegalArgumentException: No multiblock located for occultism:pentacle.summon_wild_afrit
	at vazkii.patchouli.client.book.page.PageMultiblock.build(PageMultiblock.java:76) ~[Patchouli-1.18.1-61.jar%23242!:1.18.1-61]
	at vazkii.patchouli.client.book.BookEntry.build(BookEntry.java:221) ~[Patchouli-1.18.1-61.jar%23242!:1.18.1-61]
	at vazkii.patchouli.client.book.BookContentsBuilder.lambda$build$2(BookContentsBuilder.java:86) ~[Patchouli-1.18.1-61.jar%23242!:1.18.1-61]
	... 32 more
[22:41:03] [Render thread/ERROR]: Error loading book modularrouters:book, using empty contents and ignoring extensions
java.lang.IllegalArgumentException: `category` must be fully qualified (domain:name). Hint: Try `modularrouters:intro`
	at vazkii.patchouli.client.book.BookEntry.initCategory(BookEntry.java:104) ~[Patchouli-1.18.1-61.jar%23242!:1.18.1-61]
	at vazkii.patchouli.client.book.BookContentsBuilder.loadEntry(BookContentsBuilder.java:148) ~[Patchouli-1.18.1-61.jar%23242!:1.18.1-61]
	at vazkii.patchouli.client.book.BookContentsBuilder.lambda$loadFrom$0(BookContentsBuilder.java:70) ~[Patchouli-1.18.1-61.jar%23242!:1.18.1-61]
	at vazkii.patchouli.client.book.BookContentsBuilder.load(BookContentsBuilder.java:112) ~[Patchouli-1.18.1-61.jar%23242!:1.18.1-61]
	at vazkii.patchouli.client.book.BookContentsBuilder.loadFrom(BookContentsBuilder.java:69) ~[Patchouli-1.18.1-61.jar%23242!:1.18.1-61]
	at vazkii.patchouli.common.book.Book.reloadContents(Book.java:175) ~[Patchouli-1.18.1-61.jar%23242!:1.18.1-61]
	at vazkii.patchouli.common.book.BookRegistry.reloadContents(BookRegistry.java:164) ~[Patchouli-1.18.1-61.jar%23242!:1.18.1-61]
	at vazkii.patchouli.client.book.ClientBookRegistry.reload(ClientBookRegistry.java:63) ~[Patchouli-1.18.1-61.jar%23242!:1.18.1-61]
	at vazkii.patchouli.client.base.ClientAdvancements.onClientPacket(ClientAdvancements.java:34) ~[Patchouli-1.18.1-61.jar%23242!:1.18.1-61]
	at net.minecraft.client.multiplayer.ClientAdvancements.handler$zie000$patchouli_onSync(ClientAdvancements.java:1017) ~[client-1.18.1-20211210.034407-srg.jar%23323!:?]
	at net.minecraft.client.multiplayer.ClientAdvancements.m_104399_(ClientAdvancements.java:57) ~[client-1.18.1-20211210.034407-srg.jar%23323!:?]
	at net.minecraft.client.multiplayer.ClientPacketListener.m_5498_(ClientPacketListener.java:1127) ~[client-1.18.1-20211210.034407-srg.jar%23323!:?]
	at net.minecraft.network.protocol.game.ClientboundUpdateAdvancementsPacket.m_5797_(ClientboundUpdateAdvancementsPacket.java:51) ~[client-1.18.1-20211210.034407-srg.jar%23323!:?]
	at net.minecraft.network.protocol.game.ClientboundUpdateAdvancementsPacket.m_5797_(ClientboundUpdateAdvancementsPacket.java:16) ~[client-1.18.1-20211210.034407-srg.jar%23323!:?]
	at net.minecraft.network.protocol.PacketUtils.m_131356_(PacketUtils.java:21) ~[client-1.18.1-20211210.034407-srg.jar%23323!:?]
	at net.minecraft.util.thread.BlockableEventLoop.m_6367_(BlockableEventLoop.java:151) ~[client-1.18.1-20211210.034407-srg.jar%23323!:?]
	at net.minecraft.util.thread.ReentrantBlockableEventLoop.m_6367_(ReentrantBlockableEventLoop.java:23) ~[client-1.18.1-20211210.034407-srg.jar%23323!:?]
	at net.minecraft.util.thread.BlockableEventLoop.m_7245_(BlockableEventLoop.java:125) ~[client-1.18.1-20211210.034407-srg.jar%23323!:?]
	at net.minecraft.util.thread.BlockableEventLoop.m_18699_(BlockableEventLoop.java:110) ~[client-1.18.1-20211210.034407-srg.jar%23323!:?]
	at net.minecraft.client.Minecraft.m_91383_(Minecraft.java:1009) ~[client-1.18.1-20211210.034407-srg.jar%23323!:?]
	at net.minecraft.client.Minecraft.m_91374_(Minecraft.java:660) ~[client-1.18.1-20211210.034407-srg.jar%23323!:?]
	at net.minecraft.client.main.Main.main(Main.java:205) ~[client-1.18.1-20211210.034407-srg.jar%23323!:?]
	at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ~[?:?]
	at jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77) ~[?:?]
	at jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) ~[?:?]
	at java.lang.reflect.Method.invoke(Method.java:568) ~[?:?]
	at net.minecraftforge.fml.loading.targets.CommonClientLaunchHandler.lambda$launchService$0(CommonClientLaunchHandler.java:45) ~[fmlloader-1.18.1-39.0.5.jar%2323!:?]
	at cpw.mods.modlauncher.LaunchServiceHandlerDecorator.launch(LaunchServiceHandlerDecorator.java:37) [modlauncher-9.0.7.jar%235!:?]
	at cpw.mods.modlauncher.LaunchServiceHandler.launch(LaunchServiceHandler.java:53) [modlauncher-9.0.7.jar%235!:?]
	at cpw.mods.modlauncher.LaunchServiceHandler.launch(LaunchServiceHandler.java:71) [modlauncher-9.0.7.jar%235!:?]
	at cpw.mods.modlauncher.Launcher.run(Launcher.java:106) [modlauncher-9.0.7.jar%235!:?]
	at cpw.mods.modlauncher.Launcher.main(Launcher.java:77) [modlauncher-9.0.7.jar%235!:?]
	at cpw.mods.modlauncher.BootstrapLaunchConsumer.accept(BootstrapLaunchConsumer.java:26) [modlauncher-9.0.7.jar%235!:?]
	at cpw.mods.modlauncher.BootstrapLaunchConsumer.accept(BootstrapLaunchConsumer.java:23) [modlauncher-9.0.7.jar%235!:?]
	at cpw.mods.bootstraplauncher.BootstrapLauncher.main(BootstrapLauncher.java:90) [bootstraplauncher-0.1.17.jar:?]
[22:41:03] [Render thread/ERROR]: Error loading book crockpot:book, using empty contents and ignoring extensions
java.lang.IllegalArgumentException: `category` must be fully qualified (domain:name). Hint: Try `crockpot:recipes`
	at vazkii.patchouli.client.book.BookEntry.initCategory(BookEntry.java:104) ~[Patchouli-1.18.1-61.jar%23242!:1.18.1-61]
	at vazkii.patchouli.client.book.BookContentsBuilder.loadEntry(BookContentsBuilder.java:148) ~[Patchouli-1.18.1-61.jar%23242!:1.18.1-61]
	at vazkii.patchouli.client.book.BookContentsBuilder.lambda$loadFrom$0(BookContentsBuilder.java:70) ~[Patchouli-1.18.1-61.jar%23242!:1.18.1-61]
	at vazkii.patchouli.client.book.BookContentsBuilder.load(BookContentsBuilder.java:112) ~[Patchouli-1.18.1-61.jar%23242!:1.18.1-61]
	at vazkii.patchouli.client.book.BookContentsBuilder.loadFrom(BookContentsBuilder.java:69) ~[Patchouli-1.18.1-61.jar%23242!:1.18.1-61]
	at vazkii.patchouli.common.book.Book.reloadContents(Book.java:175) ~[Patchouli-1.18.1-61.jar%23242!:1.18.1-61]
	at vazkii.patchouli.common.book.BookRegistry.reloadContents(BookRegistry.java:164) ~[Patchouli-1.18.1-61.jar%23242!:1.18.1-61]
	at vazkii.patchouli.client.book.ClientBookRegistry.reload(ClientBookRegistry.java:63) ~[Patchouli-1.18.1-61.jar%23242!:1.18.1-61]
	at vazkii.patchouli.client.base.ClientAdvancements.onClientPacket(ClientAdvancements.java:34) ~[Patchouli-1.18.1-61.jar%23242!:1.18.1-61]
	at net.minecraft.client.multiplayer.ClientAdvancements.handler$zie000$patchouli_onSync(ClientAdvancements.java:1017) ~[client-1.18.1-20211210.034407-srg.jar%23323!:?]
	at net.minecraft.client.multiplayer.ClientAdvancements.m_104399_(ClientAdvancements.java:57) ~[client-1.18.1-20211210.034407-srg.jar%23323!:?]
	at net.minecraft.client.multiplayer.ClientPacketListener.m_5498_(ClientPacketListener.java:1127) ~[client-1.18.1-20211210.034407-srg.jar%23323!:?]
	at net.minecraft.network.protocol.game.ClientboundUpdateAdvancementsPacket.m_5797_(ClientboundUpdateAdvancementsPacket.java:51) ~[client-1.18.1-20211210.034407-srg.jar%23323!:?]
	at net.minecraft.network.protocol.game.ClientboundUpdateAdvancementsPacket.m_5797_(ClientboundUpdateAdvancementsPacket.java:16) ~[client-1.18.1-20211210.034407-srg.jar%23323!:?]
	at net.minecraft.network.protocol.PacketUtils.m_131356_(PacketUtils.java:21) ~[client-1.18.1-20211210.034407-srg.jar%23323!:?]
	at net.minecraft.util.thread.BlockableEventLoop.m_6367_(BlockableEventLoop.java:151) ~[client-1.18.1-20211210.034407-srg.jar%23323!:?]
	at net.minecraft.util.thread.ReentrantBlockableEventLoop.m_6367_(ReentrantBlockableEventLoop.java:23) ~[client-1.18.1-20211210.034407-srg.jar%23323!:?]
	at net.minecraft.util.thread.BlockableEventLoop.m_7245_(BlockableEventLoop.java:125) ~[client-1.18.1-20211210.034407-srg.jar%23323!:?]
	at net.minecraft.util.thread.BlockableEventLoop.m_18699_(BlockableEventLoop.java:110) ~[client-1.18.1-20211210.034407-srg.jar%23323!:?]
	at net.minecraft.client.Minecraft.m_91383_(Minecraft.java:1009) ~[client-1.18.1-20211210.034407-srg.jar%23323!:?]
	at net.minecraft.client.Minecraft.m_91374_(Minecraft.java:660) ~[client-1.18.1-20211210.034407-srg.jar%23323!:?]
	at net.minecraft.client.main.Main.main(Main.java:205) ~[client-1.18.1-20211210.034407-srg.jar%23323!:?]
	at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ~[?:?]
	at jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77) ~[?:?]
	at jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) ~[?:?]
	at java.lang.reflect.Method.invoke(Method.java:568) ~[?:?]
	at net.minecraftforge.fml.loading.targets.CommonClientLaunchHandler.lambda$launchService$0(CommonClientLaunchHandler.java:45) ~[fmlloader-1.18.1-39.0.5.jar%2323!:?]
	at cpw.mods.modlauncher.LaunchServiceHandlerDecorator.launch(LaunchServiceHandlerDecorator.java:37) [modlauncher-9.0.7.jar%235!:?]
	at cpw.mods.modlauncher.LaunchServiceHandler.launch(LaunchServiceHandler.java:53) [modlauncher-9.0.7.jar%235!:?]
	at cpw.mods.modlauncher.LaunchServiceHandler.launch(LaunchServiceHandler.java:71) [modlauncher-9.0.7.jar%235!:?]
	at cpw.mods.modlauncher.Launcher.run(Launcher.java:106) [modlauncher-9.0.7.jar%235!:?]
	at cpw.mods.modlauncher.Launcher.main(Launcher.java:77) [modlauncher-9.0.7.jar%235!:?]
	at cpw.mods.modlauncher.BootstrapLaunchConsumer.accept(BootstrapLaunchConsumer.java:26) [modlauncher-9.0.7.jar%235!:?]
	at cpw.mods.modlauncher.BootstrapLaunchConsumer.accept(BootstrapLaunchConsumer.java:23) [modlauncher-9.0.7.jar%235!:?]
	at cpw.mods.bootstraplauncher.BootstrapLauncher.main(BootstrapLauncher.java:90) [bootstraplauncher-0.1.17.jar:?]
[22:41:03] [Render thread/WARN]: Recipe croptopia:shaped_stuffed_artichoke (of type minecraft:crafting) not found
[22:41:03] [Render thread/WARN]: Recipe advancedperipherals:rs_bridge (of type minecraft:crafting) not found
[22:41:03] [Render thread/ERROR]: Error compiling book advancedperipherals:manual, using empty contents
java.lang.RuntimeException: Error building entry advancedperipherals:peripherals/rs_bridge
	at vazkii.patchouli.client.book.BookContentsBuilder.lambda$build$2(BookContentsBuilder.java:88) ~[Patchouli-1.18.1-61.jar%23242!:1.18.1-61]
	at java.util.HashMap$Values.forEach(HashMap.java:1065) ~[?:?]
	at vazkii.patchouli.client.book.BookContentsBuilder.build(BookContentsBuilder.java:84) ~[Patchouli-1.18.1-61.jar%23242!:1.18.1-61]
	at vazkii.patchouli.common.book.Book.reloadContents(Book.java:190) ~[Patchouli-1.18.1-61.jar%23242!:1.18.1-61]
	at vazkii.patchouli.common.book.BookRegistry.reloadContents(BookRegistry.java:164) ~[Patchouli-1.18.1-61.jar%23242!:1.18.1-61]
	at vazkii.patchouli.client.book.ClientBookRegistry.reload(ClientBookRegistry.java:63) ~[Patchouli-1.18.1-61.jar%23242!:1.18.1-61]
	at vazkii.patchouli.client.base.ClientAdvancements.onClientPacket(ClientAdvancements.java:34) ~[Patchouli-1.18.1-61.jar%23242!:1.18.1-61]
	at net.minecraft.client.multiplayer.ClientAdvancements.handler$zie000$patchouli_onSync(ClientAdvancements.java:1017) ~[client-1.18.1-20211210.034407-srg.jar%23323!:?]
	at net.minecraft.client.multiplayer.ClientAdvancements.m_104399_(ClientAdvancements.java:57) ~[client-1.18.1-20211210.034407-srg.jar%23323!:?]
	at net.minecraft.client.multiplayer.ClientPacketListener.m_5498_(ClientPacketListener.java:1127) ~[client-1.18.1-20211210.034407-srg.jar%23323!:?]
	at net.minecraft.network.protocol.game.ClientboundUpdateAdvancementsPacket.m_5797_(ClientboundUpdateAdvancementsPacket.java:51) ~[client-1.18.1-20211210.034407-srg.jar%23323!:?]
	at net.minecraft.network.protocol.game.ClientboundUpdateAdvancementsPacket.m_5797_(ClientboundUpdateAdvancementsPacket.java:16) ~[client-1.18.1-20211210.034407-srg.jar%23323!:?]
	at net.minecraft.network.protocol.PacketUtils.m_131356_(PacketUtils.java:21) ~[client-1.18.1-20211210.034407-srg.jar%23323!:?]
	at net.minecraft.util.thread.BlockableEventLoop.m_6367_(BlockableEventLoop.java:151) ~[client-1.18.1-20211210.034407-srg.jar%23323!:?]
	at net.minecraft.util.thread.ReentrantBlockableEventLoop.m_6367_(ReentrantBlockableEventLoop.java:23) ~[client-1.18.1-20211210.034407-srg.jar%23323!:?]
	at net.minecraft.util.thread.BlockableEventLoop.m_7245_(BlockableEventLoop.java:125) ~[client-1.18.1-20211210.034407-srg.jar%23323!:?]
	at net.minecraft.util.thread.BlockableEventLoop.m_18699_(BlockableEventLoop.java:110) ~[client-1.18.1-20211210.034407-srg.jar%23323!:?]
	at net.minecraft.client.Minecraft.m_91383_(Minecraft.java:1009) ~[client-1.18.1-20211210.034407-srg.jar%23323!:?]
	at net.minecraft.client.Minecraft.m_91374_(Minecraft.java:660) ~[client-1.18.1-20211210.034407-srg.jar%23323!:?]
	at net.minecraft.client.main.Main.main(Main.java:205) ~[client-1.18.1-20211210.034407-srg.jar%23323!:?]
	at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ~[?:?]
	at jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77) ~[?:?]
	at jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) ~[?:?]
	at java.lang.reflect.Method.invoke(Method.java:568) ~[?:?]
	at net.minecraftforge.fml.loading.targets.CommonClientLaunchHandler.lambda$launchService$0(CommonClientLaunchHandler.java:45) ~[fmlloader-1.18.1-39.0.5.jar%2323!:?]
	at cpw.mods.modlauncher.LaunchServiceHandlerDecorator.launch(LaunchServiceHandlerDecorator.java:37) [modlauncher-9.0.7.jar%235!:?]
	at cpw.mods.modlauncher.LaunchServiceHandler.launch(LaunchServiceHandler.java:53) [modlauncher-9.0.7.jar%235!:?]
	at cpw.mods.modlauncher.LaunchServiceHandler.launch(LaunchServiceHandler.java:71) [modlauncher-9.0.7.jar%235!:?]
	at cpw.mods.modlauncher.Launcher.run(Launcher.java:106) [modlauncher-9.0.7.jar%235!:?]
	at cpw.mods.modlauncher.Launcher.main(Launcher.java:77) [modlauncher-9.0.7.jar%235!:?]
	at cpw.mods.modlauncher.BootstrapLaunchConsumer.accept(BootstrapLaunchConsumer.java:26) [modlauncher-9.0.7.jar%235!:?]
	at cpw.mods.modlauncher.BootstrapLaunchConsumer.accept(BootstrapLaunchConsumer.java:23) [modlauncher-9.0.7.jar%235!:?]
	at cpw.mods.bootstraplauncher.BootstrapLauncher.main(BootstrapLauncher.java:90) [bootstraplauncher-0.1.17.jar:?]
Caused by: java.lang.RuntimeException: Error while loading entry advancedperipherals:peripherals/rs_bridge page 2
	at vazkii.patchouli.client.book.BookEntry.build(BookEntry.java:224) ~[Patchouli-1.18.1-61.jar%23242!:1.18.1-61]
	at vazkii.patchouli.client.book.BookContentsBuilder.lambda$build$2(BookContentsBuilder.java:86) ~[Patchouli-1.18.1-61.jar%23242!:1.18.1-61]
	... 32 more
Caused by: java.lang.IllegalArgumentException: Failure parsing state matcher
	at vazkii.patchouli.common.multiblock.SerializedMultiblock.deserializeMapping(SerializedMultiblock.java:41) ~[Patchouli-1.18.1-61.jar%23242!:1.18.1-61]
	at vazkii.patchouli.common.multiblock.SerializedMultiblock.deserializeDense(SerializedMultiblock.java:93) ~[Patchouli-1.18.1-61.jar%23242!:1.18.1-61]
	at vazkii.patchouli.common.multiblock.SerializedMultiblock.toMultiblock(SerializedMultiblock.java:103) ~[Patchouli-1.18.1-61.jar%23242!:1.18.1-61]
	at vazkii.patchouli.client.book.page.PageMultiblock.build(PageMultiblock.java:72) ~[Patchouli-1.18.1-61.jar%23242!:1.18.1-61]
	at vazkii.patchouli.client.book.BookEntry.build(BookEntry.java:221) ~[Patchouli-1.18.1-61.jar%23242!:1.18.1-61]
	at vazkii.patchouli.client.book.BookContentsBuilder.lambda$build$2(BookContentsBuilder.java:86) ~[Patchouli-1.18.1-61.jar%23242!:1.18.1-61]
	... 32 more
Caused by: com.mojang.brigadier.exceptions.CommandSyntaxException: Unknown block type 'advancedperipherals:rs_bridge' at position 0: <--[HERE]
[22:41:03] [Render thread/WARN]: Recipe cyclic:location (of type minecraft:crafting) not found
[22:41:03] [Render thread/WARN]: Recipe cyclic:charm_void (of type minecraft:crafting) not found
[22:41:03] [Render thread/WARN]: Recipe cyclic:spawner_seeker (of type minecraft:crafting) not found
[22:41:03] [Render thread/WARN]: Recipe cyclic:beacon (of type minecraft:crafting) not found
[22:41:03] [Render thread/WARN]: Recipe cyclic:charm_wither (of type minecraft:crafting) not found
[22:41:03] [Render thread/WARN]: Recipe cyclic:charm_home (of type minecraft:crafting) not found
[22:41:03] [Render thread/WARN]: Recipe cyclic:peat_fuel (of type minecraft:smelting) not found
[22:41:03] [Render thread/WARN]: Recipe cyclic:eye_teleport (of type minecraft:crafting) not found
[22:41:03] [Render thread/WARN]: Recipe cyclic:teleport_wand (of type minecraft:crafting) not found
[22:41:03] [Render thread/WARN]: Recipe cyclic:ender_book (of type minecraft:crafting) not found
[22:41:03] [Render thread/WARN]: Recipe cyclic:experience_food (of type minecraft:crafting) not found
[22:41:03] [Render thread/WARN]: Recipe cyclic:charm_fire (of type minecraft:crafting) not found
[22:41:03] [Render thread/WARN]: Recipe cyclic:elevation_wand (of type minecraft:crafting) not found
[22:41:03] [Render thread/FATAL]: Error executing task on Client
java.lang.NullPointerException: Cannot read field "entries" because "this.contents" is null
	at vazkii.patchouli.common.book.Book.reloadLocks(Book.java:204) ~[Patchouli-1.18.1-61.jar%23242!:1.18.1-61]
	at vazkii.patchouli.client.book.ClientBookRegistry.lambda$reloadLocks$0(ClientBookRegistry.java:67) ~[Patchouli-1.18.1-61.jar%23242!:1.18.1-61]
	at java.util.HashMap$Values.forEach(HashMap.java:1065) ~[?:?]
	at vazkii.patchouli.client.book.ClientBookRegistry.reloadLocks(ClientBookRegistry.java:67) ~[Patchouli-1.18.1-61.jar%23242!:1.18.1-61]
	at vazkii.patchouli.common.book.BookRegistry.reloadContents(BookRegistry.java:166) ~[Patchouli-1.18.1-61.jar%23242!:1.18.1-61]
	at vazkii.patchouli.client.book.ClientBookRegistry.reload(ClientBookRegistry.java:63) ~[Patchouli-1.18.1-61.jar%23242!:1.18.1-61]
	at vazkii.patchouli.client.base.ClientAdvancements.onClientPacket(ClientAdvancements.java:34) ~[Patchouli-1.18.1-61.jar%23242!:1.18.1-61]
	at net.minecraft.client.multiplayer.ClientAdvancements.handler$zie000$patchouli_onSync(ClientAdvancements.java:1017) ~[client-1.18.1-20211210.034407-srg.jar%23323!:?]
	at net.minecraft.client.multiplayer.ClientAdvancements.m_104399_(ClientAdvancements.java:57) ~[client-1.18.1-20211210.034407-srg.jar%23323!:?]
	at net.minecraft.client.multiplayer.ClientPacketListener.m_5498_(ClientPacketListener.java:1127) ~[client-1.18.1-20211210.034407-srg.jar%23323!:?]
	at net.minecraft.network.protocol.game.ClientboundUpdateAdvancementsPacket.m_5797_(ClientboundUpdateAdvancementsPacket.java:51) ~[client-1.18.1-20211210.034407-srg.jar%23323!:?]
	at net.minecraft.network.protocol.game.ClientboundUpdateAdvancementsPacket.m_5797_(ClientboundUpdateAdvancementsPacket.java:16) ~[client-1.18.1-20211210.034407-srg.jar%23323!:?]
	at net.minecraft.network.protocol.PacketUtils.m_131356_(PacketUtils.java:21) ~[client-1.18.1-20211210.034407-srg.jar%23323!:?]
	at net.minecraft.util.thread.BlockableEventLoop.m_6367_(BlockableEventLoop.java:151) ~[client-1.18.1-20211210.034407-srg.jar%23323!:?]
	at net.minecraft.util.thread.ReentrantBlockableEventLoop.m_6367_(ReentrantBlockableEventLoop.java:23) ~[client-1.18.1-20211210.034407-srg.jar%23323!:?]
	at net.minecraft.util.thread.BlockableEventLoop.m_7245_(BlockableEventLoop.java:125) ~[client-1.18.1-20211210.034407-srg.jar%23323!:?]
	at net.minecraft.util.thread.BlockableEventLoop.m_18699_(BlockableEventLoop.java:110) ~[client-1.18.1-20211210.034407-srg.jar%23323!:?]
	at net.minecraft.client.Minecraft.m_91383_(Minecraft.java:1009) ~[client-1.18.1-20211210.034407-srg.jar%23323!:?]
	at net.minecraft.client.Minecraft.m_91374_(Minecraft.java:660) ~[client-1.18.1-20211210.034407-srg.jar%23323!:?]
	at net.minecraft.client.main.Main.main(Main.java:205) ~[client-1.18.1-20211210.034407-srg.jar%23323!:?]
	at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ~[?:?]
	at jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77) ~[?:?]
	at jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) ~[?:?]
	at java.lang.reflect.Method.invoke(Method.java:568) ~[?:?]
	at net.minecraftforge.fml.loading.targets.CommonClientLaunchHandler.lambda$launchService$0(CommonClientLaunchHandler.java:45) ~[fmlloader-1.18.1-39.0.5.jar%2323!:?]
	at cpw.mods.modlauncher.LaunchServiceHandlerDecorator.launch(LaunchServiceHandlerDecorator.java:37) [modlauncher-9.0.7.jar%235!:?]
	at cpw.mods.modlauncher.LaunchServiceHandler.launch(LaunchServiceHandler.java:53) [modlauncher-9.0.7.jar%235!:?]
	at cpw.mods.modlauncher.LaunchServiceHandler.launch(LaunchServiceHandler.java:71) [modlauncher-9.0.7.jar%235!:?]
	at cpw.mods.modlauncher.Launcher.run(Launcher.java:106) [modlauncher-9.0.7.jar%235!:?]
	at cpw.mods.modlauncher.Launcher.main(Launcher.java:77) [modlauncher-9.0.7.jar%235!:?]
	at cpw.mods.modlauncher.BootstrapLaunchConsumer.accept(BootstrapLaunchConsumer.java:26) [modlauncher-9.0.7.jar%235!:?]
	at cpw.mods.modlauncher.BootstrapLaunchConsumer.accept(BootstrapLaunchConsumer.java:23) [modlauncher-9.0.7.jar%235!:?]
	at cpw.mods.bootstraplauncher.BootstrapLauncher.main(BootstrapLauncher.java:90) [bootstraplauncher-0.1.17.jar:?]
[22:41:04] [spark-forge-async-worker/INFO]: [CHAT] [?] The active profiler has been stopped! Uploading results...
[22:41:06] [spark-forge-async-worker/INFO]: [CHAT] [?] Profiler results:
[22:41:06] [spark-forge-async-worker/INFO]: [CHAT] https://spark.lucko.me/LSeTxTHqa5

williewillus · Answer 1 · 2021-12-19T16:40:33.000Z

I couldn't reproduce in that I couldn't get an advancement get to cause another book reload, so our hook seems to be ok.

williewillus · Answer 2 · 2021-12-18T19:17:48.000Z

huh, looks like the books are somehow getting reloaded when an advancement happens. We should only be doing this the first time the player logs in.

Can you try something else? Get a fresh creative world, and try opening any Patchouli book before getting an advancement. Are the book contents there or do you get blank/missing contents?

itsdinkd · Answer 3 · 2021-12-19T20:32:24.000Z

I think there might be reloading due to KubeJs? Just a thought. I know in fabric it reloads my scripts all the time (not patchouli books tho) but would that make sense?

…

On Sun, Dec 19, 2021, 8:40 AM Vincent Lee ***@***.***> wrote: I couldn't reproduce in that I couldn't get an advancement get to cause another book reload, so our hook seems to be ok. — Reply to this email directly, view it on GitHub <#481 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AIL5CKDXYDJC6SKJPZYPNBLURYDIZANCNFSM5KKJ5FOQ> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>. You are receiving this because you authored the thread.Message ID: ***@***.***>

williewillus · Answer 4 · 2021-12-19T03:44:30.000Z

I can't reproduce this. Can you try with just Patchouli and a single mod that uses it? To help narrow things down.

Hubry · Answer 5 · 2021-12-19T09:54:04.000Z

Given how much time is spent in Forge/ModLauncher internals, this might be dependent on the mod amount?

whatthedrunk · Answer 6 · 2021-12-20T14:59:10.000Z

I had this issue and was able to track down which mod was causing issues. For me it was Occultism. Every time I picked up a new item or crafted anything I would lag out. Removed Occultism and kept Patchouli in and it was fine.

klikli-dev · Answer 7 · 2021-12-20T18:34:02.000Z

Occultism dev here - looking into this now. Not entirely sure why this happens, we're not intentionally doing that on advancements, and didn't change anything compared to 1.17.

klikli-dev · Answer 8 · 2021-12-20T19:01:25.000Z

Update: It seems this also happens on ATM 7 0.2.7, which does not contain occultism.
latest.log

It seems occultism only causes the visible symptoms (lag), probably due to the size of the book and the included multiblocks.

EDIT: The slow occultism loading times are due to "use_resource_pack": true, when moving back to /data it reloads as quickly as in previous versions

itsdinkd · Answer 9 · 2021-12-22T19:39:04.000Z

It's safe to say Occultism is not the cause of this. I am still getting this lag, even with occultism fixing their end. I think the greater issue is with Patchouli

Here is what is happening on each achievement now
first three lines and then what shows in paste bin is after (forgot to add advancement line into pastebin)

[11:32:13] [Render thread/INFO]: [CHAT] DaddyDanked has made the advancement [Roam the World in a Random Fashion]
[11:32:13] [Render thread/INFO]: [CHAT] Gave 1    [Ring of the Explorer] to DaddyDanked
[11:32:13] [Render thread/INFO]: Loaded 1326 advancements

https://pastebin.com/GFzhFR5y

itsdinkd · Answer 10 · 2021-12-22T19:40:50.000Z

EDIT: The slow occultism loading times are due to "use_resource_pack": true, when moving back to /data it reloads as quickly as in previous versions

is this something I as a modpack dev can utilize as a global setting to set false? or does the individual mod developers have to do this

Hubry · Answer 11 · 2021-12-22T20:25:00.000Z

I have an attempt at using the proper resource loading systems done in my local repo, reading all the files on resource reload and loading books from cached JSON data instead (yeah, it doesn't use reload listeners for book loading at the moment...). At the moment this does sacrifice quick reloads from the gui but I guess I could bypass this system in that case.

Should I just send a jar to you for a quick test? (Ideally hit me up on Vazkii's discord in ~2.5 hours, though I guess I can drop it here if you'd prefer)

ZeroNoRyouki · Answer 12 · 2021-12-22T20:42:41.000Z

I've just tested this in my dev env and I don't see it happening. I've put a couple of breakpoints in Patchouli (BookContentResourceLoader::loadJson / BookPage constructor) and they are only hit when I join the world or if I force reload the assets but not when I trigger an advancement. Maybe another mod is triggering a reload?

Hubry · Answer 13 · 2021-12-26T18:54:59.000Z

The new version using reload listeners to reload resource pack books is out, hopefully this works.

Share to