Mod loader

Forge

Minecraft version

1.19.4

Patchouli version

1.19.4-79

Modloader version

forge 45.1.0

Modpack info

No response

The latest.log file

https://gist.github.com/warlordkiyan/96f781521ff338ac4bb13f60e97689c6

Issue description

i started a minecraft server with patchouli because some mods uses patchouli to help give information about items in the mod but when i try to connect an error shows up

single player works fine but connecting to the server isnt

Steps to reproduce

No response

Other information

No response

I'm having the same issue on 1.20.1, after investigating for a bit I think that the issue is with the following from BookRecipeSerializer:

  public @NotNull U fromNetwork(@NotNull ResourceLocation id, @NotNull FriendlyByteBuf buf) {
      T recipe = this.compose().fromNetwork(id, buf);
      return (Recipe)this.converter().apply(recipe, (Object)null);
  }

passing null into the converter is breaking assumptions later on, it should be (I'm pretty sure) the ResourceLocation outputBook.

Same Error. Have to remove the mod and then it was working to join the server. It is the 1.20.1 version too.

Can report the same issue here too, with the 1.20.1 port that was pushed to CurseForge today. Had to advise my users to remove the mod in the meantime.

a82e9f4
will release a 1.19 backport shortly

@Talia-12 That null was explicitly placed there by 9b3ac17

@Hubry do you remember why this was done?

Oh actually, I see the bug. The code shifted around in 1.19 I believe, will fix.