Patchouli (Fabric/Quilt)

Describe the feature

Currently the search only matches on a given entry's name (and... relevant item tooltip?). For some mods this is enough, but for others, where a single entry may contain many pages of different info, it causes the search to become significantly less useful.

So it would be very nice if mods could define their own custom search function to supplement or fully replace this, when the mod does not deal with just items that can be associated. Or perhaps the system of "relevant item" could be extended to be some extensible relevant thing? But that sounds much more complex than letting mods hook into this function.

Patchouli/Xplat/src/main/java/vazkii/patchouli/client/book/BookEntry.java

Lines 196 to 208 in 5928e64

    
           public boolean isFoundByQuery(String query) { 
        
           	if (getName().getString().toLowerCase().contains(query)) { 
        
           		return true; 
        
           	} 
        
           	for (StackWrapper wrapper : relevantStacks) { 
        
           		if (wrapper.stack.getHoverName().getString().toLowerCase().contains(query)) { 
        
           			return true; 
        
           		} 
        
           	} 
        
           	return false; 
        
           }

Additional context

I'm mostly considering things in context of Hex Casting, but a possible option to work within the system is to make own entry for every single "pattern" in the mod. This is not particularly viable, I think. Adding it all into the name is definitely not an option. Could theoretically make a custom page that acts as a search page?

	public boolean isFoundByQuery(String query) {
	if (getName().getString().toLowerCase().contains(query)) {
	return true;
	}

	for (StackWrapper wrapper : relevantStacks) {
	if (wrapper.stack.getHoverName().getString().toLowerCase().contains(query)) {
	return true;
	}
	}

	return false;
	}

Share to

Describe the feature

Additional context