i don't know if it applies to any other crop in the mod either, all i know is that shift right clicking with the book causes the game to crash. crash report is below for you to decide yourself

it may not be either one of these mods at all, but when i read the report the only mod that popped up while reading it was patchouli

crash-2021-03-12_18.31.18-client.txt

I read the code a bit more and I'm pretty sure what's there is correct (at least in latest 1.18). If it were broken a lot of other books would crash. Can anyone reproduce this on latest 1.18?

After some investigation, I think this might be a patchouli bug. Details here:

https://github.com/Vazkii/Patchouli/blob/21a19855a9b45a1c311c053dcc448364d8c870af/src/main/java/vazkii/patchouli/client/book/BookContents.java#L277-L282

The onion entry only has 2 pages, but the page passed here is 2, so it calculates the spread to be 1, which is wrong (should be 0).

When rendering, both the left page and right page are null (because the spread is bigger than the maximum spread), which eventually caused NPE.

https://github.com/Vazkii/Patchouli/blob/21a19855a9b45a1c311c053dcc448364d8c870af/src/main/java/vazkii/patchouli/client/handler/BookRightClickHandler.java#L84

I guess this shouldn't be multiplied by 2?

This issue is stale because it has been open for a while with no activity. Please bump if this is still an issue, or this ticket will be closed soon.

This issue still exists, any idea?