Hi - first I want to say, this is a great addition to provide better books to my players, so thank you for doing this.
I've got my book working in JEI and in the appropriate Creative Tab and navigating, sort order all works as well.
What I'm having issues with is getting the book into a players hands using the examples you provided on https://vazkiimods.github.io/Patchouli/docs/patchouli-basics/giving-new
It just does nothing from what I can tell and I'm currently only testing on single player in my mod and modpack.
I'm assuming it is just either a format issue or getting the right namespace/item id to be correct. Using the give @p patchouli:guide_book does work, but its a non-functional book and isn't the book I'm working on. I try using my namespace and that never finds a match. Can you tell me what I'm doing wrong here with the advancement/loot_table files to give the book?



I've tried replacing the grant_book_on_first_join text as well with the same results.
Thanks! -Steve

I assume you're making as mod pack. Thus, your book's ID is patchouli:serverbook. The book ID you have set in the loot table is wrong. It is TmTmc-ServerBasics, and should be patchouli:serverbook.

Additionally, the loot table and advancements should both be in a vanilla data pack, not in the patchouli_books folder.

upload a zip of your datapack. Also, Discord #patchouli channel is a better channel for support than Github issues.

So I've been digging into creating the datapack and while I can execute the functions and see the datapack is loaded, when I try the /advancement grant smmmadden only patchouli_books:serverbook last I see:
Couldn't grant advancement serverbook:adv_serverbook to smmmadden as they already have it
So I changed it to revoke and it says it was revoked, but a follow up command to grant still says I have it (and I do not). I've also deleted the playerdata file for my UUID in case it was stored there, but no dice. So close, yet no cigar as they say.

http://www.takemetominecraft.com:8075/modpacks/TmTmc-ServerBasics_Book_1.0.zip
Here's the datapack. Hopefully it's a simple typo or naming issue. Appreciate the help and will get connected to Discord channel too. -Steve