Patchouli

Patchouli

134M Downloads

Patchouli stays locked when server reports no advancements

chrisliebaer opened this issue ยท 0 comments

commented

Mod loader

Forge

Minecraft version

1.20.1

Patchouli version

1.20.1-84-FORGE

Modloader version

47.2.16

Modpack info

ATM9 (modified)

The latest.log file

Issue description

In order to combat massive lags due to inventory changes (which in turn cause advancements checks inside nms code) I have removed all advancements on my server using a plugin I wrote.

This breaks Patchouli and all books stay locked even with disableAdvancementLocking = true.

My suspicion is, that therefore vazkii.patchouli.client.base.ClientAdvancements#onClientPacket is never called and therefore unlocks are never checked. Loading a single player world before joining a server fixes this issue, probably because a forge resource reload is triggered, causing all unlocks to be recalculated.

Given that my modifications are quite disruptive, I don't know if you consider this a bug worth fixing. But I decided to let you know. I'm probably going to work around this by returning a single advancement.

Steps to reproduce

No response

Other information

No response