[Bug] 🐞 Perfect Plushies Causing Empty Chests
serioos opened this issue · 10 comments
I've reported this issue here before:
someaddons/LootIntegrations#13
And I wanted to report it here as well. I get empty chests while looting water chests mostly and they happen quite frequently as well.
https://gist.github.com/serioos/14d7f67a8b5ef5be4fea0eaa234ce30d
Minecraft 1.20.1 Forge 47.3.1
lootintegrations-1.20.1-3.7.jar
perfectplushies-forge-1.20.1-1.10.1.jar
@SirJain0
I've tested the loot generation for buried treasure chests with and without perfect plushies in our modpack.
@Crafterluck and I continue to track down the problem and follow up with more information.
All Mods except Perfect Plushies
5/5 Chests generate as expected
All Mods including Perfect Plushies
2/5 Chests generate as expected
none of the generated chests contain a plushy
3/5 Chests fail generation
chests which failed were empty
Error message on generation Failure
[Server thread/ERROR] [minecraft/PacketUtils]: Failed to handle packet net.minecraft.network.protocol.game.ServerboundUseItemOnPacket@6e6e4d50, suppressing error
java.util.NoSuchElementException: No value present
at java.util.Optional.get(Unknown Source) ~[?:?] {re:mixin}
at com.nyfaria.perfectplushieapi.loot.VillageLootModifier.doApply(VillageLootModifier.java:43) ~[perfectplushieapi-forge-1.20.1-0.1.1.jar%23634!/:0.1.1] {re:classloading}
at net.minecraftforge.common.loot.LootModifier.apply(LootModifier.java:58) ~[forge-1.20.1-47.3.0-universal.jar%23472!/:?] {re:classloading}
at net.minecraftforge.common.ForgeHooks.modifyLoot(ForgeHooks.java:1186) ~[forge-1.20.1-47.3.0-universal.jar%23472!/:?] {re:mixin,re:classloading,pl:mixin:APP:connectormod.mixins.json:ForgeHooksMixin from mod connectormod,pl:mixin:APP:connectormod.mixins.json:item.ForgeHooksMixin from mod connectormod,pl:mixin:A}
at net.minecraft.world.level.storage.loot.LootTable.m_230922_(LootTable.java:118) ~[server-1.20.1-20230612.114412-srg.jar%23467!/:?] {re:mixin,pl:accesstransformer:B,pl:connector_pre_launch:A,re:classloading,pl:accesstransformer:B,pl:mixin:APP:zeta.mixins.json:AccessorLootTable from mod zeta,pl:mixin:APP:puzzleslib.forge.mixins.json:accessor.LootTableForgeAccessor from mod puzzleslib,pl:mixin:APP:crittersandcompanions.mixins.json:LootTableAccessor from mod crittersandcompanions,pl:mixin:APP:fabric-loot-api-v2.mixins.json:LootTableAccessor from mod fabric_loot_api_v2,pl:mixin:A,pl:connector_pre_launch:A}
at net.minecraft.world.level.storage.loot.LootTable.m_287188_(LootTable.java:139) ~[server-1.20.1-20230612.114412-srg.jar%23467!/:?] {re:mixin,pl:accesstransformer:B,pl:connector_pre_launch:A,re:classloading,pl:accesstransformer:B,pl:mixin:APP:zeta.mixins.json:AccessorLootTable from mod zeta,pl:mixin:APP:puzzleslib.forge.mixins.json:accessor.LootTableForgeAccessor from mod puzzleslib,pl:mixin:APP:crittersandcompanions.mixins.json:LootTableAccessor from mod crittersandcompanions,pl:mixin:APP:fabric-loot-api-v2.mixins.json:LootTableAccessor from mod fabric_loot_api_v2,pl:mixin:A,pl:connector_pre_launch:A}
at net.minecraft.world.level.block.entity.RandomizableContainerBlockEntity.m_59640_(RandomizableContainerBlockEntity.java:82) ~[server-1.20.1-20230612.114412-srg.jar%23467!/:?] {re:mixin,pl:accesstransformer:B,pl:connector_pre_launch:A,re:classloading,pl:accesstransformer:B,pl:mixin:APP:tcdcommons.mixin.events.json:MixinLootableContainerBlockEntity from mod tcdcommons,pl:mixin:APP:fabric-transfer-api-v1.mixins.json:LootableContainerBlockEntityMixin from mod fabric_transfer_api_v1,pl:mixin:A,pl:connector_pre_launch:A}
at net.minecraft.world.level.block.entity.RandomizableContainerBlockEntity.m_8020_(RandomizableContainerBlockEntity.java:99) ~[server-1.20.1-20230612.114412-srg.jar%23467!/:?] {re:mixin,pl:accesstransformer:B,pl:connector_pre_launch:A,re:classloading,pl:accesstransformer:B,pl:mixin:APP:tcdcommons.mixin.events.json:MixinLootableContainerBlockEntity from mod tcdcommons,pl:mixin:APP:fabric-transfer-api-v1.mixins.json:LootableContainerBlockEntityMixin from mod fabric_transfer_api_v1,pl:mixin:A,pl:connector_pre_launch:A}
at com.daqem.grieflogger.block.container.ContainerTransactionManager.<init>(ContainerTransactionManager.java:25) ~[grieflogger-1.1.4-forge.jar%23379!/:?] {re:mixin,re:classloading}
at net.minecraft.server.level.ServerPlayer.mdd02761$grieflogger$lambda$openMenu$0$1(ServerPlayer.java:7380) ~[server-1.20.1-20230612.114412-srg.jar%23467!/:?] {re:computing_frames,pl:accesstransformer:B,pl:connector_pre_launch:A,re:mixin,pl:accesstransformer:B,pl:connector_pre_launch:A,re:classloading,pl:accesstransformer:B,pl:mixin:APP:yungsapi.mixins.json:ServerPlayerEntityTickMixin from mod yungsapi,pl:mixin:APP:forgivingvoid.mixins.json:ServerPlayerAccessor from mod forgivingvoid,pl:mixin:APP:tcdcommons.mixin.events.json:MixinServerPlayerEntity from mod tcdcommons,pl:mixin:APP:fabric-entity-events-v1.mixins.json:ServerPlayerEntityMixin from mod fabric_entity_events_v1,pl:mixin:APP:missions-common.mixins.json:events.DrinkHandler from mod missions,pl:mixin:APP:fabric-screen-handler-api-v1.mixins.json:ServerPlayerEntityMixin from mod fabric_screen_handler_api_v1,pl:mixin:APP:deathpenalty.mixins.json:ServerPlayerMixin from mod deathpenalty,pl:mixin:APP:logprot.mixins.json:ServerPlayerMixin from mod logprot,pl:mixin:APP:backpacked.common.mixins.json:common.ServerPlayerMixin from mod backpacked,pl:mixin:APP:betterend.mixins.common.json:ServerPlayerMixin from mod betterend,pl:mixin:APP:numismatics-common.mixins.json:MixinServerPlayer from mod numismatics,pl:mixin:APP:grieflogger-common.mixins.json:MixinServerPlayer from mod grieflogger,pl:mixin:APP:kubejs-common.mixins.json:ServerPlayerMixin from mod kubejs,pl:mixin:APP:owo.mixins.json:ServerPlayerEntityMixin from mod owo,pl:mixin:APP:betterdeserttemples.mixins.json:ServerPlayerTickMixin from mod betterdeserttemples,pl:mixin:APP:sgui.mixins.json:ServerPlayerEntityMixin from mod sgui,pl:mixin:APP:railways-common.mixins.json:conductor_possession.ServerPlayerMixin from mod railways,pl:mixin:A,pl:connector_pre_launch:A}
at java.util.Optional.ifPresent(Unknown Source) ~[?:?] {re:mixin}
at net.minecraft.server.level.ServerPlayer.handler$daj000$grieflogger$openMenu(ServerPlayer.java:7379) ~[server-1.20.1-20230612.114412-srg.jar%23467!/:?] {re:computing_frames,pl:accesstransformer:B,pl:connector_pre_launch:A,re:mixin,pl:accesstransformer:B,pl:connector_pre_launch:A,re:classloading,pl:accesstransformer:B,pl:mixin:APP:yungsapi.mixins.json:ServerPlayerEntityTickMixin from mod yungsapi,pl:mixin:APP:forgivingvoid.mixins.json:ServerPlayerAccessor from mod forgivingvoid,pl:mixin:APP:tcdcommons.mixin.events.json:MixinServerPlayerEntity from mod tcdcommons,pl:mixin:APP:fabric-entity-events-v1.mixins.json:ServerPlayerEntityMixin from mod fabric_entity_events_v1,pl:mixin:APP:missions-common.mixins.json:events.DrinkHandler from mod missions,pl:mixin:APP:fabric-screen-handler-api-v1.mixins.json:ServerPlayerEntityMixin from mod fabric_screen_handler_api_v1,pl:mixin:APP:deathpenalty.mixins.json:ServerPlayerMixin from mod deathpenalty,pl:mixin:APP:logprot.mixins.json:ServerPlayerMixin from mod logprot,pl:mixin:APP:backpacked.common.mixins.json:common.ServerPlayerMixin from mod backpacked,pl:mixin:APP:betterend.mixins.common.json:ServerPlayerMixin from mod betterend,pl:mixin:APP:numismatics-common.mixins.json:MixinServerPlayer from mod numismatics,pl:mixin:APP:grieflogger-common.mixins.json:MixinServerPlayer from mod grieflogger,pl:mixin:APP:kubejs-common.mixins.json:ServerPlayerMixin from mod kubejs,pl:mixin:APP:owo.mixins.json:ServerPlayerEntityMixin from mod owo,pl:mixin:APP:betterdeserttemples.mixins.json:ServerPlayerTickMixin from mod betterdeserttemples,pl:mixin:APP:sgui.mixins.json:ServerPlayerEntityMixin from mod sgui,pl:mixin:APP:railways-common.mixins.json:conductor_possession.ServerPlayerMixin from mod railways,pl:mixin:A,pl:connector_pre_launch:A}
at net.minecraft.server.level.ServerPlayer.m_5893_(ServerPlayer.java) ~[server-1.20.1-20230612.114412-srg.jar%23467!/:?] {re:computing_frames,pl:accesstransformer:B,pl:connector_pre_launch:A,re:mixin,pl:accesstransformer:B,pl:connector_pre_launch:A,re:classloading,pl:accesstransformer:B,pl:mixin:APP:yungsapi.mixins.json:ServerPlayerEntityTickMixin from mod yungsapi,pl:mixin:APP:forgivingvoid.mixins.json:ServerPlayerAccessor from mod forgivingvoid,pl:mixin:APP:tcdcommons.mixin.events.json:MixinServerPlayerEntity from mod tcdcommons,pl:mixin:APP:fabric-entity-events-v1.mixins.json:ServerPlayerEntityMixin from mod fabric_entity_events_v1,pl:mixin:APP:missions-common.mixins.json:events.DrinkHandler from mod missions,pl:mixin:APP:fabric-screen-handler-api-v1.mixins.json:ServerPlayerEntityMixin from mod fabric_screen_handler_api_v1,pl:mixin:APP:deathpenalty.mixins.json:ServerPlayerMixin from mod deathpenalty,pl:mixin:APP:logprot.mixins.json:ServerPlayerMixin from mod logprot,pl:mixin:APP:backpacked.common.mixins.json:common.ServerPlayerMixin from mod backpacked,pl:mixin:APP:betterend.mixins.common.json:ServerPlayerMixin from mod betterend,pl:mixin:APP:numismatics-common.mixins.json:MixinServerPlayer from mod numismatics,pl:mixin:APP:grieflogger-common.mixins.json:MixinServerPlayer from mod grieflogger,pl:mixin:APP:kubejs-common.mixins.json:ServerPlayerMixin from mod kubejs,pl:mixin:APP:owo.mixins.json:ServerPlayerEntityMixin from mod owo,pl:mixin:APP:betterdeserttemples.mixins.json:ServerPlayerTickMixin from mod betterdeserttemples,pl:mixin:APP:sgui.mixins.json:ServerPlayerEntityMixin from mod sgui,pl:mixin:APP:railways-common.mixins.json:conductor_possession.ServerPlayerMixin from mod railways,pl:mixin:A,pl:connector_pre_launch:A}
at net.minecraft.server.level.ServerPlayerGameMode.m_7179_(ServerPlayerGameMode.java:328) ~[server-1.20.1-20230612.114412-srg.jar%23467!/:?] {re:mixin,pl:accesstransformer:B,pl:connector_pre_launch:A,re:computing_frames,pl:accesstransformer:B,pl:connector_pre_launch:A,re:classloading,pl:accesstransformer:B,pl:mixin:APP:backpacked.common.mixins.json:common.ServerPlayerGameModeMixin from mod backpacked,pl:mixin:APP:infinitybuttons.mixins.json:ServerPlayerGameModeMixin from mod infinitybuttons,pl:mixin:APP:fabric-events-interaction-v0.mixins.json:ServerPlayerInteractionManagerMixin from mod fabric_events_interaction_v0,pl:mixin:A,pl:connector_pre_launch:A}
at net.minecraft.server.network.ServerGamePacketListenerImpl.m_6371_(ServerGamePacketListenerImpl.java:1057) ~[server-1.20.1-20230612.114412-srg.jar%23467!/:?] {re:mixin,pl:accesstransformer:B,pl:connector_pre_launch:A,re:classloading,pl:accesstransformer:B,pl:mixin:APP:fabric-networking-api-v1.mixins.json:ServerPlayNetworkHandlerMixin from mod fabric_networking_api_v1,pl:mixin:APP:modernfix-forge.mixins.json:bugfix.forge_vehicle_packets.ServerGamePacketListenerImplMixin from mod modernfix,pl:mixin:APP:forgivingvoid.mixins.json:ServerGamePacketListenerImplAccessor from mod forgivingvoid,pl:mixin:APP:exposure-common.mixins.json:ServerGamePacketListenerMixin from mod exposure,pl:mixin:APP:graveyard-common.mixins.json:ServerPlayNetworkHandlerMixin from mod graveyard,pl:mixin:APP:logprot.mixins.json:ServerGamePacketListenerImplMixin from mod logprot,pl:mixin:APP:bettercombat.mixins.json:ServerPlayNetworkHandlerMixin from mod bettercombat,pl:mixin:APP:mixins/common/nochatreports.mixins.json:server.MixinServerGamePacketListenerImpl from mod nochatreports,pl:mixin:APP:numismatics.mixins.json:ServerGamePacketListenerImplMixin from mod numismatics,pl:mixin:APP:railways.mixins.json:ServerGamePacketListenerImplMixin from mod railways,pl:mixin:APP:fabric-networking-api-v1.mixins.json:accessor.ServerPlayNetworkHandlerAccessor from mod fabric_networking_api_v1,pl:mixin:APP:owo.mixins.json:ServerPlayNetworkHandlerAccessor from mod owo,pl:mixin:APP:copycats-forge.mixins.json:network.ServerGamePacketListenerImplMixin from mod copycats,pl:mixin:APP:cobblegen.mixins.json:network.ServerCommonPacketListenerMixin from mod cobblegen,pl:mixin:APP:quark.mixins.json:accessor.AccessorServerGamePacketListener from mod quark,pl:mixin:APP:supplementaries-common.mixins.json:ServerGamePacketListenerMixin from mod supplementaries,pl:mixin:APP:sgui.mixins.json:ServerPlayNetworkHandlerMixin from mod sgui,pl:mixin:APP:automobility.mixins.json:ServerGamePacketListenerImplMixin from mod automobility,pl:mixin:APP:c2me-opts-scheduling.mixins.json:ordering.player_move.MixinServerPlayNetworkHandler from mod c2me_opts_scheduling,pl:mixin:APP:tcdcommons.mixin.events.json:MixinServerPlayNetworkHandler from mod tcdcommons,pl:mixin:A,pl:connector_pre_launch:A}
at net.minecraft.network.protocol.game.ServerboundUseItemOnPacket.m_5797_(ServerboundUseItemOnPacket.java:34) ~[server-1.20.1-20230612.114412-srg.jar%23467!/:?] {re:mixin,pl:connector_pre_launch:A,re:classloading,pl:connector_pre_launch:A}
at net.minecraft.network.protocol.game.ServerboundUseItemOnPacket.m_5797_(ServerboundUseItemOnPacket.java:8) ~[server-1.20.1-20230612.114412-srg.jar%23467!/:?] {re:mixin,pl:connector_pre_launch:A,re:classloading,pl:connector_pre_launch:A}
at net.minecraft.network.protocol.PacketUtils.m_263899_(PacketUtils.java:22) ~[server-1.20.1-20230612.114412-srg.jar%23467!/:?] {re:mixin,pl:connector_pre_launch:A,re:classloading,pl:connector_pre_launch:A}
at net.minecraft.server.TickTask.run(TickTask.java:18) ~[server-1.20.1-20230612.114412-srg.jar%23467!/:?] {re:classloading,pl:connector_pre_launch:A,re:mixin,pl:connector_pre_launch:A}
at net.minecraft.util.thread.BlockableEventLoop.m_6367_(BlockableEventLoop.java:156) ~[server-1.20.1-20230612.114412-srg.jar%23467!/:?] {re:mixin,pl:accesstransformer:B,pl:connector_pre_launch:A,re:computing_frames,pl:accesstransformer:B,pl:connector_pre_launch:A,re:classloading,pl:accesstransformer:B,pl:mixin:APP:modernfix-common.mixins.json:perf.fix_loop_spin_waiting.BlockableEventLoopMixin from mod modernfix,pl:mixin:A,pl:connector_pre_launch:A}
at net.minecraft.util.thread.ReentrantBlockableEventLoop.m_6367_(ReentrantBlockableEventLoop.java:23) ~[server-1.20.1-20230612.114412-srg.jar%23467!/:?] {re:mixin,pl:connector_pre_launch:A,re:computing_frames,pl:connector_pre_launch:A,re:classloading,pl:connector_pre_launch:A}
at net.minecraft.server.MinecraftServer.m_6367_(MinecraftServer.java:770) ~[server-1.20.1-20230612.114412-srg.jar%23467!/:?] {re:mixin,pl:accesstransformer:B,pl:connector_pre_launch:A,re:computing_frames,pl:accesstransformer:B,pl:connector_pre_launch:A,re:classloading,pl:accesstransformer:B,pl:mixin:APP:saturn.mixins.json:allocations.server_directory.MinecraftServerMixin from mod saturn,pl:mixin:APP:modernfix-common.mixins.json:perf.dedicated_reload_executor.MinecraftServerMixin from mod modernfix,pl:mixin:APP:modernfix-common.mixins.json:core.MinecraftServerMixin from mod modernfix,pl:mixin:APP:tcdcommons.mixin.events.json:MixinMinecraftServer from mod tcdcommons,pl:mixin:APP:balm.mixins.json:MinecraftServerMixin from mod balm,pl:mixin:APP:missions-common.mixins.json:MinecraftServerMixin from mod missions,pl:mixin:APP:fastload.mixins.json:server.MinecraftServerMixin from mod fastload,pl:mixin:APP:mixins.simpleafk.json:MinecraftServerMixin from mod simpleafk,pl:mixin:APP:fabric-message-api-v1.mixins.json:MinecraftServerMixin from mod fabric_message_api_v1,pl:mixin:APP:citadel.mixins.json:MinecraftServerMixin from mod citadel,pl:mixin:APP:connectormod.mixins.json:registries.MinecraftServerMixin from mod connectormod,pl:mixin:APP:mixins.letmedespawn.json:MinecraftServerMixin from mod letmedespawn,pl:mixin:APP:fabric-lifecycle-events-v1.mixins.json:MinecraftServerMixin from mod fabric_lifecycle_events_v1,pl:mixin:APP:kubejs-common.mixins.json:MinecraftServerMixin from mod kubejs,pl:mixin:APP:kubejs-common.mixins.json:inject_resources.MinecraftServerMixin from mod kubejs,pl:mixin:APP:cobblegen.mixins.json:MinecraftServerMixin from mod cobblegen,pl:mixin:APP:fabric-resource-loader-v0.mixins.json:MinecraftServerMixin from mod fabric_resource_loader_v0,pl:mixin:APP:c2me-fixes-general-threading-issues.mixins.json:asynccatchers.MixinMinecraftServer from mod c2me_fixes_general_threading_issues,pl:mixin:APP:c2me-opts-scheduling.mixins.json:idle_tasks.autosave.enhanced_autosave.MixinMinecraftServer from mod c2me_opts_scheduling,pl:mixin:APP:c2me-opts-scheduling.mixins.json:mid_tick_chunk_tasks.MixinMinecraftServer from mod c2me_opts_scheduling,pl:mixin:APP:c2me-opts-scheduling.mixins.json:shutdown.MixinMinecraftServer from mod c2me_opts_scheduling,pl:mixin:APP:together.mixins.common.json:MinecraftServerMixin from mod bclib,pl:mixin:APP:together.mixins.common.json:MinecraftServerMixinLate from mod bclib,pl:mixin:A,pl:connector_pre_launch:A}
at net.minecraft.server.MinecraftServer.m_6367_(MinecraftServer.java:161) ~[server-1.20.1-20230612.114412-srg.jar%23467!/:?] {re:mixin,pl:accesstransformer:B,pl:connector_pre_launch:A,re:computing_frames,pl:accesstransformer:B,pl:connector_pre_launch:A,re:classloading,pl:accesstransformer:B,pl:mixin:APP:saturn.mixins.json:allocations.server_directory.MinecraftServerMixin from mod saturn,pl:mixin:APP:modernfix-common.mixins.json:perf.dedicated_reload_executor.MinecraftServerMixin from mod modernfix,pl:mixin:APP:modernfix-common.mixins.json:core.MinecraftServerMixin from mod modernfix,pl:mixin:APP:tcdcommons.mixin.events.json:MixinMinecraftServer from mod tcdcommons,pl:mixin:APP:balm.mixins.json:MinecraftServerMixin from mod balm,pl:mixin:APP:missions-common.mixins.json:MinecraftServerMixin from mod missions,pl:mixin:APP:fastload.mixins.json:server.MinecraftServerMixin from mod fastload,pl:mixin:APP:mixins.simpleafk.json:MinecraftServerMixin from mod simpleafk,pl:mixin:APP:fabric-message-api-v1.mixins.json:MinecraftServerMixin from mod fabric_message_api_v1,pl:mixin:APP:citadel.mixins.json:MinecraftServerMixin from mod citadel,pl:mixin:APP:connectormod.mixins.json:registries.MinecraftServerMixin from mod connectormod,pl:mixin:APP:mixins.letmedespawn.json:MinecraftServerMixin from mod letmedespawn,pl:mixin:APP:fabric-lifecycle-events-v1.mixins.json:MinecraftServerMixin from mod fabric_lifecycle_events_v1,pl:mixin:APP:kubejs-common.mixins.json:MinecraftServerMixin from mod kubejs,pl:mixin:APP:kubejs-common.mixins.json:inject_resources.MinecraftServerMixin from mod kubejs,pl:mixin:APP:cobblegen.mixins.json:MinecraftServerMixin from mod cobblegen,pl:mixin:APP:fabric-resource-loader-v0.mixins.json:MinecraftServerMixin from mod fabric_resource_loader_v0,pl:mixin:APP:c2me-fixes-general-threading-issues.mixins.json:asynccatchers.MixinMinecraftServer from mod c2me_fixes_general_threading_issues,pl:mixin:APP:c2me-opts-scheduling.mixins.json:idle_tasks.autosave.enhanced_autosave.MixinMinecraftServer from mod c2me_opts_scheduling,pl:mixin:APP:c2me-opts-scheduling.mixins.json:mid_tick_chunk_tasks.MixinMinecraftServer from mod c2me_opts_scheduling,pl:mixin:APP:c2me-opts-scheduling.mixins.json:shutdown.MixinMinecraftServer from mod c2me_opts_scheduling,pl:mixin:APP:together.mixins.common.json:MinecraftServerMixin from mod bclib,pl:mixin:APP:together.mixins.common.json:MinecraftServerMixinLate from mod bclib,pl:mixin:A,pl:connector_pre_launch:A}
at net.minecraft.util.thread.BlockableEventLoop.m_7245_(BlockableEventLoop.java:130) ~[server-1.20.1-20230612.114412-srg.jar%23467!/:?] {re:mixin,pl:accesstransformer:B,pl:connector_pre_launch:A,re:computing_frames,pl:accesstransformer:B,pl:connector_pre_launch:A,re:classloading,pl:accesstransformer:B,pl:mixin:APP:modernfix-common.mixins.json:perf.fix_loop_spin_waiting.BlockableEventLoopMixin from mod modernfix,pl:mixin:A,pl:connector_pre_launch:A}
at net.minecraft.server.MinecraftServer.m_129961_(MinecraftServer.java:753) ~[server-1.20.1-20230612.114412-srg.jar%23467!/:?] {re:mixin,pl:accesstransformer:B,pl:connector_pre_launch:A,re:computing_frames,pl:accesstransformer:B,pl:connector_pre_launch:A,re:classloading,pl:accesstransformer:B,pl:mixin:APP:saturn.mixins.json:allocations.server_directory.MinecraftServerMixin from mod saturn,pl:mixin:APP:modernfix-common.mixins.json:perf.dedicated_reload_executor.MinecraftServerMixin from mod modernfix,pl:mixin:APP:modernfix-common.mixins.json:core.MinecraftServerMixin from mod modernfix,pl:mixin:APP:tcdcommons.mixin.events.json:MixinMinecraftServer from mod tcdcommons,pl:mixin:APP:balm.mixins.json:MinecraftServerMixin from mod balm,pl:mixin:APP:missions-common.mixins.json:MinecraftServerMixin from mod missions,pl:mixin:APP:fastload.mixins.json:server.MinecraftServerMixin from mod fastload,pl:mixin:APP:mixins.simpleafk.json:MinecraftServerMixin from mod simpleafk,pl:mixin:APP:fabric-message-api-v1.mixins.json:MinecraftServerMixin from mod fabric_message_api_v1,pl:mixin:APP:citadel.mixins.json:MinecraftServerMixin from mod citadel,pl:mixin:APP:connectormod.mixins.json:registries.MinecraftServerMixin from mod connectormod,pl:mixin:APP:mixins.letmedespawn.json:MinecraftServerMixin from mod letmedespawn,pl:mixin:APP:fabric-lifecycle-events-v1.mixins.json:MinecraftServerMixin from mod fabric_lifecycle_events_v1,pl:mixin:APP:kubejs-common.mixins.json:MinecraftServerMixin from mod kubejs,pl:mixin:APP:kubejs-common.mixins.json:inject_resources.MinecraftServerMixin from mod kubejs,pl:mixin:APP:cobblegen.mixins.json:MinecraftServerMixin from mod cobblegen,pl:mixin:APP:fabric-resource-loader-v0.mixins.json:MinecraftServerMixin from mod fabric_resource_loader_v0,pl:mixin:APP:c2me-fixes-general-threading-issues.mixins.json:asynccatchers.MixinMinecraftServer from mod c2me_fixes_general_threading_issues,pl:mixin:APP:c2me-opts-scheduling.mixins.json:idle_tasks.autosave.enhanced_autosave.MixinMinecraftServer from mod c2me_opts_scheduling,pl:mixin:APP:c2me-opts-scheduling.mixins.json:mid_tick_chunk_tasks.MixinMinecraftServer from mod c2me_opts_scheduling,pl:mixin:APP:c2me-opts-scheduling.mixins.json:shutdown.MixinMinecraftServer from mod c2me_opts_scheduling,pl:mixin:APP:together.mixins.common.json:MinecraftServerMixin from mod bclib,pl:mixin:APP:together.mixins.common.json:MinecraftServerMixinLate from mod bclib,pl:mixin:A,pl:connector_pre_launch:A}
at net.minecraft.server.MinecraftServer.m_7245_(MinecraftServer.java:747) ~[server-1.20.1-20230612.114412-srg.jar%23467!/:?] {re:mixin,pl:accesstransformer:B,pl:connector_pre_launch:A,re:computing_frames,pl:accesstransformer:B,pl:connector_pre_launch:A,re:classloading,pl:accesstransformer:B,pl:mixin:APP:saturn.mixins.json:allocations.server_directory.MinecraftServerMixin from mod saturn,pl:mixin:APP:modernfix-common.mixins.json:perf.dedicated_reload_executor.MinecraftServerMixin from mod modernfix,pl:mixin:APP:modernfix-common.mixins.json:core.MinecraftServerMixin from mod modernfix,pl:mixin:APP:tcdcommons.mixin.events.json:MixinMinecraftServer from mod tcdcommons,pl:mixin:APP:balm.mixins.json:MinecraftServerMixin from mod balm,pl:mixin:APP:missions-common.mixins.json:MinecraftServerMixin from mod missions,pl:mixin:APP:fastload.mixins.json:server.MinecraftServerMixin from mod fastload,pl:mixin:APP:mixins.simpleafk.json:MinecraftServerMixin from mod simpleafk,pl:mixin:APP:fabric-message-api-v1.mixins.json:MinecraftServerMixin from mod fabric_message_api_v1,pl:mixin:APP:citadel.mixins.json:MinecraftServerMixin from mod citadel,pl:mixin:APP:connectormod.mixins.json:registries.MinecraftServerMixin from mod connectormod,pl:mixin:APP:mixins.letmedespawn.json:MinecraftServerMixin from mod letmedespawn,pl:mixin:APP:fabric-lifecycle-events-v1.mixins.json:MinecraftServerMixin from mod fabric_lifecycle_events_v1,pl:mixin:APP:kubejs-common.mixins.json:MinecraftServerMixin from mod kubejs,pl:mixin:APP:kubejs-common.mixins.json:inject_resources.MinecraftServerMixin from mod kubejs,pl:mixin:APP:cobblegen.mixins.json:MinecraftServerMixin from mod cobblegen,pl:mixin:APP:fabric-resource-loader-v0.mixins.json:MinecraftServerMixin from mod fabric_resource_loader_v0,pl:mixin:APP:c2me-fixes-general-threading-issues.mixins.json:asynccatchers.MixinMinecraftServer from mod c2me_fixes_general_threading_issues,pl:mixin:APP:c2me-opts-scheduling.mixins.json:idle_tasks.autosave.enhanced_autosave.MixinMinecraftServer from mod c2me_opts_scheduling,pl:mixin:APP:c2me-opts-scheduling.mixins.json:mid_tick_chunk_tasks.MixinMinecraftServer from mod c2me_opts_scheduling,pl:mixin:APP:c2me-opts-scheduling.mixins.json:shutdown.MixinMinecraftServer from mod c2me_opts_scheduling,pl:mixin:APP:together.mixins.common.json:MinecraftServerMixin from mod bclib,pl:mixin:APP:together.mixins.common.json:MinecraftServerMixinLate from mod bclib,pl:mixin:A,pl:connector_pre_launch:A}
at net.minecraft.util.thread.BlockableEventLoop.m_18699_(BlockableEventLoop.java:115) ~[server-1.20.1-20230612.114412-srg.jar%23467!/:?] {re:mixin,pl:accesstransformer:B,pl:connector_pre_launch:A,re:computing_frames,pl:accesstransformer:B,pl:connector_pre_launch:A,re:classloading,pl:accesstransformer:B,pl:mixin:APP:modernfix-common.mixins.json:perf.fix_loop_spin_waiting.BlockableEventLoopMixin from mod modernfix,pl:mixin:A,pl:connector_pre_launch:A}
at net.minecraft.server.MinecraftServer.m_130012_(MinecraftServer.java:732) ~[server-1.20.1-20230612.114412-srg.jar%23467!/:?] {re:mixin,pl:accesstransformer:B,pl:connector_pre_launch:A,re:computing_frames,pl:accesstransformer:B,pl:connector_pre_launch:A,re:classloading,pl:accesstransformer:B,pl:mixin:APP:saturn.mixins.json:allocations.server_directory.MinecraftServerMixin from mod saturn,pl:mixin:APP:modernfix-common.mixins.json:perf.dedicated_reload_executor.MinecraftServerMixin from mod modernfix,pl:mixin:APP:modernfix-common.mixins.json:core.MinecraftServerMixin from mod modernfix,pl:mixin:APP:tcdcommons.mixin.events.json:MixinMinecraftServer from mod tcdcommons,pl:mixin:APP:balm.mixins.json:MinecraftServerMixin from mod balm,pl:mixin:APP:missions-common.mixins.json:MinecraftServerMixin from mod missions,pl:mixin:APP:fastload.mixins.json:server.MinecraftServerMixin from mod fastload,pl:mixin:APP:mixins.simpleafk.json:MinecraftServerMixin from mod simpleafk,pl:mixin:APP:fabric-message-api-v1.mixins.json:MinecraftServerMixin from mod fabric_message_api_v1,pl:mixin:APP:citadel.mixins.json:MinecraftServerMixin from mod citadel,pl:mixin:APP:connectormod.mixins.json:registries.MinecraftServerMixin from mod connectormod,pl:mixin:APP:mixins.letmedespawn.json:MinecraftServerMixin from mod letmedespawn,pl:mixin:APP:fabric-lifecycle-events-v1.mixins.json:MinecraftServerMixin from mod fabric_lifecycle_events_v1,pl:mixin:APP:kubejs-common.mixins.json:MinecraftServerMixin from mod kubejs,pl:mixin:APP:kubejs-common.mixins.json:inject_resources.MinecraftServerMixin from mod kubejs,pl:mixin:APP:cobblegen.mixins.json:MinecraftServerMixin from mod cobblegen,pl:mixin:APP:fabric-resource-loader-v0.mixins.json:MinecraftServerMixin from mod fabric_resource_loader_v0,pl:mixin:APP:c2me-fixes-general-threading-issues.mixins.json:asynccatchers.MixinMinecraftServer from mod c2me_fixes_general_threading_issues,pl:mixin:APP:c2me-opts-scheduling.mixins.json:idle_tasks.autosave.enhanced_autosave.MixinMinecraftServer from mod c2me_opts_scheduling,pl:mixin:APP:c2me-opts-scheduling.mixins.json:mid_tick_chunk_tasks.MixinMinecraftServer from mod c2me_opts_scheduling,pl:mixin:APP:c2me-opts-scheduling.mixins.json:shutdown.MixinMinecraftServer from mod c2me_opts_scheduling,pl:mixin:APP:together.mixins.common.json:MinecraftServerMixin from mod bclib,pl:mixin:APP:together.mixins.common.json:MinecraftServerMixinLate from mod bclib,pl:mixin:A,pl:connector_pre_launch:A}
at net.minecraft.server.MinecraftServer.m_130011_(MinecraftServer.java:665) ~[server-1.20.1-20230612.114412-srg.jar%23467!/:?] {re:mixin,pl:accesstransformer:B,pl:connector_pre_launch:A,re:computing_frames,pl:accesstransformer:B,pl:connector_pre_launch:A,re:classloading,pl:accesstransformer:B,pl:mixin:APP:saturn.mixins.json:allocations.server_directory.MinecraftServerMixin from mod saturn,pl:mixin:APP:modernfix-common.mixins.json:perf.dedicated_reload_executor.MinecraftServerMixin from mod modernfix,pl:mixin:APP:modernfix-common.mixins.json:core.MinecraftServerMixin from mod modernfix,pl:mixin:APP:tcdcommons.mixin.events.json:MixinMinecraftServer from mod tcdcommons,pl:mixin:APP:balm.mixins.json:MinecraftServerMixin from mod balm,pl:mixin:APP:missions-common.mixins.json:MinecraftServerMixin from mod missions,pl:mixin:APP:fastload.mixins.json:server.MinecraftServerMixin from mod fastload,pl:mixin:APP:mixins.simpleafk.json:MinecraftServerMixin from mod simpleafk,pl:mixin:APP:fabric-message-api-v1.mixins.json:MinecraftServerMixin from mod fabric_message_api_v1,pl:mixin:APP:citadel.mixins.json:MinecraftServerMixin from mod citadel,pl:mixin:APP:connectormod.mixins.json:registries.MinecraftServerMixin from mod connectormod,pl:mixin:APP:mixins.letmedespawn.json:MinecraftServerMixin from mod letmedespawn,pl:mixin:APP:fabric-lifecycle-events-v1.mixins.json:MinecraftServerMixin from mod fabric_lifecycle_events_v1,pl:mixin:APP:kubejs-common.mixins.json:MinecraftServerMixin from mod kubejs,pl:mixin:APP:kubejs-common.mixins.json:inject_resources.MinecraftServerMixin from mod kubejs,pl:mixin:APP:cobblegen.mixins.json:MinecraftServerMixin from mod cobblegen,pl:mixin:APP:fabric-resource-loader-v0.mixins.json:MinecraftServerMixin from mod fabric_resource_loader_v0,pl:mixin:APP:c2me-fixes-general-threading-issues.mixins.json:asynccatchers.MixinMinecraftServer from mod c2me_fixes_general_threading_issues,pl:mixin:APP:c2me-opts-scheduling.mixins.json:idle_tasks.autosave.enhanced_autosave.MixinMinecraftServer from mod c2me_opts_scheduling,pl:mixin:APP:c2me-opts-scheduling.mixins.json:mid_tick_chunk_tasks.MixinMinecraftServer from mod c2me_opts_scheduling,pl:mixin:APP:c2me-opts-scheduling.mixins.json:shutdown.MixinMinecraftServer from mod c2me_opts_scheduling,pl:mixin:APP:together.mixins.common.json:MinecraftServerMixin from mod bclib,pl:mixin:APP:together.mixins.common.json:MinecraftServerMixinLate from mod bclib,pl:mixin:A,pl:connector_pre_launch:A}
at net.minecraft.server.MinecraftServer.m_206580_(MinecraftServer.java:251) ~[server-1.20.1-20230612.114412-srg.jar%23467!/:?] {re:mixin,pl:accesstransformer:B,pl:connector_pre_launch:A,re:computing_frames,pl:accesstransformer:B,pl:connector_pre_launch:A,re:classloading,pl:accesstransformer:B,pl:mixin:APP:saturn.mixins.json:allocations.server_directory.MinecraftServerMixin from mod saturn,pl:mixin:APP:modernfix-common.mixins.json:perf.dedicated_reload_executor.MinecraftServerMixin from mod modernfix,pl:mixin:APP:modernfix-common.mixins.json:core.MinecraftServerMixin from mod modernfix,pl:mixin:APP:tcdcommons.mixin.events.json:MixinMinecraftServer from mod tcdcommons,pl:mixin:APP:balm.mixins.json:MinecraftServerMixin from mod balm,pl:mixin:APP:missions-common.mixins.json:MinecraftServerMixin from mod missions,pl:mixin:APP:fastload.mixins.json:server.MinecraftServerMixin from mod fastload,pl:mixin:APP:mixins.simpleafk.json:MinecraftServerMixin from mod simpleafk,pl:mixin:APP:fabric-message-api-v1.mixins.json:MinecraftServerMixin from mod fabric_message_api_v1,pl:mixin:APP:citadel.mixins.json:MinecraftServerMixin from mod citadel,pl:mixin:APP:connectormod.mixins.json:registries.MinecraftServerMixin from mod connectormod,pl:mixin:APP:mixins.letmedespawn.json:MinecraftServerMixin from mod letmedespawn,pl:mixin:APP:fabric-lifecycle-events-v1.mixins.json:MinecraftServerMixin from mod fabric_lifecycle_events_v1,pl:mixin:APP:kubejs-common.mixins.json:MinecraftServerMixin from mod kubejs,pl:mixin:APP:kubejs-common.mixins.json:inject_resources.MinecraftServerMixin from mod kubejs,pl:mixin:APP:cobblegen.mixins.json:MinecraftServerMixin from mod cobblegen,pl:mixin:APP:fabric-resource-loader-v0.mixins.json:MinecraftServerMixin from mod fabric_resource_loader_v0,pl:mixin:APP:c2me-fixes-general-threading-issues.mixins.json:asynccatchers.MixinMinecraftServer from mod c2me_fixes_general_threading_issues,pl:mixin:APP:c2me-opts-scheduling.mixins.json:idle_tasks.autosave.enhanced_autosave.MixinMinecraftServer from mod c2me_opts_scheduling,pl:mixin:APP:c2me-opts-scheduling.mixins.json:mid_tick_chunk_tasks.MixinMinecraftServer from mod c2me_opts_scheduling,pl:mixin:APP:c2me-opts-scheduling.mixins.json:shutdown.MixinMinecraftServer from mod c2me_opts_scheduling,pl:mixin:APP:together.mixins.common.json:MinecraftServerMixin from mod bclib,pl:mixin:APP:together.mixins.common.json:MinecraftServerMixinLate from mod bclib,pl:mixin:A,pl:connector_pre_launch:A}
at java.lang.Thread.run(Unknown Source) ~[?:?] {re:mixin}
Mods that also generate in Treasure Chests
- Immersive Weathering
- Alex's Caves
- Mine Colonies
- End Remastered
Same issue with the same perfect plushie mod version.
In use is forge version 47.3.0
But no lootintegrations, is this a dependency from perfect plushies?
Same issue with the same perfect plushie mod version. In use is forge version 47.3.0 But no lootintegrations, is this a dependency from perfect plushies?
Empty loot tables do not happen by default so it could be a conflict with another mod.
Which other mods do you have installed on your instance with this issue?
Do you have a project page?
This error can also happen when only using the plushie mod.
I tested it in a development state without any changes.
We assume that the return value of the function getRandomElement in line 43 gives an Optional without a value.
Then when you want to get the data of the Optional Object with the function get it throws the exception NoSuchElementException.
To prevent it from exception throwing, make sure to check first with the function isPresent.
Thank you for your time.
Same issue with the same perfect plushie mod version. In use is forge version 47.3.0 But no lootintegrations, is this a dependency from perfect plushies?
Empty loot tables do not happen by default so it must be a conflict with another mod.
I can confirm this issue does happen and Perfect Plushies IS at fault.
My steps for reproduction:
- Install clean instance on forge 1.20.1
- Add only perfectplushies and geckolib
- Create fresh world
- Locate buried treasure
- After ~6 or 10 different buried treasures at some point one will be empty and the previously mentioned error appears in the console
After taking a look in the code my suggestion for a stupid quick fix in the villlagelootmodifier would be:
@Override
protected @NotNull ObjectArrayList<ItemStack> doApply(ObjectArrayList<ItemStack> generatedLoot, LootContext context) {
if (context.getRandom().nextFloat() < chance) {
TagEntry tagthing = plushies.get(context.getRandom().nextInt(plushies.size()));
Item item;
if (tagthing.isTag()) {
TagKey<Item> itemTag = TagKey.create(Registries.ITEM, tagthing.getId());
Optional<Item> optionalItem = ForgeRegistries.ITEMS.tags().getTag(itemTag).getRandomElement(context.getRandom());
if (optionalItem.isPresent()) {
item = optionalItem.get();
} else {
return generatedLoot;
}
} else {
item = ForgeRegistries.ITEMS.getValue(tagthing.getId());
}
generatedLoot.add(new ItemStack(item));
}
return generatedLoot;
}
For how/why this happens i dont know but i do have a suspicion but i know far too little to know about modding to be certain so my assessment could be entirely wrong.
In the 'BlockInit' class of the common classes you have the array:
public static List<RegistryObject<? extends Block>> plushieBlocks = new ArrayList<>();
That you use to store all plushieBlocks for later use as far as i can tell. You enter all of these plushies except for the 'dumbo_blob_plushie' which gets registered via its own function 'registerCustomItemPlushie':
public static <T extends Block> RegistryObject<T> registerCustomItemPlushie(String name, Supplier<T> customPlushieBlock, Function<RegistryObject<T>, Supplier<? extends BlockItem>> item) {
var block = BLOCKS.register(name, customPlushieBlock);
ItemInit.ITEMS.register(name, () -> item.apply(block).get());
//plushieBlocks.add(block);
return block;
}
There you register the plsuhie in the ItemInit.ITEMS and add it to the total of all plushie items, however you do not add it to the plushieBlock
Later on the plushieBlocks list gets used in the 'ModTagProvier' in the forge side in:
@Override
protected void addTags(HolderLookup.Provider pProvider) {
populateTag(PlushieTags.VILLAGE_PLUSHIES_ITEMS,
BlockInit.plushieBlocks.toArray(new RegistryObject[0])
);
populateTag(PlushieTags.TREASURE_PLUSHIES_ITEMS,
BlockInit.playerBlocksCommon.toArray(new RegistryObject[0])
);
populateTag(PlushieTags.RARE_TREASURE_PLUSHIES_ITEMS,
BlockInit.playerBlocksRare.toArray(new RegistryObject[0])
);
populateTag(PlushieTags.EPIC_TREASURE_PLUSHIES_ITEMS,
BlockInit.playerBlocksEpic.toArray(new RegistryObject[0])
);
populateTag(PlushieTags.RARE_VILLAGE_PLUSHIES_ITEMS, BlockInit.DUMBO_BLOB_PLUSHIE::get);
}
So here all of the plushies except for the dumbo blob plushie gets added to the village plushies items. But the dumbo blob plushies is still in the list of all items registered. Later on in the villagelootmodifier when we ask for:
TagEntry tagthing = plushies.get(context.getRandom().nextInt(plushies.size()));
We ask for all plushies with plushies.size which as far as i can tell includes the dumbo blob plushie. Then after that the function asks for the tag of it, which didnt get addedto the villageplushies tags because it was not in the plushiesBlocks array.
MAYBE this or something similar to this could be the issue?
@SirJain0 is it okay when we make an own fork of your mod.
We have to ask, because you have no licensing on this project and with this we are not allowed to change it.
You can also provide a license for this project.
