Pet Owner

Pet Owner

Mods
360k Downloads

Pet owner name is fetched on renderer thread, freezing the client when hovering a new pet

Scotsguy opened this issue ยท 1 comments

commented

PetOwner/src/main/java/us/potatoboy/petowner/mixin/OwnerNameTagRendering.java

Line 50 in 7df6d2e

String usernameString = PetOwnerClient.getNameFromId(ownerId);

Takes however long it takes to fetch a profile from Mojang, usually 0.5-1 seconds. That's an unacceptably long freeze.
Please offload fetching the profile to another thread and show a "please wait" message, or nothing at all, until that's done.

commented

Yeah I know... Its just annoying using yggdrasil because there isn't a way that I've found to check if the name is in the cache. I suppose I'll have to cache the cache or something. I'll work on this.