End's Phantasm

End's Phantasm

8M Downloads

AoF7 players reporting empty value for "elytra_boost_advancement" does *not* re-enable vanilla elytra boost behavior for all players

SubordinalBlue opened this issue ยท 6 comments

commented

In AoF7, we've pushed out an update to set "elytra_boost_advancement" to "".

Now getting reports this is not working as intended.

In the second link, from AOE discord, the player reports that their server console prints the following when trying to rocket boost elytra:

[Server thread/ERROR]: Failed to handle packet net.minecraft.class_2886@4cab1a4b, suppressing error
java.lang.NullPointerException: null
commented

seems to be caused by

if (player.getAdvancementTracker().getProgress(freetheend).isDone() && player.isFallFlying()) {

getAdvancementLoader().get(new Identifier("")) will never find an Advancement. at best case freetheend is null after this
getProgress(freetheend) will throw a NPE from the map lookup this.progress.get(advancement) due to the null key

commented

This is an issue indeed, sorry for it
I'm changing it rn so that if the advancement can't be found, it considers boosting as allowed no matter what
The fixed version will be released in a few days, i have a few others things to modify
In the meantime, setting this value to an early game advancement like "minecraft:story/root" should allow elytras from the ground up without causing crashes

commented

Just wanna say, thank you!
A reply with details and a work-around for the immediate time being: ๐Ÿ‘

commented

You're welcome, thank you for reporting it!

commented

<small, polite bump>

commented

Just published the fixed version!
https://modrinth.com/mod/ends-phantasm
Sorry for the wait, let me know if you find any other issue ^^