Plasmo Voice

Plasmo Voice

Mods
2M Downloads

Placeholders bug

NyaomiDEV opened this issue ยท 8 comments

commented

plasmo-voice/server/paper/src/main/kotlin/su/plo/voice/paper/integration/VoicePlaceholder.kt

Lines 32 to 44 in aa1610b

when(params.lowercase()) {
"installed" -> voicePlayer.hasVoiceChat().toString()
"hasVoiceChat" -> voicePlayer.hasVoiceChat().toString()
"muted" -> voiceServer.muteManager.getMute(player.uniqueId).isPresent.toString()
"microphoneMuted" -> (voicePlayer.hasVoiceChat() && voicePlayer.isMicrophoneMuted).toString()
"voiceDisabled" -> (voicePlayer.hasVoiceChat() && voicePlayer.isVoiceDisabled).toString()
else -> null
}

How can the camelCase params ever be displayed if you convert them to lowercase before checking?

commented

plasmo-voice/api/server-common/src/main/java/su/plo/voice/api/server/player/VoicePlayer.java

Lines 33 to 41 in b071af7

/**
* @return true if player has disabled the voice chat
*/
boolean isVoiceDisabled();
/**
* @return true if player has muted the microphone in voice chat
*/
boolean isMicrophoneMuted();

plasmo-voice/server/paper/src/main/kotlin/su/plo/voice/paper/integration/VoicePlaceholder.kt

Lines 39 to 41 in b071af7

"microphoneMuted" -> (voicePlayer.hasVoiceChat() && voicePlayer.isMicrophoneMuted).toString()
"voiceDisabled" -> (voicePlayer.hasVoiceChat() && voicePlayer.isVoiceDisabled).toString()

Another bug I spotted is that those probably are supposed to be function calls.

commented

In kotlin, Java methods with prefix is or get can be accessed as kotlin properties

commented

In kotlin, Java methods with prefix is or get can be accessed as kotlin properties

Oh, I did not know that. I assumed that because, in my testing, both placeholders return false even when the user has their mic muted or has voice disabled.

Probably the issue is somewhere else, then.

commented

Should be fixed by 788bd5e

commented

Should be fixed by 788bd5e

I offer myself to test it quickly, if you have a jar file to send my way.

commented

https://github.com/plasmoapp/plasmo-voice/releases/download/2.0.3/PlasmoVoice-Paper-2.0.3.jar

It only updates upon join. Subsequent updates don't come through IF DONE VIA HOTKEYS. Toggling in the Plasmo Config section goes through 99% of the times.

commented

https://github.com/plasmoapp/plasmo-voice/releases/download/2.0.3/PlasmoVoice-Paper-2.0.3.jar

It only updates upon join. Subsequent updates don't come through IF DONE VIA HOTKEYS. Toggling in the Plasmo Config section goes through 99% of the times.

Fixed by eb11b40