PlayerEx: Directors Cut

PlayerEx: Directors Cut

18.4k Downloads

[Bug] (forge 1.20.1) Weapons becomes "Broken" upon first use

AndyNoob opened this issue · 0 comments

commented

What happened? Describe in detail down below and include the mod version as well.

Essentially is what the title says. Attached is a demonstration in a "clean" modpack.
Forge: 47.3.0 (the recommended)
Modlist:

Screen.Recording.2024-11-06.at.8.11.01.PM.mov

What mod loaders is this problem occuring on?

Forge

What do you think this bug is related to?

  • Visual
  • Feature Related
  • Crash
  • Mod Conflict
  • Others

Relevant logs

https://mclo.gs/JzowoIM

Anything else?

I installed the mods through Prism Launcher's download mod feature (and all the mods are on what it determined "latest"), which seems to not give a crap about mod dependencies if the mod loader isn't the same as the instance, so maybe I missed a dependency?

Also, I decided to dig into the source code and discovered that the mixin target that adds the broken tag targets the invocation of the ItemStack#getItem method, which on forge gets invoked twice:
Screenshot 2024-11-06 at 8 28 22 PM
Once before the item actually gets damaged to do their own damage amount modification.

By submitting this issue, I have confirmed I have followed all instructions and all my mods are up-to-date.

  • Yes