kinetic augment .use(duration, hand) does not respect left handedness
hugeblank opened this issue ยท 7 comments
- Change your main hand from right to left in options -> skin customization -> main hand
- Hold a pocket computer in offhand (right).
- Create a script that sleeps for a moment, then runs
back.use(nil, "right")
- Notice how it does nothing, try again, this time with
back.use(nil, "left")
. It will work amid the pocket computer being in the right hand.
When using "main"/"off" the correct hand is used. This issue occurs purely because it's incorrect to assume that the main hand is the "right" hand in ArgumentExt.kt:87
- damn this is a big necro
- I feel that at this point, correcting this issue may possibly be a breaking change considering that some people may be specifically using "right" for the main hand
- not really, it's only been 3 and a bit months.
- Just checked because I also was curious of this. On SC there are 0 cases of the
.use
method with "left"/"right" strings. Obviously this isn't explicit proof, but it leads me to believe that it won't be as major of a "breaking change" as you suggest.
realistically this should just be a boolean value anyways, false/nil = main hand, true = offhand
My testing was done in a single player world. As for where I got the left/right from: https://plethora.madefor.cc/methods.html#org.squiddev.plethora.integration.vanilla.method.MethodsKineticActions-use(IModuleContainer)
I'll get back to you tomorrow on if the issue can be repeated on the SP world after a restart, as well as on the server