Plethora Peripherals

Plethora Peripherals

3M Downloads

Sideways manipulators not accepting modules

Kan18 opened this issue ยท 2 comments

commented

Manipulators placed in a regular orientation work fine. However, manipulators that are sideways do not accept modules.
(alternate video link: https://cdn.discordapp.com/attachments/1057706496579883088/1064175642293321888/manipulator_sideways.mp4)

manipulator_sideways.mp4
commented

I believe this was updated wrong from 1.19.2 to 1.19.3 when the math lib changed

public Box[] boxesFor(Direction facing) {
Box[] cached = facingBoxes[facing.ordinal()];
if (cached != null) return cached;
Matrix4f m = MatrixHelpers.matrixFor(facing);
cached = new Box[boxes.length];
for (int i = 0; i < boxes.length; i++) cached[i] = MatrixHelpers.transform(boxes[i], m);
return facingBoxes[facing.ordinal()] = cached;
}

On a similar note, when this is fixed, the outline renderer only shows the glowing white quad for the down facing, which is something I should be able to fix here too

commented

I think now that sc-library has a set of Box utilities (used for 3d prints mainly), the Manipulator box methods should be rewritten to use those.