Pling

Mods
2M Downloads

Only sound events can be used as loading sounds

haykam821 opened this issue ยท 0 comments

commented

While loading sounds are defined as stringified identifiers in the configuration, they are parsed into an identifier that is used to look up a sound event in the registry:

Pling/src/main/java/io/github/haykam821/pling/Pling.java

Lines 52 to 60 in 64d31d8

public static SoundEvent getLoadingSound() {
try {
Identifier soundId = new Identifier(CONFIG.sound);
return Registries.SOUND_EVENT.get(soundId);
} catch (InvalidIdentifierException exception) {
LOGGER.warn("Invalid loading sound event ID: '{}'", CONFIG.sound);
return null;
}
}

However, this strategy causes sounds defined in the sounds.json file of a resource pack to not be usable as loading sounds, as these sounds are client-only and not added to the sound event registry.