Refer'd Issue:
Tslat/Advent-Of-Ascension#1604

Minecraft: 1.12.2
Forge: 14.23.5.2854

Mods: 7
ActuallyAdditions-1.12.2-r151-2
AoA3-3.3
jei_1.12.2-4.15.0.291
Mantle-1.12-1.3.3.55
natura-1.12.2-4.3.2.69
*plustic-8.0.1.0
TConstruct-1.12.2-2.13.0.183

=====

In a modded survival world that I play on, I was messing around with the traits that AoA added such as 'Runic' and noticed that certain traits when paired with Runic don't seem to work correctly.

PlusTiC, or xXx_MoreToolMats_xXx as it's called in the fork adds in usable materials & traits depending on the mods you have installed... in this case, I have have what's added in the list above in order to gain access to the listed traits & materials.

The 'Hearts' trait can only be gotten from Restonia Crystals if Actually Additions is installed. It grants a damage boost depending on your health so if you have 100% health, you'll deal up to +70% more Damage.

The 'Bloody Mary' trait can be gotten from either Natura's Bloodwood, or Thermal Foundation's signalum. You deal extra damage depending on the mob's remaining health.

Now then... I'm using a Tinkers Scythe Tool since it has 1 Head part that affects damage while the other 3 parts affects durability & such. It's Head Material is Magma Slime which gives 6.25 damage & by using 3x Sharp Modifiers... it brings it's damage to 10.69.

For these tests I am slaying an Iron Golem as it has 100 health and it doesn't KO you when on Peaceful. I will only list the traits that are on the tool but the Head Part will always be Magma Slime as well as having 3x Sharp Modifiers. My Health is at 20/20 aka 100% in order to make use for the full damage buff from 'Hearts'.

'Superheat' will only deal bonus damage if the target was on fire, but in these tests the target is never on fire so the trait does nothing. 'Lightweight' only increases Break Speed & Attack Speed and 'Ecological' very slowly repairs the tool by 1 point.

I also disabled skills so the 'Butchery' Skill doesn't add in extra damage when it procs. Finally... using ToroHUD in order to view the mob's health as well as show damage particles.

Test 1
Traits: Superheat, Lightweight

Damage Dealt: 11

Test 2
Traits: Superheat, Lightweight, Hearts

Damage Dealt: 18

Test 3
Traits: Superheat, Lightweight, Bloody Mary & Ecological

Damage Dealt: 11, 15, 17, 20, 22, 24

Test 4
Traits: Superheat, Lightweight, Hearts, Bloody Mary & Ecological

Damage Dealt: 18, 23, 26, 29, 31

=====

Now for these upcoming tests, same as before however the 'Runic' trait is added into the mix which is from Elecanium. The nice thing with ToroHUD is that it can show you the 'split' damage when Runic converts some of the the damage into Magic Damage.

Runic converts 10% of the damage into Magic Damage. Up to 30% if you have Runic III. I only had Rank 1 of the Runic Trait so that's only 10% of the damage converted.

Test 1
Traits: Superheat, Lightweight, Runic

Damage Dealt: 10
Particle shows 9 & 1

Test 2
Traits: Superheat, Lightweight, Runic, Hearts

Damage Dealt: 10
Particle shows 9 & 1

Test 3
Traits: Superheat, Lightweight, Runic, Bloody Mary & Ecological

Damage Dealt: 10
Particle shows 9 & 1

Test 4
Traits: Superheat, Runic, Hearts, Bloody Mary & Ecological

Damage Dealt: 10
Particle shows 9 & 1

=====

I've tried with vanilla Tinker traits such as 'Prickly' which appears to give an extra 1 damage sometimes and Runic doesn't seem to conflict with that. It's perhaps due to the way that Hearts & Bloody Mary work but still figure I give it a mention.

The 'Spades' Trait is also effected where it's damage boost won't work if you have the Runic trait. Spades trait which is from Palis Crystals via Actually Additions increases your damage the lower your health is.

Morgan Le Fay Trait works as it should but that might be that it's bonus damage & not directly affecting base damage.