PMMO and NBT Compat

PMMO and NBT Compat

101k Downloads

Weapon Req NBT not working

WessTheWise opened this issue ยท 17 comments

commented

req_weapon_nbt.txt

So our req_tool_nbt works perfectly fine with tetra but the req_weapon_nbt one is not.

commented

We are using Project_MMO-1.16.5-3.67.6

commented

that should work. the sword should have combat 20 as it's level. The Json is valid. what version of PMMO are you using?

commented

Then something in the paths is not correct. if you do /nbtprint on the weapon, what do you get?

commented

image

commented

No worries. i'm glad it was sorted out. For my own curiosity, do you know what the issue was?

commented

Yeah, my req_weapon was invalid, now non-modular items work fine.

Does that mean your NBT settings work too?

So... I am sorry for the troubles. I re-rechecked everything in the req_weapon_nbt config and rewrote some stuff regarding Tetra from scratch. All works perfectly fine now. Some lessons have also been learned, like actualy using my own brain to fix the issue first.
req_weapon_nbt.txt
Here's the working config. The balancing is made for my own modpack though.
Once again, I'm sincerely sorry for the troubles.

commented

No worries. i'm glad it was sorted out. For my own curiosity, do you know what the issue was?

As it turned out, Tetra has some inconsistecies with paths for modular_double items. The main difference is the word "basic". Example: "double/basic_axe_left_material" but "double/hoe_left_material".
Also one of the "double" has way less usable materials (hammers cannot be golden nor diamond).
All it took is just look closely into items' nbts and remove unneeded words and lines.

commented

That's good to know. Thank you!

commented

Having the same issue. The combat requirements do change, but they're different from what they should be.
req_weapon_nbt.txt
image
Example is this. The sickle has combat 76 requirement for some reason. Do I have to state all the warforged requirements as well?
Everything else from Tetra seems to work fine, only tetra:modular_double is being weird, or me.

commented

Okay, I will try and look into this. I'm hoping it's not a pmmo, bug too, but at least now i'm the maintainer for PMMO so i can fix it if it is.

commented

A little update on the issue: seems like PMMOs' req_weapon config has the similar issue: config has one req, game has the other.
Config:
image
In-game:
image

As for the requirements for some of Tetra stuff, found out you can just disable said requirements for modular weapons in PMMO config in game. The other funny thing with this, it only disables the weird stuff (tetra:modular_double).
Dynamic weapon req enabled:
image
image
Dynamic weapon req disabled:
image
image

No idea if this would help but oh well

commented

Usually a dynamic req replacing a static req is due to a syntax error in the config. Double check that your req_weapon is a valid json. If it is, then something is really wrong with weapon reqs and I'm not sure ehow nobody noticed to this point.

commented

Yeah, my req_weapon was invalid, now non-modular items work fine.

commented

Yeah, my req_weapon was invalid, now non-modular items work fine.

Does that mean your NBT settings work too?

commented

Yeah, my req_weapon was invalid, now non-modular items work fine.

Does that mean your NBT settings work too?

Unfortunately not.

commented

okay, so we have the req_weapon.json working, that file has no reference to a tetra item, but our nbt req weapon json does, and we are still getting dynamic values unless dynamic values are turned off, in which case we have no req. is that correct?

commented

okay, so we have the req_weapon.json working, that file has no reference to a tetra item, but our nbt req weapon json does, and we are still getting dynamic values unless dynamic values are turned off, in which case we have no req. is that correct?

Well yes but actually no? It only happens to tetra:modular_double items. When dynamic values are enabled, they completely ignore whatever req is in the config and use dynamic, while the others (tetra:modular_single, tetra:modular_crossbow, tetra:modular_bow, tetra:modular_sword) DO use config requirements. When dynamic values are disabled though, only tetra:modular_double items actually get affected and no longer have weapon req at all (they still seem to have req of 1, because the "weapon" in their description is not gone), while the others still work fine.

It looks like the tetra:modular_double isn't in config at all, yet it's there and everything seems good.
I'm saying only tetra beacuse I haven't tested it with tinkers or silent gear.
Oh yeah, req_weapon.json is working fine, all good there.