PneumaticCraft: Repressurized

PneumaticCraft: Repressurized

50M Downloads

Oil Lake Generation Filtering by Biome datapack not working

dr3ams opened this issue ยท 1 comments

commented

Describe the bug

Created a datapack in location, decided to tweak oil lake gen
(was loading recipes before and they're working fine)
\config\paxi\datapacks\litiv2-datapack\data\pneumaticcraft\tags\worldgen\biome\has_surface_oil_lakes.json

that contain only:

{
  "values": [
    "#minecraft:savanna"
  ]
}

And can't find any oil lakes in savanna. This was tested with default world gen, with no added mods.
With my file: (completely no oil lakes, but they should generate only in savanna)
2023-11-01_09 35 45

Without: (you can see oil lakes, even in savanna biome)
2023-11-01_09 39 34

How to reproduce the bug

Try to create datapack that limits oil lake gen to certain biomes

\config\paxi\datapacks\litiv2-datapack\data\pneumaticcraft\tags\worldgen\biome\has_surface_oil_lakes.json

{
  "values": [
    "#minecraft:savanna"
  ]
}

Expected behavior

Oil lakes to generate only in specified biome (savanna)

Additional details

forge 47.2.1

Which Minecraft version are you using?

1.20

Which version of PneumaticCraft: Repressurized are you using?

6.0.9

Crash log

No response

commented

#savanna isn't a valid biome tag. I think you meant to use #is_savanna here.

Valid vanilla biome tag list can be found here: https://minecraft.wiki/w/Tag#Biomes