Network protocol error when putting upgrades into peumatc helmet
Gaz492 opened this issue ยท 2 comments
Describe the bug
When shift clicking 6 or more item life upgrades into a pneumatic helmet you will be kicked from the game with the message Network protocol error
How to reproduce the bug
- Put pneumatic helmet into charging station
- Open upgrades screen
- Shift click 6 or more item life upgrades into the upgrades slot
Expected behavior
To not be disconnected from singleplayer/server
Additional details
I was only able to make this happen when the mod Inventory Essentials was installed (https://www.curseforge.com/minecraft/mc-mods/inventory-essentials) so I'm not entirely sure if it's PNCs fault
Original issue reported at FTBTeam/FTB-Modpack-Issues#6927 but also tested with only the following mods installed
- architectury-13.0.8-neoforge.jar
- balm-neoforge-1.21.1-21.0.30.jar
- ftb-library-neoforge-2101.1.9.jar
- inventoryessentials-neoforge-1.21.1-21.1.2.jar
- jei-1.21.1-neoforge-19.21.0.247.jar
- kuma-api-neoforge-21.0.5-SNAPSHOT.jar
- pneumaticcraft-repressurized-8.2.9+mc1.21.1.jar
Which Minecraft version are you using?
1.21
Which version of PneumaticCraft: Repressurized are you using?
8.2.9
Crash log
https://gist.github.com/Gaz492/159f35801e42746bf2167df667b3d315
I can't reproduce this, either in dev or on a test dedicated server. With PNC 8.2.9, and Inv Essentials 21.1.2, shift clicking a full stack of item life upgrades into the helmet just moves 5 upgrades, as expected. So not sure what's triggering it for you.
However, I'll some extra defensive code in the calculations there to avoid this exception in future.