PneumaticCraft: Repressurized

PneumaticCraft: Repressurized

57M Downloads

[1.20.1] Apotheosis Winged affix (elytra) doesn't work with Pneumatic armor

SanjivanM opened this issue ยท 2 comments

commented

Describe the bug

Apotheosis' "Winged" affix (applied on chestplates) essentially allows you to use Elytra as if you had Elytra equipped.

What I expect to happen: The affix should function normally on Pneumatic armor.

What happens: You fall down.

How to reproduce the bug

Steps to reproduce:

  1. Start with 2 chestplates, 1 Pneumatic Chestplate, and another Chestplate (I used Diamond)
  2. Set the rarity on both chestplates. With the item selected in your hand, run /apoth set_rarity apotheosis:mythic
  3. Apply the "Winged" affix to both. Select each item as before, then run /apoth affix apply apotheosis:armor/attribute/winged 1

Expected behavior

Elytra should work normally

Additional details

Video comparison of both scenarios I described above
This instance was only using Pneumaticcraft: Repressurized, Apotheosis, and their required dependencies

https://drive.google.com/file/d/1Uk--cRIkSB35-e8unv880-6r4pVDLTbR/view?usp=sharing

Which Minecraft version are you using?

1.20.1

Which version of PneumaticCraft: Repressurized are you using?

6.0.20

Crash log

No response

commented

After some poking around, I think a fix would involve adding a check to PneumaticArmorItem#canElytraFly to check if Apotheosis is installed, and if it is, get if the chestplate has the Winged affix (accessible via the NBT tags on the item), and if it does, to just return true.

I tried to setup the code on my PC to test, but couldn't get it to work correctly, Eclipse kept complaining about line 33 of build.gradle ๐Ÿ’€

commented

It's actually simpler than explicitly checking for Apotheosis - it's enough just to check the super methods for canElytraFly() and elytraFlightTick(), since Apotheosis overrides both of those.

Will be fixed in next releases for 1.20 and 1.21.