PneumaticCraft: Repressurized

PneumaticCraft: Repressurized

50M Downloads

[JEI] Issue / Crash

artdude543 opened this issue ยท 4 comments

commented

Minecraft Version

1.12.2

Forge Version

14.23.3.2669

Mod Version

0.6.0-174
JEI Ver: 4.9.1.165

Describe your problem, including steps to reproduce it

Working on the next major update to SevTech: Ages and with the latest update, something is up/broken with the Liquid hopper (a broken recipe or something) in turn this issue causes a crash when you try to view the recipe. Along with breaking internals of JEI (Which I think is another bug on top of this one) I.E. Recipe/Item hiding breaks due to this issue; downgrading this mod to 0.5.1-163 resolves the recipe error from JEI.

Log/s

Crash Log / JEI Log: https://gist.github.com/artdude543/8fd07e29dbfcb615494e45090f0bd63b

commented

@mezz want me to report this on your tracker also? As I don't think this should break your entire start phase for JEI itself. As this stops the item hiding from continuing/loading also when the broken recipe error gets thrown out.

commented

Hmm it's probably related to this commit: d5a9b6f

commented

Okay, you can grab a fix here: http://jenkins.k-4u.nl/view/Desht/job/PneumaticCraft-Repressurized/176/
The same build is under review on curse, which should be approved soon, to put in the pack if you'd like.

@mezz I wouldn't mind either way what you do about this (adding a null check or not), while it isn't said explicitly in getTankProperties, you could say it should be a non nullable return value "Returns an array of objects which represent the internal tanks."

commented

I'm looking into this and I don't think it's breaking JEI that badly. There have been issues lately with hiding items and recipes and I've been making fixes, but it's probably unrelated to this.
I will log an error if I get null for IFluidTankProperties but otherwise I think things should be fine.