PneumaticCraft: Repressurized

PneumaticCraft: Repressurized

Mods
50M Downloads

Crash Shortly after Server Startup Due To ConcurrentModificationException on a HashMap

john01dav opened this issue ยท 4 comments

commented

Minecraft Version

1.12.2

Forge Version

1.12.2-14.23.4.2709-universal

Mod Version

0.6.8-219 (Direwolf20 1.12 pack)

Describe your problem, including steps to reproduce it

This crash occurred on a public server running the Direwolf20 1.12 pack. The crash log is here. After talking to the players who were online at the time of the crash, the only lead is this quote from a player "of note, there is an issue on the pneumaticraft github about shulkers and a helmet. No response yet, but I did JUST leave the end fighting a bunch of shulkers prior to the restart. May have picked up a helmet, but no idea
"

Any other comments?

The map file is available to a confirmed developer of Pneumaticraft, as long as they agree to not distribute it outside of the Pneumaticraft developers.

commented

This is a crash hard to track down, by nature. By following the traces I can't see a place where this semiBlocks collection (which is at the core of this problem) is modified on another thread or within the .forEach.

The only thing I can think of is another mod loading chunks off-thread, which would explain why it happens shortly after server startup, as chunks are more likely to load at startup increasing the chance of this crash to occur. I have put a fix for this in place, try http://jenkins.k-4u.nl/view/Desht/job/PneumaticCraft-Repressurized/249/
I hope you could reproduce this crash consistently enough, to know if this actually fixes your problem. Thank you in advance for your feedback :)

commented

Just to note this is certainly not shulker related - that issue is just a reminder to add shulker hacking at some point in the future.

commented

Closing since this is in the 0.7.6 release. Please reopen if the problem reoccurs.

commented

Hello, a server I'm playing on is currently in a crash-on-startup loop due to a very similar exception arising from the same area in the code.

Here is the stacktrace: https://pastebin.com/WjgZ1Z1m

If this is found to be the same problem, can I re-open this?

Edit: it happens inconsistently, which leads me to believe it might be due to another mod loading chunks with semiblocks in them inconsistently