PneumaticCraft: Repressurized

PneumaticCraft: Repressurized

50M Downloads

Drone is Ticked by server when killing Mobs

Seaniau opened this issue · 3 comments

commented

For feature requests, just erase this template and clearly describe the feature you'd like to see

Minecraft Version

1.12.2

Forge Version

14.23.4.2715

Mod Version

All The Mods 3 - 5.9.8d

Describe your problem, including steps to reproduce it

Using Drone program: https://pastebin.com/xDnReV6Z
(Edited to change Diamond Sword for Gun Ammo.)
Using Remote layout: https://pastebin.com/3SimGbvP
Server Error: https://pastebin.com/YN0Lyweb

Drone is wielding a Minigun using the Entity Tracker upgrade. When the Drone attacks a mob, it is able to reduce it's health until the mob dies, at which point the Drone disappears, leaving no items.

The server shows an error, indicating the Drone has been ticked. All I can make out is that it has detected an Entity killing an Entity. But I can't work out why this has caused an error?

I tested this same setup in a Single-player local server and it allowed the killings without issue.

Any other comments?

commented

This is a bug in Woot, not PNC:R, at https://github.com/Ipsis/Woot/blob/1_12/src/main/java/ipsis/woot/event/HandlerLivingDeathEvent.java#L77

The findPrism() method is assuming the entity has a full-size inventory, which is not necessarily the case for a drone's fake player. The method should be checking the number of slots the drone's inventory has and not assuming it has at least 9.

You should be able to work around this in the short term by adding 8 dispenser upgrades to your drone, giving it a 9-slot inventory, but this should be reported to the Woot maintainers.

commented
commented

OK :) Closing this now, nothing else to be done on the PNC:R side.