PneumaticCraft: Repressurized

PneumaticCraft: Repressurized

50M Downloads

Logistic Drones losing items

Golrith opened this issue ยท 14 comments

commented

Minecraft Version

12.2

Forge Version

14.23.4.2760

Mod Version

pneumaticcraft-repressurized-1.12.2-0.7.8-259

Describe your problem, including steps to reproduce it

When using the Requester Frame, drones take an entire stack, but only deliver what is Requested, the rest of the stack will vanish.

Any other comments?

commented

Very simple basic setup

  • The requester is asking for 4 Mekanism Basic circuits, and 1 Mekanism Advanced Circuit (same item ID, different metas)
  • I've tried both an Active Provider (Purple) and Storage (Yellow) with both the same results.
  • The supplier inventory is empty, and I place a stack of each circuit in the inventory.
  • Suppliers have no filter
commented

lol, good timing!

commented

Actually, don't worry; I can reproduce the problem.

commented

Can I get a bit more information on your setup:

  • What is in your requester frame filter, and how many items?
  • What type of logistics frame (active provider/passive provider/storage/default storage) is supplying the items to the requester?
  • How many items of that type were in the supplying frame's inventory?
  • Does the supplying frame have a filter configured?
commented

OK, I thought I could reproduce it, but turns out I had another nearby chest with a storage frame that I'd forgotten about. The stack I thought had gone missing was actually in there.

Been trying for a while to reproduce the missing items problem, and I can't:

  • Chest with Active Provider, no filter
  • Chest with Requester, requesting 8 x dirt
  • Put a stack of dirt in the Provider
  • Drone moves 8 dirt to the Requester, leaving 56 in the Provider

I can't get the drone to misbehave like you described at all, unfortunately. I do need to ask, are you certain there wasn't another Storage chest nearby that the drone moved stuff to?

commented

Odd. I'll do some further testing. I definitely saw the drone only move from the supplier to the requester and somehow the rest of the stack vanished.

commented

Yeah, if it's possible to make a video of it going wrong, that would be ideal. I'll do some more testing this end too, it's possible you've triggered some kind of corner case.

commented

I've found a clue to the issue. I didn't mention I wasn't using vanilla chests, not thinking that the type of inventory would make any difference.

Vanilla Chest to Vanilla Chest, everything works perfectly.
Using any Chest from the Metals Chest mod, results in the remainder of the stack vanishing.

As a further experiment, I made a vanilla chest the provider, and a diamond chest the requester, but the drone would not take from the vanilla chest and put in the diamond. I then added another vanilla chest with a yellow storage frame, and the drone happily moved all the items over to this chest.

So, either something wrong with MetalChests chests, or how the frames interact with non vanilla chests?

If I put the requester on an Advanced Rocketry input Hatch, everything also transfers correctly from the vanilla chest, so it's the provider/storage on non-vanilla chests that is going wrong somewhere.

Unfortunately my mod pack is limited on chests, so I can't test any other non-vanilla chests.

commented

That's very interesting for sure. The type of inventory shouldn't matter - we just use regular Forge capabilities - so I'll do some more testing with non-vanilla inventories.

commented

I do believe I've discovered the bug - it only happens with certain inventories, which is why I had trouble tracking it down (vanilla chests, iron chests, IE crates worked fine, but AE2 skystone chests didn't).

Anyway, could you give build 260 from http://jenkins.k-4u.nl/job/PneumaticCraft-Repressurized/ a go please and let me know if it resolves your problem? If that works, I'll get a new release out ASAP.

commented

Appears to work perfectly, transfers correctly between metalchests diamond chests, and between vanilla and diamond chest.

Great job!

commented

Fairly soon, but I'm working on a couple more things before an 0.8.0 release...

commented

Do you have an eta when 260 will be officially released on curse? Would like to update my modpack.

Many thanks.

commented

Fixed in 0.8.0 release