Crash upon using the armor's config GUI
Lucr1 opened this issue · 7 comments
Minecraft Version
1.12.2
Forge Version
14.23.5.2768
Mod Version
1.12.2-0.8.1-274
1.12.2-0.8.0-268
1.12.2-0.8.0-267
1.12.2-0.7.8-259
1.12.2-0.7.6-254
1.12.2-0.7.5-248
Describe your problem, including steps to reproduce it
Upon pressing U [the key bound to this mod's armor config screen], the game crashes every time.
Any other comments?
Using the Gregblock 1.2.0 pack. It didn't seem to happen in Gregblock 1.1.3.
Dupe of #254 but I reproduced the crash with debug build 268 (attached log).
Thank you, Lucr1. I'll have to hop back on MC again soon, as I loved playing with this mod and flying around like a lunatic.
And thank you desht for fixing the bug. Not doing any mentions because this is long closed. Sorry, I was ultra busy over the past few months so that's why I wasn't able to reply.
Thanks, that does help a bit, though it still doesn't explain the mystery. Your log shows that the code which scans each armor piece (on both client & server side) never runs, which makes no sense because that's run from a player tick event handler - the scan code should always get called 1 tick after equipping the armor piece.
Would also be interesting to know which mods were changed/updated between 1.1.3 and 1.2.0 of the pack, though I suspect it's quite a lot. It does suggest that some other mod is interfering here, but it's hard to see how...
OK, build 278 from http://jenkins.k-4u.nl/job/PneumaticCraft-Repressurized/ has some timing adjustments for armor scanning. No idea if it will help, but worth trying out...
Whatever you changed seemed to have done the trick. I'm not crashing at all with build 278 anymore and everything's working. Thank you!
A couple more questions for you (I'm going to download Gregblock later and see if I can reproduce it):
- Are you in single player or on a server?
- Which armor pieces were you wearing, and what upgrades (if any) were in each piece?
- Your log file suggests the crash happened almost immediately after you logged in - is that the case? Did you try to open the GUI immediately on login?
I'm also going to upload another build to Jenkins soon with a couple of tweaks that may or may not help - would be useful if you could try that out. I'll let you know when it's available.