PneumaticCraft: Repressurized

PneumaticCraft: Repressurized

50M Downloads

Charging module to Aerial interface excessive tick time

Sakata-MC opened this issue · 3 comments

commented

For feature requests, just erase this template and clearly describe the feature you'd like to see

Minecraft Version

1.12.2

Forge Version

2844

Mod Version

0.11.7-675

Describe your problem, including steps to reproduce it

Noticing server lag, and trying to go through and eliminate worst offenders. There is a system with aerial interface causing a fair bit of lag. Player has a charging module with advanced PCB under aerial interface. It's the highest time on the server in several profiling runs.
image
image
image

Any other comments?

If there is anything I can do to help with this, please let me know. I'm not sure why this one pipe is causing so much lag. the player this one is connected to only has the armor equipped, along with a wrench at times (lives in a morph-o-tool if that has anything to do with it)

commented

Hmm, shouldn't be so high. I did spend some time optimizing this a few releases back and I thought it was performing a lot better than this. I'll do some investigation though.

It would be useful to know if it also happens without an Advanced PCB installed (I suspect it does, but I'd like to know for sure)

commented

Update: did some testing and yes, there is some slowness with the charging module and pneumatic armor (specifically the armor, not so much other items).

However, 1901μs/t still seems extremely high - I was seeing more like 180μs/t in my testing. This was on my i7-4770k dev machine so not super high-end or anything.

Anyway, I've made a change which halved the tick time for me (down to 87μs/t). Can you give build 378 from https://jenkins.k-4u.nl/job/PneumaticCraft-Repressurized/ a go and let me know if it helps?

commented

Fixed in 0.11.8 release