Minecraft Version

1.14.4

Forge Version

28.2.4
pneumaticcraft-repressurized-1.14.4-1.0.1-10

How can you feed oil into the refinery?

The allthemods4 pack has silent's machines and oil, it looks like the oil is compatible and the tooltip says it can be refined.

Any other comments?

I've tried various things including liquid hoppers, buckets, logistic frames, drones and modules. Also tried immersive engineering's pipes and tank.

BTW, the changes on the pressure chamber are nice. There is no JEI recipe for the manual. If you replace the vacuum pump with a pipe, the pipe keeps the negative pressure.

Are you feeding into the Refinery Controller? Refinery multiblock is a little different in 1.14/1.15 - you need a Refinery Controller, then stack 2-4 Refinery Outputs either on top of or beside the controller.

Only the controller will accept fluids; the outputs are, well, output only :)

The valid ways of building it:

JEI not showing the manual recipe is a known issue with JEI. I've worked around it in 1.15.2, I suppose I could backport those changes to 1.14. (1.15 is getting all new development, with only critical fixes backported to 1.14)

Got a bit more info about the vacuum pump/pressure tube issue? Not quite sure I understand what you mean there.

Yes indeed, while you were replying I added a bucket of pneumaticcraft:oil using creative to get the bucket. And sure enough it went in to the refinery.

So if I create an oil_2.json for a tower with two outputs

{
  "input": {
    "type": "silents_mechanisms:fluid",
    "fluid": "silents_mechanisms:oil",
    "amount": 10
  },
  "results": [
    {
      "fluid": "pneumaticcraft:diesel",
      "amount": 4
    },
    {
      "fluid": "pneumaticcraft:lpg",
      "amount": 2
    }
  ]
}

I'm not sure where to place the file, currently it is here:

D:\MultiMC\instances\All-the-Mods-4-1.3\minecraft\saves\world\datapacks\pneumaticcraft\data\pneumaticcraft\machine_recipes\refinery\oil_2.json

There is a bluepower datapack installed with a similar path.

Does this look correct? It takes quite a few minutes to start the modpack and load a game.

"type" should be "pneumaticcraft:fluid" - that's the ingredient type, not the fluid name (it tells Minecraft how to parse the Json into a suitable fluid ingredient - using a custom fluid ingredient parser that PNC:R adds). Otherwise, the recipe looks good.

The JSON should go in saves/world/datapacks/YOURDATAPACKNAME/data/pneumaticcraft/pneumaticcraft/machine_recipes/refinery/RECIPE_ID.json, where

• YOURPACKNAME is the name of the data pack you are adding (can be anything you want, but must also contain a valid pack.mcmeta file - see https://minecraft.gamepedia.com/Data_pack). Loks like you're using pneumaticcraft there, which is fine. Personally I'd use a more general datapack name like recipe_tweaks (you might want to tweak other recipes too), but whatever works for you.
• RECIPE_ID is the unique ID for the recipe. If you use oil_2.json, you'll overwrite the default oil_2 which PNC:R adds, which you may or may not wish to do. You could use something like silents_oil_2.json if you want both recipes to be in effect.

And yes, pneumaticcraft/pneumaticcraft isn't a typo there, it should appear twice...

Yes, I tried both configurations. Is there a specific face where the oil is needed to be fed? In the picture the right small tank has 1 bucket of silent's mechanism's oil. I tried with and without filters on the logistic frames.

There's no need to backport the changes, I would be nice if the recipe was on the github or curseforge page. I just couldn't remember if I had to pressurize a book or if it was a crafting recipe. The penny dropped eventually.

Honestly, I don't know which version of Minecraft to play as the Minecraft versions are changing so quickly. If the forge API is very different with each version then it may be too much work for developers to keep up.

It was a bit like this (the vacuum pump was reversed), the compression chamber has -1 bar, the pipes were disconnected as shown. Next the pump was replaced with a pipe. The pipe has -1 bar and it didn't pressurize even when the stop was removed. The fix was to break the pipe again.

Ah, wait - just noticed you're trying to pump a different mod's oil in? Due to way fluids have changed in 1.14+ (they're now namespaced, like items), the Refinery won't by default take oil from other mods - it only accepts the pneumaticcraft:oil fluid.

That can be worked around by adding new Refinery recipes via a datapack. You can put recipes in data/<modid>/pneumaticcraft/machine_recipes/refinery/*.json to add or override Refinery recipes. See https://github.com/TeamPneumatic/pnc-repressurized/tree/1.14/src/main/resources/data/pneumaticcraft/pneumaticcraft/machine_recipes/refinery for an example of the existing recipes.

In the next 1.15.2 release, it will be a bit simpler since all fluids & recipes are done with tags (also all machine recipes are handled through the vanilla recipe system, so found in data/pneumaticcraft/recipes/<machine-type>/*.json). Just adding another fluid to the pneumaticcraft:oil fluid tag will be sufficient to make the refinery accept it.

And yeah, the whole 1.14/1.15 situation is a bit confusing right now. My feeling is that most modders (at least all the ones I've talked to on Discord) are more interested on working on 1.15, since it'll be a lot easier to port forward once 1.16 is release.

But then again, Forge has decided that 1.14 should be a LTS release, so... shrug

The vacuum pump issue sounds a bit like something (a tile entity or capability) has been cached and not cleared properly. I'll see if I can reproduce that.

Did I mess something up, both silents_mechanisms:oil and pneumaticcraft:oil are processing but not producing any output.

The liquid is in the output tanks but when the controller GUI is opened it disappears from the tanks.

Thank you very much, works nicely.

oil.zip - This works better.

I guessed that pneumaticcraft/pneumaticcraft was deliberate from the git repo. Wasn't sure if the RECIPE_ID needed to be specific or just anything. I know you are very observant and would notice this.

Delighted pnc-repressurized is now in 1.14.4 as it is a really fun mod. Looking forward for more drone programming with the lego pieces.

BTW, this is why I thought I could use silent's mechanisms oil

Hmm, yeah - that's a bug :)

Yeah, I think there is a GUI sync bug there. I fixed something very similar on 1.15, with luck it will be a simple backport.

The refinery should work otherwise, this is a just a sync issue, I think.

OK, v1.0.2 has been released which I think addresses all of the issues here. Give it a go :)

I also made it easier to add new fluids for Refinery (or TPP) purposes - they now use fluid tags, so you can just add the other fluid to (say) pneumaticcraft:oil to get it accepted in the Refinery.

E.g. if you add this to datapacks/duncanwebb/data/pneumaticcraft/tags/fluids/oil.json:

{
  "replace": "false",
  "values":  [
     "silents_mechanisms:oil"
  ]
}

and you shouldn't need the custom recipes you added anymore.

Update: added missing comma on "replace" line

Hmm, that looks correct (yes only one pneumaticcraft needed in this case)... what do you mean by "description of the datapack" ?

Just tested in my dev instance, where I don't have silent's installed so I added minecraft:lava to pneumaticcraft:oil.

$ cat saves/New-World/datapacks/extra_resources/data/pneumaticcraft/tags/fluids/oil.json
{
	"replace": false,
	"values": [
		"minecraft:lava"
	]
}

That works correctly for me; I can put lava in the Refinery and it refines it just like oil.

The disappearing-fluids-while-GUI-open problem seems to be a ather general rendering issue - all of my rendered fluids (in any machine, not just Refinery) don't render when any GUI is open.

Not going to treat that as urgent, since everything renders fine in-game :)

No comma after the false in the json file, guess that's it.

The pack.mcmeta contains:

{
    "pack": {
        "pack_format": 4,
        "description": "pnc refinery for silents oil"
    }
}

Was wondering where the description is used?

Ah, right - if you run /datapack list in game (i.e. not on the server console), then if you hover over the displayed datapack name, it should show the description as a tooltip.

And yeah, missed a comma in my original example, sorry :/

Thank you again.

No problem, many thanks for the fixes and help.

Looks way better, many thanks. The refinery outputs disappear when the controller is accessed.

The tooltip is also fixed.

Is the path correct as it doesn't work with this path? Is only one pneumaticcraft correct?
D:\MultiMC\instances\All-the-Mods-4-1.3\minecraft\saves\world\datapacks\silents\data\pneumaticcraft\tags\fluids\oil.json

I see the datapack is loaded as /datapack list shows , [file/silents]. Is there a way to see the description of the datapack?