Oil Tag for compatibility
MuteTiefling opened this issue ยท 8 comments
So I ran into the issue was referenced here: #454 where oil wasn't allowed to go in. I eventually realized it was also Silent's oil upon finding that post.
I didn't want to do a datapack to fix it, so I instead went the CraftTweaker route. In doing so I came to realize that Silent's is actually referring to it's own oil as 'forge:oil' in its recipes. So I used that in my CT script and it worked to add the recipes to the PNC refinery.
This got me thinking that it might be nice for PNC to simply use the forge tag in the Refinery. I'd think this should automatically solve any compatibility issues.
Hmm, this needs a little thought. I would have thought the tag should really be forge:fluids/oil (following the forge:ingots/XXX convention).
I'm not quite decided on whether I should just allow any other oil in by default, or whether it should be left to the modpack maker to determine all aspects of cross-mod compatibility...
Well the fluids/ part is implied, since it's a fluid tag. There's not really anything else it'd be, unless you want folders for liquid/gas. That'd be kinda pointless though since it's not like there'd be much overlap.
I have to say that it was always nice that it was immediately compatible with other mod's oils in previous versions. Some basic cross mod compat just makes things feel cleaner.
Well the
fluids/part is implied, since it's a fluid tag. There's not really anything else it'd be, unless you want folders for liquid/gas. That'd be kinda pointless though since it's not like there'd be much overlap.
Yeah, fair point!
OK, I've moved Oil & Lubricant to forge:oil & forge:lubricant tags - tested with Silent Mechanisms, and their oil is now accepted by default in the refinery. You can play with this in build 8+ from https://jenkins.k-4u.nl/job/PneumaticCraft-Repressurized-1.15/
I have to say that it was always nice that it was immediately compatible with other mod's oils in previous versions. Some basic cross mod compat just makes things feel cleaner.
Yeah, I get that. That was mainly because fluids had no namespacing in 1.12, unlike items. So if two mods registered "oil", that was it. Now we have "pneumaticcraft:oil", "silentmechanisms:oil", and so on. I guess accepting a "forge:oil" fluid tag would be alright here (and I'll add "pneumaticcraft:oil" to "forge:oil").
Now to decide about all the other fluids (e.g. should there be a "forge:lpg", "forge:lubricant", and so on?)